Re: [PATCH v1 2/6] arm: add generic TEE mediator framework

[Volodymyr Babchuk <volodymyr_babchuk@epam.com>]

Hi Julien,


On 22.08.18 20:03, Julien Grall wrote:

[...]

>>       if ( is_hardware_domain(d) && (rc = domain_vuart_init(d)) )
>>           goto fail;
>> +    /* Notify TEE that new domain was created */
>> +    tee_domain_create(d);
> 
> My concern about domain creation is still not addressed. I would expect 
> the toolstack to decide whether TEE should be initialized for a given 
> guest and potentially return an error on failure (e.g maximum client ID 
> has been reached).
> 
> But very likely, you don't need to initialize TEE that early. This could 
> be done in a separate DOMCTL as we did for VPL011.

Yes, as we discussed in latter patches, I'll add DOMCTL support. But 
what to do with dom0 construction?
I think, it should be configurable. But how? With commandline option?

[...]

> }
> 
>> +    printk(XENLOG_WARNING "No TEE mediator found\n");
> 
> Not having a TEE is a valid use case. So printing a warning seems a bit 
> too much.

I can change this to INFO. Or it is better to remove this print at all?


Thank you for review, BTW.

-- 
Volodymyr Babchuk

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel