Re: [PATCH v1 1/6] arm: add SMC wrapper that is compatible with SMCCC

From: Julien Grall <julien.grall@arm.com>
To: Volodymyr Babchuk <volodymyr_babchuk@epam.com>,
	Jan Beulich <JBeulich@suse.com>
Cc: Lars Kurth <lars.kurth@xenproject.org>,
	nd@arm.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v1 1/6] arm: add SMC wrapper that is compatible with SMCCC
Date: Mon, 27 Aug 2018 21:19:02 +0100	[thread overview]
Message-ID: <de2b93d1-4760-3046-7711-c546f56165fa@arm.com> (raw)
In-Reply-To: <a49c68af-7549-45dc-f4fd-0018dbd44437@epam.com>

Hello,

On 27/08/2018 20:24, Volodymyr Babchuk wrote:
> 
> 
> On 27.08.18 09:44, Jan Beulich wrote:
> 
> [...]
> 
>>>   xen/arch/arm/arm32/Makefile      |  1 +
>>>   xen/arch/arm/arm32/smc.S         | 39 
>>> +++++++++++++++++++++++++++++++++++++++
>>>   xen/arch/arm/arm64/Makefile      |  1 +
>>>   xen/arch/arm/arm64/asm-offsets.c |  4 ++++
>>>   xen/arch/arm/arm64/smc.S         | 30 ++++++++++++++++++++++++++++++
>>>   xen/include/asm-arm/processor.h  | 11 +++++++++++
>>>   6 files changed, 86 insertions(+)
>>>   create mode 100644 xen/arch/arm/arm32/smc.S
>>>   create mode 100644 xen/arch/arm/arm64/smc.S
>>
>> With this diffstat, why did I end up on the _To_ list of this patch?
>> I shouldn't even have been on the Cc list (and I'm going to blindly
>> delete all other patches of this series where you've also
>> apparently put me on the To list). Please remember that patches
>> are supposed to be sent _To_ the list, with maintainers, reviewers
>> (and perhaps others) Cc-ed. Together with people replying to
>> mails often not adjusting To/Cc lists accordingly, I've now ended
>> up with well over 30 mails in my primary mail folder which
>> presumably I have no business with at all.
> 
> My apologies for disturbing you. I really have no intention to upset you.
> I used get_maintainer.pl script and it showed your e-mail address. So I 
> added you to To: list.
> 
> Now I tried add_mandainers.pl and it nevertheless adds you to CCs.
> So, I'm really sorry bothering you. But probably you might want to fix 
> mentioned scripts/MAINTAINERS  file, to make sure you will never receive 
> unwanted emails?

I did try add_maintainers.pl/get_maintainer.pl on that patch and I get
only Stefano and I CCed. So more likely you are not using the scripts correctly.

42sh> ls *.patch
0001-arm-add-SMC-wrapper-that-is-compatible-with-SMCCC.patch

42sh> scripts/get_maintainers.pl 0001-arm-add-SMC-wrapper-that-is-compatible-with-SMCCC.patch
Stefano Stabellini <sstabellini@kernel.org>
Julien Grall <julien.grall@arm.com>
xen-devel@lists.xenproject.org

42sh> scripts/add_maintainers.pl -d .
Processing: 0001-arm-add-SMC-wrapper-that-is-compatible-with-SMCCC.patch
Then perform:
git send-email -to xen-devel@lists.xenproject.org ./*.patch

42sh> ack "Cc|To" 0001-arm-add-SMC-wrapper-that-is-compatible-with-SMCCC.patch
To: xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Julien Grall <julien.grall@arm.com>

Note that we fixed one issue in add_maintainers.pl that would lead to your
problem. However, this was merged nearly 3 months ago and I would expect
your series to be based on staging...

So you probably want to do upstream development on staging or change
your command line. If the documentation is misleading,
then contribution will be appreciated.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel