From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Yassine Oudjana <yassine.oudjana@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Andy Teng <andy.teng@mediatek.com> Cc: Yassine Oudjana <y.oudjana@protonmail.com>, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count Date: Mon, 10 Oct 2022 13:47:18 +0200 [thread overview] Message-ID: <6c889c7e-4c5a-a201-e37c-bf95b6826584@collabora.com> (raw) In-Reply-To: <0769c6c8-567d-68c0-323a-9aaee1241e13@linaro.org> Il 10/10/22 13:13, Krzysztof Kozlowski ha scritto: > On 07/10/2022 08:58, Yassine Oudjana wrote: >> From: Yassine Oudjana <y.oudjana@protonmail.com> >> >> The document currently states a maximum of 1 interrupt, but the DT >> has 2 specified causing a dtbs_check error. Replace the maximum limit >> with a minimum and add per-interrupt descriptions to pass the check. >> >> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >> --- >> .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> index 73ae6e11410b..a3a3f7fb9605 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> @@ -47,7 +47,10 @@ properties: >> >> interrupts: >> description: The interrupt outputs to sysirq. >> - maxItems: 1 >> + minItems: 1 >> + items: >> + - description: EINT interrupt >> + - description: EINT event_b interrupt > > Is second interrupt really optional or you just wanted to silence the > warning? > The event_b interrupt exists (and fires on certain events, if configured to do so), but it's currently unused. It's really optional. > Best regards, > Krzysztof >
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Yassine Oudjana <yassine.oudjana@gmail.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Andy Teng <andy.teng@mediatek.com> Cc: Yassine Oudjana <y.oudjana@protonmail.com>, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count Date: Mon, 10 Oct 2022 13:47:18 +0200 [thread overview] Message-ID: <6c889c7e-4c5a-a201-e37c-bf95b6826584@collabora.com> (raw) In-Reply-To: <0769c6c8-567d-68c0-323a-9aaee1241e13@linaro.org> Il 10/10/22 13:13, Krzysztof Kozlowski ha scritto: > On 07/10/2022 08:58, Yassine Oudjana wrote: >> From: Yassine Oudjana <y.oudjana@protonmail.com> >> >> The document currently states a maximum of 1 interrupt, but the DT >> has 2 specified causing a dtbs_check error. Replace the maximum limit >> with a minimum and add per-interrupt descriptions to pass the check. >> >> Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com> >> --- >> .../devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> index 73ae6e11410b..a3a3f7fb9605 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,pinctrl-mt6795.yaml >> @@ -47,7 +47,10 @@ properties: >> >> interrupts: >> description: The interrupt outputs to sysirq. >> - maxItems: 1 >> + minItems: 1 >> + items: >> + - description: EINT interrupt >> + - description: EINT event_b interrupt > > Is second interrupt really optional or you just wanted to silence the > warning? > The event_b interrupt exists (and fires on certain events, if configured to do so), but it's currently unused. It's really optional. > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-10 11:48 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-07 12:58 [PATCH v3 00/10] MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support Yassine Oudjana 2022-10-07 12:58 ` Yassine Oudjana 2022-10-07 12:58 ` [PATCH v3 01/10] arm64: dts: mediatek: mt6779: Remove syscon compatible from pin controller Yassine Oudjana 2022-10-07 12:58 ` Yassine Oudjana 2022-10-07 12:58 ` [PATCH v3 02/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Improve description Yassine Oudjana 2022-10-07 12:58 ` Yassine Oudjana 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-07 12:58 ` [PATCH v3 03/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Make gpio-ranges optional Yassine Oudjana 2022-10-07 12:58 ` Yassine Oudjana 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-07 12:58 ` [PATCH v3 04/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6797 Yassine Oudjana 2022-10-07 12:58 ` Yassine Oudjana 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-07 12:58 ` [PATCH v3 05/10] dt-bindings: pinctrl: mediatek,pinctrl-mt6795: Fix interrupt count Yassine Oudjana 2022-10-07 12:58 ` Yassine Oudjana 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-10 11:13 ` Krzysztof Kozlowski 2022-10-10 11:13 ` Krzysztof Kozlowski 2022-10-10 11:47 ` AngeloGioacchino Del Regno [this message] 2022-10-10 11:47 ` AngeloGioacchino Del Regno 2022-10-10 12:57 ` Rob Herring 2022-10-10 12:57 ` Rob Herring 2022-10-11 10:03 ` AngeloGioacchino Del Regno 2022-10-11 10:03 ` AngeloGioacchino Del Regno 2022-10-07 12:59 ` [PATCH v3 06/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Add MT6795 Yassine Oudjana 2022-10-07 12:59 ` Yassine Oudjana 2022-10-10 11:24 ` Krzysztof Kozlowski 2022-10-10 11:24 ` Krzysztof Kozlowski 2022-10-20 11:36 ` Yassine Oudjana 2022-10-20 11:36 ` Yassine Oudjana 2022-10-20 12:21 ` Krzysztof Kozlowski 2022-10-20 12:21 ` Krzysztof Kozlowski 2022-10-21 8:19 ` AngeloGioacchino Del Regno 2022-10-21 8:19 ` AngeloGioacchino Del Regno 2022-10-07 12:59 ` [PATCH v3 07/10] arm64: dts: mediatek: mt6797: Make pin configuration nodes follow DT bindings Yassine Oudjana 2022-10-07 12:59 ` Yassine Oudjana 2022-10-07 12:59 ` [PATCH v3 08/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6765 pin controller Yassine Oudjana 2022-10-07 12:59 ` Yassine Oudjana 2022-10-10 11:25 ` Krzysztof Kozlowski 2022-10-10 11:25 ` Krzysztof Kozlowski 2022-10-07 12:59 ` [PATCH v3 09/10] dt-bindings: pinctrl: mediatek,mt6779-pinctrl: Document MT6735 " Yassine Oudjana 2022-10-07 12:59 ` Yassine Oudjana 2022-10-10 11:25 ` Krzysztof Kozlowski 2022-10-10 11:25 ` Krzysztof Kozlowski 2022-10-07 12:59 ` [PATCH v3 10/10] pinctrl: mediatek: Add MT6735 pinctrl driver Yassine Oudjana 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-10 8:16 ` AngeloGioacchino Del Regno 2022-10-17 9:13 ` [PATCH v3 00/10] MediaTek pinctrl DT binding cleanup and MT6735 pinctrl support Linus Walleij 2022-10-17 9:13 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6c889c7e-4c5a-a201-e37c-bf95b6826584@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=andy.teng@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@kernel.org \ --cc=y.oudjana@protonmail.com \ --cc=yassine.oudjana@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.