* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode @ 2021-04-05 14:44 ` Aswath Govindraju 2021-04-05 22:18 ` Jaehoon Chung ` (2 more replies) 0 siblings, 3 replies; 16+ messages in thread From: Aswath Govindraju @ 2021-04-05 14:44 UTC (permalink / raw) To: u-boot From: Faiz Abbas <faiz_abbas@ti.com> Enable HS400 speed mode by writing to HOST_CONTROL2 register. Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> --- drivers/mmc/sdhci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index d9ab6a0a839e..eea4701d8af5 100644 --- a/drivers/mmc/sdhci.c +++ b/drivers/mmc/sdhci.c @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) case MMC_HS_200: reg |= SDHCI_CTRL_UHS_SDR104; break; + case MMC_HS_400: + reg |= SDHCI_CTRL_HS400; + break; default: reg |= SDHCI_CTRL_UHS_SDR12; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-05 14:44 ` [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode Aswath Govindraju @ 2021-04-05 22:18 ` Jaehoon Chung 2021-04-06 5:20 ` Aswath Govindraju 2021-04-06 22:22 ` Jaehoon Chung 2021-07-29 5:14 ` Lokesh Vutla 2 siblings, 1 reply; 16+ messages in thread From: Jaehoon Chung @ 2021-04-05 22:18 UTC (permalink / raw) To: u-boot Hi, On 4/5/21 11:44 PM, Aswath Govindraju wrote: > From: Faiz Abbas <faiz_abbas@ti.com> > > Enable HS400 speed mode by writing to HOST_CONTROL2 register. I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) If I missed something, let me know, plz. In include/sdhci.h, it mentioned to "Non-standard". Best Regards, Jaehoon Chung > > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> > --- > drivers/mmc/sdhci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index d9ab6a0a839e..eea4701d8af5 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) > case MMC_HS_200: > reg |= SDHCI_CTRL_UHS_SDR104; > break; > + case MMC_HS_400: > + reg |= SDHCI_CTRL_HS400; > + break; > default: > reg |= SDHCI_CTRL_UHS_SDR12; > } > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-05 22:18 ` Jaehoon Chung @ 2021-04-06 5:20 ` Aswath Govindraju 2021-04-06 8:26 ` Aswath Govindraju 0 siblings, 1 reply; 16+ messages in thread From: Aswath Govindraju @ 2021-04-06 5:20 UTC (permalink / raw) To: u-boot Hi Jaehoon, On 06/04/21 3:48 am, Jaehoon Chung wrote: > Hi, > > On 4/5/21 11:44 PM, Aswath Govindraju wrote: >> From: Faiz Abbas <faiz_abbas@ti.com> >> >> Enable HS400 speed mode by writing to HOST_CONTROL2 register. > > I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) > If I missed something, let me know, plz. > > In include/sdhci.h, it mentioned to "Non-standard". > Thank you for pointing this out. Yes, this is not a part of SD specification and in the specification this field is marked as reserved. I have added this, as this bit mask has been defined in include/sdhci.h. Sorry about this. I'll post a respin taking this into a consideration. Thanks, Aswath > Best Regards, > Jaehoon Chung > >> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >> --- >> drivers/mmc/sdhci.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >> index d9ab6a0a839e..eea4701d8af5 100644 >> --- a/drivers/mmc/sdhci.c >> +++ b/drivers/mmc/sdhci.c >> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >> case MMC_HS_200: >> reg |= SDHCI_CTRL_UHS_SDR104; >> break; >> + case MMC_HS_400: >> + reg |= SDHCI_CTRL_HS400; >> + break; >> default: >> reg |= SDHCI_CTRL_UHS_SDR12; >> } >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-06 5:20 ` Aswath Govindraju @ 2021-04-06 8:26 ` Aswath Govindraju 2021-04-06 9:14 ` Jaehoon Chung 0 siblings, 1 reply; 16+ messages in thread From: Aswath Govindraju @ 2021-04-06 8:26 UTC (permalink / raw) To: u-boot Hi Jaehoon, On 06/04/21 10:50 am, Aswath Govindraju wrote: > Hi Jaehoon, > > On 06/04/21 3:48 am, Jaehoon Chung wrote: >> Hi, >> >> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>> From: Faiz Abbas <faiz_abbas@ti.com> >>> >>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >> >> I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) >> If I missed something, let me know, plz. >> >> In include/sdhci.h, it mentioned to "Non-standard". >> > > Thank you for pointing this out. > > Yes, this is not a part of SD specification and in the specification > this field is marked as reserved. I have added this, as this bit mask > has been defined in include/sdhci.h. Sorry about this. I'll post a > respin taking this into a consideration. > On the other hand, the same has been accepted in kernel i.e. setting SDHCI_CTRL_HS400 bit in HOST_CONTROL2 register, drivers/mmc/host/sdhci.c in sdhci_set_uhs_signaling(). I think although this bit has not been mentioned in the specification, it seems it is used by many controllers for HS400 mode. So, as this is not specific to a controller can setting this, be allowed in the common sdhci_set_uhs_timing() function ? Thanks, Aswath > Thanks, > Aswath > >> Best Regards, >> Jaehoon Chung >> >>> >>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>> --- >>> drivers/mmc/sdhci.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>> index d9ab6a0a839e..eea4701d8af5 100644 >>> --- a/drivers/mmc/sdhci.c >>> +++ b/drivers/mmc/sdhci.c >>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>> case MMC_HS_200: >>> reg |= SDHCI_CTRL_UHS_SDR104; >>> break; >>> + case MMC_HS_400: >>> + reg |= SDHCI_CTRL_HS400; >>> + break; >>> default: >>> reg |= SDHCI_CTRL_UHS_SDR12; >>> } >>> >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-06 8:26 ` Aswath Govindraju @ 2021-04-06 9:14 ` Jaehoon Chung 0 siblings, 0 replies; 16+ messages in thread From: Jaehoon Chung @ 2021-04-06 9:14 UTC (permalink / raw) To: u-boot Hi Aswath, On 4/6/21 5:26 PM, Aswath Govindraju wrote: > Hi Jaehoon, > > On 06/04/21 10:50 am, Aswath Govindraju wrote: >> Hi Jaehoon, >> >> On 06/04/21 3:48 am, Jaehoon Chung wrote: >>> Hi, >>> >>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>> >>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>> >>> I didn't find HS400 bit at HOST_CONTROL2 register. (I have checked SD Specific v4.20) >>> If I missed something, let me know, plz. >>> >>> In include/sdhci.h, it mentioned to "Non-standard". >>> >> >> Thank you for pointing this out. >> >> Yes, this is not a part of SD specification and in the specification >> this field is marked as reserved. I have added this, as this bit mask >> has been defined in include/sdhci.h. Sorry about this. I'll post a >> respin taking this into a consideration. >> > > On the other hand, the same has been accepted in kernel i.e. setting > SDHCI_CTRL_HS400 bit in HOST_CONTROL2 register, drivers/mmc/host/sdhci.c > in sdhci_set_uhs_signaling(). I think although this bit has not been > mentioned in the specification, it seems it is used by many controllers > for HS400 mode. So, as this is not specific to a controller can setting > this, be allowed in the common sdhci_set_uhs_timing() function ? Frankly, i think that it can be used. Just I wondered that i missed something from Specification. :) Thanks for sharing information. I didn't check on kernel side. Best Regards, Jaehoon Chung > > Thanks, > Aswath > >> Thanks, >> Aswath >> >>> Best Regards, >>> Jaehoon Chung >>> >>>> >>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>>> --- >>>> drivers/mmc/sdhci.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>>> index d9ab6a0a839e..eea4701d8af5 100644 >>>> --- a/drivers/mmc/sdhci.c >>>> +++ b/drivers/mmc/sdhci.c >>>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>>> case MMC_HS_200: >>>> reg |= SDHCI_CTRL_UHS_SDR104; >>>> break; >>>> + case MMC_HS_400: >>>> + reg |= SDHCI_CTRL_HS400; >>>> + break; >>>> default: >>>> reg |= SDHCI_CTRL_UHS_SDR12; >>>> } >>>> >>> >> > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-05 14:44 ` [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode Aswath Govindraju 2021-04-05 22:18 ` Jaehoon Chung @ 2021-04-06 22:22 ` Jaehoon Chung 2021-05-10 13:48 ` Aswath Govindraju 2021-07-29 5:14 ` Lokesh Vutla 2 siblings, 1 reply; 16+ messages in thread From: Jaehoon Chung @ 2021-04-06 22:22 UTC (permalink / raw) To: u-boot On 4/5/21 11:44 PM, Aswath Govindraju wrote: > From: Faiz Abbas <faiz_abbas@ti.com> > > Enable HS400 speed mode by writing to HOST_CONTROL2 register. > > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > drivers/mmc/sdhci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c > index d9ab6a0a839e..eea4701d8af5 100644 > --- a/drivers/mmc/sdhci.c > +++ b/drivers/mmc/sdhci.c > @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) > case MMC_HS_200: > reg |= SDHCI_CTRL_UHS_SDR104; > break; > + case MMC_HS_400: > + reg |= SDHCI_CTRL_HS400; > + break; > default: > reg |= SDHCI_CTRL_UHS_SDR12; > } > ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-06 22:22 ` Jaehoon Chung @ 2021-05-10 13:48 ` Aswath Govindraju 2021-06-09 15:26 ` Aswath Govindraju 0 siblings, 1 reply; 16+ messages in thread From: Aswath Govindraju @ 2021-05-10 13:48 UTC (permalink / raw) To: u-boot Hi Peng, On 07/04/21 3:52 am, Jaehoon Chung wrote: > On 4/5/21 11:44 PM, Aswath Govindraju wrote: >> From: Faiz Abbas <faiz_abbas@ti.com> >> >> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >> >> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> > > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > Can you please pick this patch if there are no comments. Thanks, Aswath > Best Regards, > Jaehoon Chung > >> --- >> drivers/mmc/sdhci.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >> index d9ab6a0a839e..eea4701d8af5 100644 >> --- a/drivers/mmc/sdhci.c >> +++ b/drivers/mmc/sdhci.c >> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >> case MMC_HS_200: >> reg |= SDHCI_CTRL_UHS_SDR104; >> break; >> + case MMC_HS_400: >> + reg |= SDHCI_CTRL_HS400; >> + break; >> default: >> reg |= SDHCI_CTRL_UHS_SDR12; >> } >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-05-10 13:48 ` Aswath Govindraju @ 2021-06-09 15:26 ` Aswath Govindraju 2021-07-19 6:48 ` Aswath Govindraju 0 siblings, 1 reply; 16+ messages in thread From: Aswath Govindraju @ 2021-06-09 15:26 UTC (permalink / raw) To: Peng Fan Cc: Jaehoon Chung, u-boot, Praneeth Bajjuri, Lokesh Vutla, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas Hi Peng, On 10/05/21 7:18 pm, Aswath Govindraju wrote: > Hi Peng, > > On 07/04/21 3:52 am, Jaehoon Chung wrote: >> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>> From: Faiz Abbas <faiz_abbas@ti.com> >>> >>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>> >>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >> >> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >> > > Can you please pick this patch if there are no comments. > May I know if this okay to be merged ? Thanks, Aswath > Thanks, > Aswath > >> Best Regards, >> Jaehoon Chung >> >>> --- >>> drivers/mmc/sdhci.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>> index d9ab6a0a839e..eea4701d8af5 100644 >>> --- a/drivers/mmc/sdhci.c >>> +++ b/drivers/mmc/sdhci.c >>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>> case MMC_HS_200: >>> reg |= SDHCI_CTRL_UHS_SDR104; >>> break; >>> + case MMC_HS_400: >>> + reg |= SDHCI_CTRL_HS400; >>> + break; >>> default: >>> reg |= SDHCI_CTRL_UHS_SDR12; >>> } >>> >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-06-09 15:26 ` Aswath Govindraju @ 2021-07-19 6:48 ` Aswath Govindraju 2021-07-19 22:15 ` Jaehoon Chung 0 siblings, 1 reply; 16+ messages in thread From: Aswath Govindraju @ 2021-07-19 6:48 UTC (permalink / raw) To: Peng Fan Cc: Jaehoon Chung, u-boot, Praneeth Bajjuri, Lokesh Vutla, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas Hi Peng, On 09/06/21 8:56 pm, Aswath Govindraju wrote: > Hi Peng, > > On 10/05/21 7:18 pm, Aswath Govindraju wrote: >> Hi Peng, >> >> On 07/04/21 3:52 am, Jaehoon Chung wrote: >>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>> >>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>>> >>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>> >>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >>> >> >> Can you please pick this patch if there are no comments. >> > > May I know if this okay to be merged ? > A gentle reminder on this patch. This patch has other dependencies that and are pending merge[1][2]. [1] - https://patchwork.ozlabs.org/project/uboot/list/?series=247000 [2] - https://patchwork.ozlabs.org/project/uboot/list/?series=245579 Thanks, Aswath > Thanks, > Aswath > >> Thanks, >> Aswath >> >>> Best Regards, >>> Jaehoon Chung >>> >>>> --- >>>> drivers/mmc/sdhci.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>>> index d9ab6a0a839e..eea4701d8af5 100644 >>>> --- a/drivers/mmc/sdhci.c >>>> +++ b/drivers/mmc/sdhci.c >>>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>>> case MMC_HS_200: >>>> reg |= SDHCI_CTRL_UHS_SDR104; >>>> break; >>>> + case MMC_HS_400: >>>> + reg |= SDHCI_CTRL_HS400; >>>> + break; >>>> default: >>>> reg |= SDHCI_CTRL_UHS_SDR12; >>>> } >>>> >>> >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-07-19 6:48 ` Aswath Govindraju @ 2021-07-19 22:15 ` Jaehoon Chung 2021-07-20 4:10 ` Lokesh Vutla 0 siblings, 1 reply; 16+ messages in thread From: Jaehoon Chung @ 2021-07-19 22:15 UTC (permalink / raw) To: Aswath Govindraju, Peng Fan Cc: u-boot, Praneeth Bajjuri, Lokesh Vutla, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas Hi Aswath, On 7/19/21 3:48 PM, Aswath Govindraju wrote: > Hi Peng, > > On 09/06/21 8:56 pm, Aswath Govindraju wrote: >> Hi Peng, >> >> On 10/05/21 7:18 pm, Aswath Govindraju wrote: >>> Hi Peng, >>> >>> On 07/04/21 3:52 am, Jaehoon Chung wrote: >>>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>>> >>>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>>>> >>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>>> >>>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >>>> >>> >>> Can you please pick this patch if there are no comments. >>> >> >> May I know if this okay to be merged ? >> > > A gentle reminder on this patch. This patch has other dependencies that > and are pending merge[1][2]. I don't have the permission to merge on u-boot-mmc git. I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :) I had been already reviewed about this patch.. So if want to pick this, I think there is no problem about applied together with below patches. Acked-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > > [1] - https://protect2.fireeye.com/v1/url?k=bf905767-e00b6fae-bf91dc28-0cc47a336fae-6a3fa5da3333a309&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D247000 > [2] - https://protect2.fireeye.com/v1/url?k=c93699cd-96ada104-c9371282-0cc47a336fae-de6d85845da27eb0&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D245579 > > Thanks, > Aswath > >> Thanks, >> Aswath >> >>> Thanks, >>> Aswath >>> >>>> Best Regards, >>>> Jaehoon Chung >>>> >>>>> --- >>>>> drivers/mmc/sdhci.c | 3 +++ >>>>> 1 file changed, 3 insertions(+) >>>>> >>>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>>>> index d9ab6a0a839e..eea4701d8af5 100644 >>>>> --- a/drivers/mmc/sdhci.c >>>>> +++ b/drivers/mmc/sdhci.c >>>>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>>>> case MMC_HS_200: >>>>> reg |= SDHCI_CTRL_UHS_SDR104; >>>>> break; >>>>> + case MMC_HS_400: >>>>> + reg |= SDHCI_CTRL_HS400; >>>>> + break; >>>>> default: >>>>> reg |= SDHCI_CTRL_UHS_SDR12; >>>>> } >>>>> >>>> >>> >> > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-07-19 22:15 ` Jaehoon Chung @ 2021-07-20 4:10 ` Lokesh Vutla 2021-07-20 5:21 ` Jaehoon Chung 2021-07-20 12:16 ` Tom Rini 0 siblings, 2 replies; 16+ messages in thread From: Lokesh Vutla @ 2021-07-20 4:10 UTC (permalink / raw) To: Jaehoon Chung, Aswath Govindraju, Peng Fan Cc: u-boot, Praneeth Bajjuri, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas, Tom Rini +Tom On 20/07/21 3:45 am, Jaehoon Chung wrote: > Hi Aswath, > > On 7/19/21 3:48 PM, Aswath Govindraju wrote: >> Hi Peng, >> >> On 09/06/21 8:56 pm, Aswath Govindraju wrote: >>> Hi Peng, >>> >>> On 10/05/21 7:18 pm, Aswath Govindraju wrote: >>>> Hi Peng, >>>> >>>> On 07/04/21 3:52 am, Jaehoon Chung wrote: >>>>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>>>> >>>>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>>>>> >>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>>>> >>>>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >>>>> >>>> >>>> Can you please pick this patch if there are no comments. >>>> >>> >>> May I know if this okay to be merged ? >>> >> >> A gentle reminder on this patch. This patch has other dependencies that >> and are pending merge[1][2]. > > I don't have the permission to merge on u-boot-mmc git. > I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :) > > I had been already reviewed about this patch.. > So if want to pick this, I think there is no problem about applied together with below patches. > > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> Tom, Is it okay if I pick this patch as per above suggestion? Thanks and regards, Lokesh > > Best Regards, > Jaehoon Chung > >> >> [1] - https://protect2.fireeye.com/v1/url?k=bf905767-e00b6fae-bf91dc28-0cc47a336fae-6a3fa5da3333a309&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D247000 >> [2] - https://protect2.fireeye.com/v1/url?k=c93699cd-96ada104-c9371282-0cc47a336fae-de6d85845da27eb0&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D245579 >> >> Thanks, >> Aswath >> >>> Thanks, >>> Aswath >>> >>>> Thanks, >>>> Aswath >>>> >>>>> Best Regards, >>>>> Jaehoon Chung >>>>> >>>>>> --- >>>>>> drivers/mmc/sdhci.c | 3 +++ >>>>>> 1 file changed, 3 insertions(+) >>>>>> >>>>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>>>>> index d9ab6a0a839e..eea4701d8af5 100644 >>>>>> --- a/drivers/mmc/sdhci.c >>>>>> +++ b/drivers/mmc/sdhci.c >>>>>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>>>>> case MMC_HS_200: >>>>>> reg |= SDHCI_CTRL_UHS_SDR104; >>>>>> break; >>>>>> + case MMC_HS_400: >>>>>> + reg |= SDHCI_CTRL_HS400; >>>>>> + break; >>>>>> default: >>>>>> reg |= SDHCI_CTRL_UHS_SDR12; >>>>>> } >>>>>> >>>>> >>>> >>> >> >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-07-20 4:10 ` Lokesh Vutla @ 2021-07-20 5:21 ` Jaehoon Chung 2021-07-20 5:23 ` Lokesh Vutla 2021-07-20 12:16 ` Tom Rini 1 sibling, 1 reply; 16+ messages in thread From: Jaehoon Chung @ 2021-07-20 5:21 UTC (permalink / raw) To: Lokesh Vutla, Aswath Govindraju, Peng Fan Cc: u-boot, Praneeth Bajjuri, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas, Tom Rini Hi Lokesh, On 7/20/21 1:10 PM, Lokesh Vutla wrote: > +Tom > > On 20/07/21 3:45 am, Jaehoon Chung wrote: >> Hi Aswath, >> >> On 7/19/21 3:48 PM, Aswath Govindraju wrote: >>> Hi Peng, >>> >>> On 09/06/21 8:56 pm, Aswath Govindraju wrote: >>>> Hi Peng, >>>> >>>> On 10/05/21 7:18 pm, Aswath Govindraju wrote: >>>>> Hi Peng, >>>>> >>>>> On 07/04/21 3:52 am, Jaehoon Chung wrote: >>>>>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>>>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>>>>> >>>>>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>>>>>> >>>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>>>>> >>>>>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >>>>>> >>>>> >>>>> Can you please pick this patch if there are no comments. >>>>> >>>> >>>> May I know if this okay to be merged ? >>>> >>> >>> A gentle reminder on this patch. This patch has other dependencies that >>> and are pending merge[1][2]. >> >> I don't have the permission to merge on u-boot-mmc git. >> I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :) >> >> I had been already reviewed about this patch.. >> So if want to pick this, I think there is no problem about applied together with below patches. >> >> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > Tom, > Is it okay if I pick this patch as per above suggestion? Isn't it enough my Acked-by tag? Best Regards, Jaehoon Chung > > Thanks and regards, > Lokesh > >> >> Best Regards, >> Jaehoon Chung >> >>> >>> [1] - https://protect2.fireeye.com/v1/url?k=bf905767-e00b6fae-bf91dc28-0cc47a336fae-6a3fa5da3333a309&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D247000 >>> [2] - https://protect2.fireeye.com/v1/url?k=c93699cd-96ada104-c9371282-0cc47a336fae-de6d85845da27eb0&q=1&e=ac3de2ef-41d1-4e60-952a-16e2b302cfdd&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D245579 >>> >>> Thanks, >>> Aswath >>> >>>> Thanks, >>>> Aswath >>>> >>>>> Thanks, >>>>> Aswath >>>>> >>>>>> Best Regards, >>>>>> Jaehoon Chung >>>>>> >>>>>>> --- >>>>>>> drivers/mmc/sdhci.c | 3 +++ >>>>>>> 1 file changed, 3 insertions(+) >>>>>>> >>>>>>> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c >>>>>>> index d9ab6a0a839e..eea4701d8af5 100644 >>>>>>> --- a/drivers/mmc/sdhci.c >>>>>>> +++ b/drivers/mmc/sdhci.c >>>>>>> @@ -507,6 +507,9 @@ void sdhci_set_uhs_timing(struct sdhci_host *host) >>>>>>> case MMC_HS_200: >>>>>>> reg |= SDHCI_CTRL_UHS_SDR104; >>>>>>> break; >>>>>>> + case MMC_HS_400: >>>>>>> + reg |= SDHCI_CTRL_HS400; >>>>>>> + break; >>>>>>> default: >>>>>>> reg |= SDHCI_CTRL_UHS_SDR12; >>>>>>> } >>>>>>> >>>>>> >>>>> >>>> >>> >>> >> > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-07-20 5:21 ` Jaehoon Chung @ 2021-07-20 5:23 ` Lokesh Vutla 2021-07-20 5:26 ` Jaehoon Chung 0 siblings, 1 reply; 16+ messages in thread From: Lokesh Vutla @ 2021-07-20 5:23 UTC (permalink / raw) To: Jaehoon Chung, Aswath Govindraju, Peng Fan Cc: u-boot, Praneeth Bajjuri, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas, Tom Rini On 20/07/21 10:51 am, Jaehoon Chung wrote: > Hi Lokesh, > > On 7/20/21 1:10 PM, Lokesh Vutla wrote: >> +Tom >> >> On 20/07/21 3:45 am, Jaehoon Chung wrote: >>> Hi Aswath, >>> >>> On 7/19/21 3:48 PM, Aswath Govindraju wrote: >>>> Hi Peng, >>>> >>>> On 09/06/21 8:56 pm, Aswath Govindraju wrote: >>>>> Hi Peng, >>>>> >>>>> On 10/05/21 7:18 pm, Aswath Govindraju wrote: >>>>>> Hi Peng, >>>>>> >>>>>> On 07/04/21 3:52 am, Jaehoon Chung wrote: >>>>>>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>>>>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>>>>>> >>>>>>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>>>>>>> >>>>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>>>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>>>>>> >>>>>>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >>>>>>> >>>>>> >>>>>> Can you please pick this patch if there are no comments. >>>>>> >>>>> >>>>> May I know if this okay to be merged ? >>>>> >>>> >>>> A gentle reminder on this patch. This patch has other dependencies that >>>> and are pending merge[1][2]. >>> >>> I don't have the permission to merge on u-boot-mmc git. >>> I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :) >>> >>> I had been already reviewed about this patch.. >>> So if want to pick this, I think there is no problem about applied together with below patches. >>> >>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >> >> Tom, >> Is it okay if I pick this patch as per above suggestion? > > Isn't it enough my Acked-by tag? Sure it is :). I just want to make sure Tom doesn't flag it in the PR. Thanks and regards, Lokesh ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-07-20 5:23 ` Lokesh Vutla @ 2021-07-20 5:26 ` Jaehoon Chung 0 siblings, 0 replies; 16+ messages in thread From: Jaehoon Chung @ 2021-07-20 5:26 UTC (permalink / raw) To: Lokesh Vutla, Aswath Govindraju, Peng Fan Cc: u-boot, Praneeth Bajjuri, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas, Tom Rini On 7/20/21 2:23 PM, Lokesh Vutla wrote: > > > On 20/07/21 10:51 am, Jaehoon Chung wrote: >> Hi Lokesh, >> >> On 7/20/21 1:10 PM, Lokesh Vutla wrote: >>> +Tom >>> >>> On 20/07/21 3:45 am, Jaehoon Chung wrote: >>>> Hi Aswath, >>>> >>>> On 7/19/21 3:48 PM, Aswath Govindraju wrote: >>>>> Hi Peng, >>>>> >>>>> On 09/06/21 8:56 pm, Aswath Govindraju wrote: >>>>>> Hi Peng, >>>>>> >>>>>> On 10/05/21 7:18 pm, Aswath Govindraju wrote: >>>>>>> Hi Peng, >>>>>>> >>>>>>> On 07/04/21 3:52 am, Jaehoon Chung wrote: >>>>>>>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: >>>>>>>>> From: Faiz Abbas <faiz_abbas@ti.com> >>>>>>>>> >>>>>>>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. >>>>>>>>> >>>>>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> >>>>>>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> >>>>>>>> >>>>>>>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> >>>>>>>> >>>>>>> >>>>>>> Can you please pick this patch if there are no comments. >>>>>>> >>>>>> >>>>>> May I know if this okay to be merged ? >>>>>> >>>>> >>>>> A gentle reminder on this patch. This patch has other dependencies that >>>>> and are pending merge[1][2]. >>>> >>>> I don't have the permission to merge on u-boot-mmc git. >>>> I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :) >>>> >>>> I had been already reviewed about this patch.. >>>> So if want to pick this, I think there is no problem about applied together with below patches. >>>> >>>> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> >>> >>> Tom, >>> Is it okay if I pick this patch as per above suggestion? >> >> Isn't it enough my Acked-by tag? > > Sure it is :). I just want to make sure Tom doesn't flag it in the PR. Thanks for explanation. :) Best Regards, Jaehoon Chung > > Thanks and regards, > Lokesh > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-07-20 4:10 ` Lokesh Vutla 2021-07-20 5:21 ` Jaehoon Chung @ 2021-07-20 12:16 ` Tom Rini 1 sibling, 0 replies; 16+ messages in thread From: Tom Rini @ 2021-07-20 12:16 UTC (permalink / raw) To: Lokesh Vutla Cc: Jaehoon Chung, Aswath Govindraju, Peng Fan, u-boot, Praneeth Bajjuri, Kishon Vijay Abraham I, Vignesh Raghavendra, Faiz Abbas [-- Attachment #1: Type: text/plain, Size: 1614 bytes --] On Tue, Jul 20, 2021 at 09:40:22AM +0530, Lokesh Vutla wrote: > +Tom > > On 20/07/21 3:45 am, Jaehoon Chung wrote: > > Hi Aswath, > > > > On 7/19/21 3:48 PM, Aswath Govindraju wrote: > >> Hi Peng, > >> > >> On 09/06/21 8:56 pm, Aswath Govindraju wrote: > >>> Hi Peng, > >>> > >>> On 10/05/21 7:18 pm, Aswath Govindraju wrote: > >>>> Hi Peng, > >>>> > >>>> On 07/04/21 3:52 am, Jaehoon Chung wrote: > >>>>> On 4/5/21 11:44 PM, Aswath Govindraju wrote: > >>>>>> From: Faiz Abbas <faiz_abbas@ti.com> > >>>>>> > >>>>>> Enable HS400 speed mode by writing to HOST_CONTROL2 register. > >>>>>> > >>>>>> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com> > >>>>>> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com> > >>>>> > >>>>> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> > >>>>> > >>>> > >>>> Can you please pick this patch if there are no comments. > >>>> > >>> > >>> May I know if this okay to be merged ? > >>> > >> > >> A gentle reminder on this patch. This patch has other dependencies that > >> and are pending merge[1][2]. > > > > I don't have the permission to merge on u-boot-mmc git. > > I have the permission to merge on just u-boot-pmic..But I don't know whether it's the best way to apply this into my u-boot-pmic or not. :) > > > > I had been already reviewed about this patch.. > > So if want to pick this, I think there is no problem about applied together with below patches. > > > > Acked-by: Jaehoon Chung <jh80.chung@samsung.com> > > Tom, > Is it okay if I pick this patch as per above suggestion? Yes that's fine, thanks. -- Tom [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 659 bytes --] ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode 2021-04-05 14:44 ` [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode Aswath Govindraju 2021-04-05 22:18 ` Jaehoon Chung 2021-04-06 22:22 ` Jaehoon Chung @ 2021-07-29 5:14 ` Lokesh Vutla 2 siblings, 0 replies; 16+ messages in thread From: Lokesh Vutla @ 2021-07-29 5:14 UTC (permalink / raw) To: Aswath Govindraju, u-boot; +Cc: Lokesh Vutla On Mon, 5 Apr 2021 20:14:28 +0530, Aswath Govindraju wrote: > Enable HS400 speed mode by writing to HOST_CONTROL2 register. Applied to https://source.denx.de/u-boot/custodians/u-boot-ti.git for-rc, thanks! [1/1] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode https://source.denx.de/u-boot/custodians/u-boot-ti/-/commit/bda47bef7c -- Thanks and Regards, Lokesh ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2021-07-29 5:15 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20210405144459epcas1p3d6df22765afb126a2b2037c5364b0b2e@epcas1p3.samsung.com>
2021-04-05 14:44 ` [PATCH] mmc: sdhci: Write to HOST_CONTROL2 register for HS400 speed mode Aswath Govindraju
2021-04-05 22:18 ` Jaehoon Chung
2021-04-06 5:20 ` Aswath Govindraju
2021-04-06 8:26 ` Aswath Govindraju
2021-04-06 9:14 ` Jaehoon Chung
2021-04-06 22:22 ` Jaehoon Chung
2021-05-10 13:48 ` Aswath Govindraju
2021-06-09 15:26 ` Aswath Govindraju
2021-07-19 6:48 ` Aswath Govindraju
2021-07-19 22:15 ` Jaehoon Chung
2021-07-20 4:10 ` Lokesh Vutla
2021-07-20 5:21 ` Jaehoon Chung
2021-07-20 5:23 ` Lokesh Vutla
2021-07-20 5:26 ` Jaehoon Chung
2021-07-20 12:16 ` Tom Rini
2021-07-29 5:14 ` Lokesh Vutla
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.