From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Alexander Potapenko <glider@google.com>, Marco Elver <elver@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Andrey Konovalov <andreyknvl@google.com> Subject: Re: [PATCH v5 3/6] kasan: Add report for async mode Date: Fri, 22 Jan 2021 13:27:15 +0000 [thread overview] Message-ID: <6ccde9db-98cd-5a56-b93d-0b79f4df56a7@arm.com> (raw) In-Reply-To: <20210122131933.GD8567@gaia> On 1/22/21 1:19 PM, Catalin Marinas wrote: > On Thu, Jan 21, 2021 at 04:39:40PM +0000, Vincenzo Frascino wrote: >> diff --git a/include/linux/kasan.h b/include/linux/kasan.h >> index bb862d1f0e15..b0a1d9dfa85c 100644 >> --- a/include/linux/kasan.h >> +++ b/include/linux/kasan.h >> @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) >> bool kasan_report(unsigned long addr, size_t size, >> bool is_write, unsigned long ip); >> >> +void kasan_report_async(void); >> + >> #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> >> static inline void *kasan_reset_tag(const void *addr) >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 234f35a84f19..2fd6845a95e9 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -358,6 +358,17 @@ void kasan_report_invalid_free(void *object, unsigned long ip) >> end_report(&flags); >> } >> >> +void kasan_report_async(void) >> +{ >> + unsigned long flags; >> + >> + start_report(&flags); >> + pr_err("BUG: KASAN: invalid-access\n"); >> + pr_err("Asynchronous mode enabled: no access details available\n"); >> + dump_stack(); >> + end_report(&flags); >> +} > > I think the kernel test robot complains that with KASAN_SW_TAGS and > HW_TAGS disabled, the kasan_report_async() prototype is no longer > visible but you still have the non-static function definition here. So > either move kasan_report_async() out of this #ifdef or add the #ifdef > around the function definition. > I think adding #ifdef around the function would be the best way in this case, for consistency with the header. > It looks like the original kasan_report() prototype is declared in two > places (second one in mm/kasan/kasan.h). I'd remove the latter and try > to have a consistent approach for kasan_report() and > kasan_report_async(). > Ok, I will remove it. -- Regards, Vincenzo
WARNING: multiple messages have this Message-ID (diff)
From: Vincenzo Frascino <vincenzo.frascino@arm.com> To: Catalin Marinas <catalin.marinas@arm.com> Cc: Branislav Rankov <Branislav.Rankov@arm.com>, Marco Elver <elver@google.com>, Andrey Konovalov <andreyknvl@google.com>, Evgenii Stepanov <eugenis@google.com>, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Alexander Potapenko <glider@google.com>, linux-arm-kernel@lists.infradead.org, Andrey Ryabinin <aryabinin@virtuozzo.com>, Will Deacon <will@kernel.org>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH v5 3/6] kasan: Add report for async mode Date: Fri, 22 Jan 2021 13:27:15 +0000 [thread overview] Message-ID: <6ccde9db-98cd-5a56-b93d-0b79f4df56a7@arm.com> (raw) In-Reply-To: <20210122131933.GD8567@gaia> On 1/22/21 1:19 PM, Catalin Marinas wrote: > On Thu, Jan 21, 2021 at 04:39:40PM +0000, Vincenzo Frascino wrote: >> diff --git a/include/linux/kasan.h b/include/linux/kasan.h >> index bb862d1f0e15..b0a1d9dfa85c 100644 >> --- a/include/linux/kasan.h >> +++ b/include/linux/kasan.h >> @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) >> bool kasan_report(unsigned long addr, size_t size, >> bool is_write, unsigned long ip); >> >> +void kasan_report_async(void); >> + >> #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> >> static inline void *kasan_reset_tag(const void *addr) >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 234f35a84f19..2fd6845a95e9 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -358,6 +358,17 @@ void kasan_report_invalid_free(void *object, unsigned long ip) >> end_report(&flags); >> } >> >> +void kasan_report_async(void) >> +{ >> + unsigned long flags; >> + >> + start_report(&flags); >> + pr_err("BUG: KASAN: invalid-access\n"); >> + pr_err("Asynchronous mode enabled: no access details available\n"); >> + dump_stack(); >> + end_report(&flags); >> +} > > I think the kernel test robot complains that with KASAN_SW_TAGS and > HW_TAGS disabled, the kasan_report_async() prototype is no longer > visible but you still have the non-static function definition here. So > either move kasan_report_async() out of this #ifdef or add the #ifdef > around the function definition. > I think adding #ifdef around the function would be the best way in this case, for consistency with the header. > It looks like the original kasan_report() prototype is declared in two > places (second one in mm/kasan/kasan.h). I'd remove the latter and try > to have a consistent approach for kasan_report() and > kasan_report_async(). > Ok, I will remove it. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-22 13:25 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-21 16:39 [PATCH v5 0/6] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 1/6] arm64: mte: Add asynchronous " Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 2/6] kasan: Add KASAN mode kernel parameter Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:34 ` Andrey Konovalov 2021-01-21 17:34 ` Andrey Konovalov 2021-01-22 11:25 ` Vincenzo Frascino 2021-01-22 11:25 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 3/6] kasan: Add report for async mode Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:36 ` Andrey Konovalov 2021-01-21 17:36 ` Andrey Konovalov 2021-01-22 2:45 ` kernel test robot 2021-01-22 2:45 ` kernel test robot 2021-01-22 2:45 ` kernel test robot 2021-01-22 2:46 ` kernel test robot 2021-01-22 2:46 ` kernel test robot 2021-01-22 2:46 ` kernel test robot 2021-01-22 13:19 ` Catalin Marinas 2021-01-22 13:19 ` Catalin Marinas 2021-01-22 13:27 ` Vincenzo Frascino [this message] 2021-01-22 13:27 ` Vincenzo Frascino 2021-01-22 13:38 ` Vincenzo Frascino 2021-01-22 13:38 ` Vincenzo Frascino 2021-01-21 16:39 ` [PATCH v5 4/6] arm64: mte: Enable async tag check fault Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:38 ` Andrey Konovalov 2021-01-21 17:38 ` Andrey Konovalov 2021-01-22 11:24 ` Vincenzo Frascino 2021-01-22 11:24 ` Vincenzo Frascino 2021-01-22 11:58 ` Catalin Marinas 2021-01-22 11:58 ` Catalin Marinas 2021-01-21 16:39 ` [PATCH v5 5/6] arm64: mte: Expose execution mode Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:41 ` Andrey Konovalov 2021-01-21 17:41 ` Andrey Konovalov 2021-01-21 16:39 ` [PATCH v5 6/6] kasan: Forbid kunit tests when async mode is enabled Vincenzo Frascino 2021-01-21 16:39 ` Vincenzo Frascino 2021-01-21 17:40 ` Andrey Konovalov 2021-01-21 17:40 ` Andrey Konovalov 2021-01-22 11:26 ` Vincenzo Frascino 2021-01-22 11:26 ` Vincenzo Frascino 2021-01-22 12:00 ` Catalin Marinas 2021-01-22 12:00 ` Catalin Marinas 2021-01-22 4:04 ` kernel test robot 2021-01-22 4:04 ` kernel test robot 2021-01-22 4:04 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ccde9db-98cd-5a56-b93d-0b79f4df56a7@arm.com \ --to=vincenzo.frascino@arm.com \ --cc=Branislav.Rankov@arm.com \ --cc=andreyknvl@google.com \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.