* [PATCH] SVM: fix build after "make nested page-fault tracing and logging consistent"
@ 2019-03-12 15:24 Jan Beulich
2019-03-12 15:43 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2019-03-12 15:24 UTC (permalink / raw)
To: xen-devel
Cc: Andrew Cooper, Boris Ostrovsky, Brian Woods, Wei Liu,
Suravee Suthikulpanit
Some compiler versions don't recognize that "mfn" can't really be used
uninitialized in svm_do_nested_pgfault(). To be on the safe side, add an
initializer for p2mt as well.
Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/hvm/svm/svm.c
+++ b/xen/arch/x86/hvm/svm/svm.c
@@ -1762,8 +1762,8 @@ static void svm_do_nested_pgfault(struct
{
int ret;
unsigned long gfn = gpa >> PAGE_SHIFT;
- mfn_t mfn;
- p2m_type_t p2mt;
+ mfn_t mfn = INVALID_MFN;
+ p2m_type_t p2mt = p2m_invalid;
p2m_access_t p2ma;
struct p2m_domain *p2m = NULL;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SVM: fix build after "make nested page-fault tracing and logging consistent"
2019-03-12 15:24 [PATCH] SVM: fix build after "make nested page-fault tracing and logging consistent" Jan Beulich
@ 2019-03-12 15:43 ` Wei Liu
2019-03-12 15:45 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2019-03-12 15:43 UTC (permalink / raw)
To: Jan Beulich
Cc: Wei Liu, Andrew Cooper, Suravee Suthikulpanit, xen-devel,
Boris Ostrovsky, Brian Woods
On Tue, Mar 12, 2019 at 09:24:45AM -0600, Jan Beulich wrote:
> Some compiler versions don't recognize that "mfn" can't really be used
> uninitialized in svm_do_nested_pgfault(). To be on the safe side, add an
> initializer for p2mt as well.
>
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SVM: fix build after "make nested page-fault tracing and logging consistent"
2019-03-12 15:43 ` Wei Liu
@ 2019-03-12 15:45 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2019-03-12 15:45 UTC (permalink / raw)
To: Wei Liu, Jan Beulich
Cc: xen-devel, Brian Woods, Suravee Suthikulpanit, Andrew Cooper
On 3/12/19 11:43 AM, Wei Liu wrote:
> On Tue, Mar 12, 2019 at 09:24:45AM -0600, Jan Beulich wrote:
>> Some compiler versions don't recognize that "mfn" can't really be used
>> uninitialized in svm_do_nested_pgfault(). To be on the safe side, add an
>> initializer for p2mt as well.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-12 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12 15:24 [PATCH] SVM: fix build after "make nested page-fault tracing and logging consistent" Jan Beulich
2019-03-12 15:43 ` Wei Liu
2019-03-12 15:45 ` Boris Ostrovsky
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.