All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop
@ 2022-12-28  9:03 Chenyi Qiang
  2022-12-28 12:07 ` Philippe Mathieu-Daudé
  2022-12-28 13:56 ` David Hildenbrand
  0 siblings, 2 replies; 3+ messages in thread
From: Chenyi Qiang @ 2022-12-28  9:03 UTC (permalink / raw)
  To: David Hildenbrand, Michael S. Tsirkin; +Cc: Chenyi Qiang, qemu-devel

It should be the variable rdl2 to revert the already-notified listeners.

Fixes: 2044969f0b ("virtio-mem: Implement RamDiscardManager interface")
Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
---
 hw/virtio/virtio-mem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
index d96bde1fab..88c9c10318 100644
--- a/hw/virtio/virtio-mem.c
+++ b/hw/virtio/virtio-mem.c
@@ -341,7 +341,7 @@ static int virtio_mem_notify_plug(VirtIOMEM *vmem, uint64_t offset,
     if (ret) {
         /* Notify all already-notified listeners. */
         QLIST_FOREACH(rdl2, &vmem->rdl_list, next) {
-            MemoryRegionSection tmp = *rdl->section;
+            MemoryRegionSection tmp = *rdl2->section;
 
             if (rdl2 == rdl) {
                 break;
-- 
2.17.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop
  2022-12-28  9:03 [PATCH] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop Chenyi Qiang
@ 2022-12-28 12:07 ` Philippe Mathieu-Daudé
  2022-12-28 13:56 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-28 12:07 UTC (permalink / raw)
  To: Chenyi Qiang, David Hildenbrand, Michael S. Tsirkin
  Cc: qemu-devel, qemu-stable

On 28/12/22 10:03, Chenyi Qiang wrote:
> It should be the variable rdl2 to revert the already-notified listeners.
> 
> Fixes: 2044969f0b ("virtio-mem: Implement RamDiscardManager interface")
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> ---
>   hw/virtio/virtio-mem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
> index d96bde1fab..88c9c10318 100644
> --- a/hw/virtio/virtio-mem.c
> +++ b/hw/virtio/virtio-mem.c
> @@ -341,7 +341,7 @@ static int virtio_mem_notify_plug(VirtIOMEM *vmem, uint64_t offset,
>       if (ret) {
>           /* Notify all already-notified listeners. */
>           QLIST_FOREACH(rdl2, &vmem->rdl_list, next) {
> -            MemoryRegionSection tmp = *rdl->section;
> +            MemoryRegionSection tmp = *rdl2->section;
>   
>               if (rdl2 == rdl) {
>                   break;

Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop
  2022-12-28  9:03 [PATCH] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop Chenyi Qiang
  2022-12-28 12:07 ` Philippe Mathieu-Daudé
@ 2022-12-28 13:56 ` David Hildenbrand
  1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2022-12-28 13:56 UTC (permalink / raw)
  To: Chenyi Qiang, Michael S. Tsirkin; +Cc: qemu-devel

On 28.12.22 10:03, Chenyi Qiang wrote:
> It should be the variable rdl2 to revert the already-notified listeners.
> 
> Fixes: 2044969f0b ("virtio-mem: Implement RamDiscardManager interface")
> Signed-off-by: Chenyi Qiang <chenyi.qiang@intel.com>
> ---
>   hw/virtio/virtio-mem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c
> index d96bde1fab..88c9c10318 100644
> --- a/hw/virtio/virtio-mem.c
> +++ b/hw/virtio/virtio-mem.c
> @@ -341,7 +341,7 @@ static int virtio_mem_notify_plug(VirtIOMEM *vmem, uint64_t offset,
>       if (ret) {
>           /* Notify all already-notified listeners. */
>           QLIST_FOREACH(rdl2, &vmem->rdl_list, next) {
> -            MemoryRegionSection tmp = *rdl->section;
> +            MemoryRegionSection tmp = *rdl2->section;
>   
>               if (rdl2 == rdl) {
>                   break;

Indeed, most probably we barely hit that error path in practice. Thanks!

I really have to find a way to simulate a sparse bitmap easily, and to 
inject errors to better test these paths.

https://github.com/davidhildenbrand/qemu.git mem-next

-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-12-28 13:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-28  9:03 [PATCH] virtio-mem: Fix the iterator variable in a vmem->rdl_list loop Chenyi Qiang
2022-12-28 12:07 ` Philippe Mathieu-Daudé
2022-12-28 13:56 ` David Hildenbrand

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.