All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	linux-arm-kernel@lists.infradead.org
Cc: "Russell King" <linux@armlinux.org.uk>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Michael Walle" <michael@walle.cc>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Kavyasree Kotagiri" <kavyasree.kotagiri@microchip.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM
Date: Mon, 30 Jan 2023 09:08:10 +0100	[thread overview]
Message-ID: <6d1f3696-c94a-44ac-996c-83233f694cc0@app.fastmail.com> (raw)
In-Reply-To: <20230129160039.1598347-1-j.neuschaefer@gmx.net>

On Sun, Jan 29, 2023, at 17:00, Jonathan Neuschäfer wrote:
> A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
> that is already the case with DEBUG_LL=y (and documented in its help
> text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
> think users need to be prevented from enabling DEBUG_UNCOMPRESS on
> ARCH_MULTIPLATFORM kernels.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

I think we should instead change the help text for CONFIG_DEBUG_LL.

There is a very significant difference between the requirements
of DEBUG_LL compared to DEBUG_UNCOMPRESS. The former only provides
the platform specific functions but does not call them unless
a user explicitly passes the "earlyprintk" command line argument
or adds explicit function calls to printascii(), while the latter
makes the kernel immediately unbootable.

     Arnd

WARNING: multiple messages have this Message-ID (diff)
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	linux-arm-kernel@lists.infradead.org
Cc: "Russell King" <linux@armlinux.org.uk>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Michael Walle" <michael@walle.cc>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Kavyasree Kotagiri" <kavyasree.kotagiri@microchip.com>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM
Date: Mon, 30 Jan 2023 09:08:10 +0100	[thread overview]
Message-ID: <6d1f3696-c94a-44ac-996c-83233f694cc0@app.fastmail.com> (raw)
In-Reply-To: <20230129160039.1598347-1-j.neuschaefer@gmx.net>

On Sun, Jan 29, 2023, at 17:00, Jonathan Neuschäfer wrote:
> A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
> that is already the case with DEBUG_LL=y (and documented in its help
> text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
> think users need to be prevented from enabling DEBUG_UNCOMPRESS on
> ARCH_MULTIPLATFORM kernels.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

I think we should instead change the help text for CONFIG_DEBUG_LL.

There is a very significant difference between the requirements
of DEBUG_LL compared to DEBUG_UNCOMPRESS. The former only provides
the platform specific functions but does not call them unless
a user explicitly passes the "earlyprintk" command line argument
or adds explicit function calls to printascii(), while the latter
makes the kernel immediately unbootable.

     Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-30  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 16:00 [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM Jonathan Neuschäfer
2023-01-29 16:00 ` Jonathan Neuschäfer
2023-01-30  8:08 ` Arnd Bergmann [this message]
2023-01-30  8:08   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d1f3696-c94a-44ac-996c-83233f694cc0@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=ardb@kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=kavyasree.kotagiri@microchip.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michael@walle.cc \
    --cc=tony@atomide.com \
    --cc=william.zhang@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.