* [PATCH] tzdata: Add tzdata-all package
@ 2019-03-18 16:51 Paul Barker
2019-03-18 17:01 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Paul Barker @ 2019-03-18 16:51 UTC (permalink / raw)
To: openembedded-core
The tzdata-all package provides a simple way of ensuring all timezones
are supported in an image.
Signed-off-by: Paul Barker <paul@betafive.co.uk>
---
meta/recipes-extended/timezone/tzdata.bb | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/meta/recipes-extended/timezone/tzdata.bb b/meta/recipes-extended/timezone/tzdata.bb
index 7542ce52d2..e419296530 100644
--- a/meta/recipes-extended/timezone/tzdata.bb
+++ b/meta/recipes-extended/timezone/tzdata.bb
@@ -82,7 +82,14 @@ pkg_postinst_${PN} () {
PACKAGES = "tzdata tzdata-misc tzdata-posix tzdata-right tzdata-africa \
tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
- tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific"
+ tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific tzdata-all"
+
+ALLOW_EMPTY_tzdata-all = "1"
+RDEPENDS_tzdata-all = " \
+ tzdata tzdata-misc tzdata-posix tzdata-right tzdata-africa \
+ tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
+ tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific \
+ "
FILES_tzdata-africa += "${datadir}/zoneinfo/Africa/*"
RPROVIDES_tzdata-africa = "tzdata-africa"
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tzdata: Add tzdata-all package
2019-03-18 16:51 [PATCH] tzdata: Add tzdata-all package Paul Barker
@ 2019-03-18 17:01 ` Burton, Ross
2019-03-18 17:10 ` Paul Barker
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2019-03-18 17:01 UTC (permalink / raw)
To: Paul Barker; +Cc: OE-core
I'd prefer that installing 'tzdata' installed everything, and then
there were other pieces for subsets. We learnt this the hard way from
people installing "python" and wondering why bits of the standard
library were missing.
Ross
On Mon, 18 Mar 2019 at 17:01, Paul Barker <paul@betafive.co.uk> wrote:
>
> The tzdata-all package provides a simple way of ensuring all timezones
> are supported in an image.
>
> Signed-off-by: Paul Barker <paul@betafive.co.uk>
> ---
> meta/recipes-extended/timezone/tzdata.bb | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/timezone/tzdata.bb b/meta/recipes-extended/timezone/tzdata.bb
> index 7542ce52d2..e419296530 100644
> --- a/meta/recipes-extended/timezone/tzdata.bb
> +++ b/meta/recipes-extended/timezone/tzdata.bb
> @@ -82,7 +82,14 @@ pkg_postinst_${PN} () {
>
> PACKAGES = "tzdata tzdata-misc tzdata-posix tzdata-right tzdata-africa \
> tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
> - tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific"
> + tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific tzdata-all"
> +
> +ALLOW_EMPTY_tzdata-all = "1"
> +RDEPENDS_tzdata-all = " \
> + tzdata tzdata-misc tzdata-posix tzdata-right tzdata-africa \
> + tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
> + tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific \
> + "
>
> FILES_tzdata-africa += "${datadir}/zoneinfo/Africa/*"
> RPROVIDES_tzdata-africa = "tzdata-africa"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tzdata: Add tzdata-all package
2019-03-18 17:01 ` Burton, Ross
@ 2019-03-18 17:10 ` Paul Barker
2019-03-18 21:08 ` Otavio Salvador
2019-03-18 21:30 ` Burton, Ross
0 siblings, 2 replies; 6+ messages in thread
From: Paul Barker @ 2019-03-18 17:10 UTC (permalink / raw)
To: Ross Burton; +Cc: OE Core
On Mon, 18 Mar 2019, at 17:02, Burton, Ross wrote:
> I'd prefer that installing 'tzdata' installed everything, and then
> there were other pieces for subsets. We learnt this the hard way from
> people installing "python" and wondering why bits of the standard
> library were missing.
That is a good argument. I just checked the difference in image sizes though (from buildhistory):
core-image-minimal + tzdata = 8,868 kB
core-image-minimal + tzdata-all = 15,788 kB
So it's probably not an appropriate change for everyone.
>
> Ross
>
> On Mon, 18 Mar 2019 at 17:01, Paul Barker <paul@betafive.co.uk> wrote:
> >
> > The tzdata-all package provides a simple way of ensuring all timezones
> > are supported in an image.
> >
> > Signed-off-by: Paul Barker <paul@betafive.co.uk>
> > ---
> > meta/recipes-extended/timezone/tzdata.bb | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-extended/timezone/tzdata.bb b/meta/recipes-extended/timezone/tzdata.bb
> > index 7542ce52d2..e419296530 100644
> > --- a/meta/recipes-extended/timezone/tzdata.bb
> > +++ b/meta/recipes-extended/timezone/tzdata.bb
> > @@ -82,7 +82,14 @@ pkg_postinst_${PN} () {
> >
> > PACKAGES = "tzdata tzdata-misc tzdata-posix tzdata-right tzdata-africa \
> > tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
> > - tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific"
> > + tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific tzdata-all"
> > +
> > +ALLOW_EMPTY_tzdata-all = "1"
> > +RDEPENDS_tzdata-all = " \
> > + tzdata tzdata-misc tzdata-posix tzdata-right tzdata-africa \
> > + tzdata-americas tzdata-antarctica tzdata-arctic tzdata-asia \
> > + tzdata-atlantic tzdata-australia tzdata-europe tzdata-pacific \
> > + "
> >
> > FILES_tzdata-africa += "${datadir}/zoneinfo/Africa/*"
> > RPROVIDES_tzdata-africa = "tzdata-africa"
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
Paul Barker
Managing Director & Principal Engineer
Beta Five Ltd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tzdata: Add tzdata-all package
2019-03-18 17:10 ` Paul Barker
@ 2019-03-18 21:08 ` Otavio Salvador
2019-03-18 21:30 ` Burton, Ross
1 sibling, 0 replies; 6+ messages in thread
From: Otavio Salvador @ 2019-03-18 21:08 UTC (permalink / raw)
To: Paul Barker; +Cc: OE Core
On Mon, Mar 18, 2019 at 2:10 PM Paul Barker <paul@betafive.co.uk> wrote:
> On Mon, 18 Mar 2019, at 17:02, Burton, Ross wrote:
> > I'd prefer that installing 'tzdata' installed everything, and then
> > there were other pieces for subsets. We learnt this the hard way from
> > people installing "python" and wondering why bits of the standard
> > library were missing.
>
> That is a good argument. I just checked the difference in image sizes though (from buildhistory):
>
> core-image-minimal + tzdata = 8,868 kB
> core-image-minimal + tzdata-all = 15,788 kB
>
> So it's probably not an appropriate change for everyone.
Just, to align with other recipes, name the package tzdata-meta and
use a python function to generate the package runtime dependencies, so
it does not need manual updates.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tzdata: Add tzdata-all package
2019-03-18 17:10 ` Paul Barker
2019-03-18 21:08 ` Otavio Salvador
@ 2019-03-18 21:30 ` Burton, Ross
2019-03-18 22:03 ` Paul Barker
1 sibling, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2019-03-18 21:30 UTC (permalink / raw)
To: Paul Barker; +Cc: OE Core
On Mon, 18 Mar 2019 at 17:10, Paul Barker <paul@betafive.co.uk> wrote:
> That is a good argument. I just checked the difference in image sizes though (from buildhistory):
>
> core-image-minimal + tzdata = 8,868 kB
> core-image-minimal + tzdata-all = 15,788 kB
>
> So it's probably not an appropriate change for everyone.
Agreed, and I didn't suggest that we switch to installing all of the
tzdata by default for that reason.
Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tzdata: Add tzdata-all package
2019-03-18 21:30 ` Burton, Ross
@ 2019-03-18 22:03 ` Paul Barker
0 siblings, 0 replies; 6+ messages in thread
From: Paul Barker @ 2019-03-18 22:03 UTC (permalink / raw)
To: Ross Burton, Otavio Salvador; +Cc: OE Core
On Mon, 18 Mar 2019, at 21:30, Burton, Ross wrote:
> On Mon, 18 Mar 2019 at 17:10, Paul Barker <paul@betafive.co.uk> wrote:
> > That is a good argument. I just checked the difference in image sizes though (from buildhistory):
> >
> > core-image-minimal + tzdata = 8,868 kB
> > core-image-minimal + tzdata-all = 15,788 kB
> >
> > So it's probably not an appropriate change for everyone.
>
> Agreed, and I didn't suggest that we switch to installing all of the
> tzdata by default for that reason.
>
My concern is for recipes defined outside oe-core that pull in "tzdata". Do we just mention this in the release notes and leave people to manually update their dependencies if they require a minimal image size?
If we go this route we should define a new "tzdata-minimal" package which contains what's currently in "tzdata".
I also think Otavio has the right idea on calculating the dependency list dynamically so we don't have to update it for any future change to PACKAGES in this recipe.
--
Paul Barker
Managing Director & Principal Engineer
Beta Five Ltd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-18 22:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-18 16:51 [PATCH] tzdata: Add tzdata-all package Paul Barker
2019-03-18 17:01 ` Burton, Ross
2019-03-18 17:10 ` Paul Barker
2019-03-18 21:08 ` Otavio Salvador
2019-03-18 21:30 ` Burton, Ross
2019-03-18 22:03 ` Paul Barker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.