From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>, Jan Beulich <JBeulich@suse.com>
Cc: bhavesh.davda@oracle.com,
Eric DeVolder <eric.devolder@oracle.com>,
Julien Grall <julien.grall@arm.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 1/2] kexec: use hypercall_create_continuation to protect KEXEC ops
Date: Wed, 19 Apr 2017 12:48:56 +0100 [thread overview]
Message-ID: <6da888c4-dfd2-a5b9-525e-e09d2fd31371@citrix.com> (raw)
In-Reply-To: <20170419110044.GD16658@olila.local.net-space.pl>
On 19/04/17 12:00, Daniel Kiper wrote:
> On Tue, Apr 18, 2017 at 04:48:06AM -0600, Jan Beulich wrote:
>>>>> On 17.04.17 at 21:09, <eric.devolder@oracle.com> wrote:
>>> --- a/xen/common/kexec.c
>>> +++ b/xen/common/kexec.c
>>> @@ -50,9 +50,10 @@ static cpumask_t crash_saved_cpus;
>>>
>>> static struct kexec_image *kexec_image[KEXEC_IMAGE_NR];
>>>
>>> -#define KEXEC_FLAG_DEFAULT_POS (KEXEC_IMAGE_NR + 0)
>>> -#define KEXEC_FLAG_CRASH_POS (KEXEC_IMAGE_NR + 1)
>>> -#define KEXEC_FLAG_IN_PROGRESS (KEXEC_IMAGE_NR + 2)
>>> +#define KEXEC_FLAG_DEFAULT_POS (KEXEC_IMAGE_NR + 0)
>>> +#define KEXEC_FLAG_CRASH_POS (KEXEC_IMAGE_NR + 1)
>>> +#define KEXEC_FLAG_IN_PROGRESS (KEXEC_IMAGE_NR + 2)
>>> +#define KEXEC_FLAG_HC_IN_PROGRESS (KEXEC_IMAGE_NR + 3)
>> Perhaps KEXEC_FLAG_IN_HYPERCALL? Other than that (and this
> Make sense for me.
Agreed. (I can fix on commit).
>
>> clearly is subject to Andrew's opinion)
>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC'ing Julien. This is clearly a good bugfix for 4.9
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-19 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-17 19:09 [PATCH v2 0/2] kexec: Use hypercall_create_continuation to protect KEXEC ops Eric DeVolder
2017-04-17 19:09 ` [PATCH v2 1/2] kexec: use " Eric DeVolder
2017-04-18 10:48 ` Jan Beulich
2017-04-19 11:00 ` Daniel Kiper
2017-04-19 11:48 ` Andrew Cooper [this message]
2017-04-19 12:16 ` Daniel Kiper
2017-04-19 15:48 ` Eric DeVolder
2017-04-17 19:09 ` [PATCH v2 2/2] kexec: remove spinlock now that all KEXEC hypercall ops are protected at the top-level Eric DeVolder
2017-04-18 10:49 ` Jan Beulich
2017-04-19 10:56 ` Daniel Kiper
2017-04-19 11:20 ` Jan Beulich
2017-04-19 11:52 ` Andrew Cooper
2017-04-19 12:13 ` Daniel Kiper
2017-04-19 13:37 ` Jan Beulich
2017-04-19 15:49 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6da888c4-dfd2-a5b9-525e-e09d2fd31371@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=bhavesh.davda@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=eric.devolder@oracle.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.