All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Baodong Chen <chenbaodong@mxnavi.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] xen: notifier: refine 'notifier_head', use 'list_head' directly
Date: Fri, 31 May 2019 11:22:13 +0100	[thread overview]
Message-ID: <6db51cab-7372-d55d-c0a5-481afc21e5c8@arm.com> (raw)
In-Reply-To: <1559270128-28496-1-git-send-email-chenbaodong@mxnavi.com>

Hi,

Missing commit message here.

On 5/31/19 3:35 AM, Baodong Chen wrote:
> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> ---
>   xen/common/notifier.c      | 25 ++++++-------------------
>   xen/include/xen/notifier.h | 21 +++++++++++++++------
>   2 files changed, 21 insertions(+), 25 deletions(-)
> 
> diff --git a/xen/common/notifier.c b/xen/common/notifier.c
> index 34488a8..f959a79 100644
> --- a/xen/common/notifier.c
> +++ b/xen/common/notifier.c
> @@ -21,10 +21,10 @@
>   void __init notifier_chain_register(
>       struct notifier_head *nh, struct notifier_block *n)
>   {
> -    struct list_head *chain = &nh->head.chain;
> +    struct list_head *chain = &nh->head;
>       struct notifier_block *nb;
>   
> -    while ( chain->next != &nh->head.chain )
> +    while ( chain->next != &nh->head )
>       {
>           nb = list_entry(chain->next, struct notifier_block, chain);
>           if ( n->priority > nb->priority )
> @@ -35,19 +35,6 @@ void __init notifier_chain_register(
>       list_add(&n->chain, chain);
>   }
>   
> -/**
> - * notifier_chain_unregister - Remove notifier from a raw notifier chain
> - * @nh: Pointer to head of the raw notifier chain
> - * @n: Entry to remove from notifier chain
> - *
> - * Removes a notifier from a raw notifier chain.
> - * All locking must be provided by the caller.
> - */
> -void __init notifier_chain_unregister(
> -    struct notifier_head *nh, struct notifier_block *n)
> -{
> -    list_del(&n->chain);
> -}

Why did you move the function?

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Baodong Chen <chenbaodong@mxnavi.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH] xen: notifier: refine 'notifier_head', use 'list_head' directly
Date: Fri, 31 May 2019 11:22:13 +0100	[thread overview]
Message-ID: <6db51cab-7372-d55d-c0a5-481afc21e5c8@arm.com> (raw)
Message-ID: <20190531102213.wIxaucvqYe9ya_EpaziXWfsdPFB9llbznOWOrZakpH8@z> (raw)
In-Reply-To: <1559270128-28496-1-git-send-email-chenbaodong@mxnavi.com>

Hi,

Missing commit message here.

On 5/31/19 3:35 AM, Baodong Chen wrote:
> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com>
> ---
>   xen/common/notifier.c      | 25 ++++++-------------------
>   xen/include/xen/notifier.h | 21 +++++++++++++++------
>   2 files changed, 21 insertions(+), 25 deletions(-)
> 
> diff --git a/xen/common/notifier.c b/xen/common/notifier.c
> index 34488a8..f959a79 100644
> --- a/xen/common/notifier.c
> +++ b/xen/common/notifier.c
> @@ -21,10 +21,10 @@
>   void __init notifier_chain_register(
>       struct notifier_head *nh, struct notifier_block *n)
>   {
> -    struct list_head *chain = &nh->head.chain;
> +    struct list_head *chain = &nh->head;
>       struct notifier_block *nb;
>   
> -    while ( chain->next != &nh->head.chain )
> +    while ( chain->next != &nh->head )
>       {
>           nb = list_entry(chain->next, struct notifier_block, chain);
>           if ( n->priority > nb->priority )
> @@ -35,19 +35,6 @@ void __init notifier_chain_register(
>       list_add(&n->chain, chain);
>   }
>   
> -/**
> - * notifier_chain_unregister - Remove notifier from a raw notifier chain
> - * @nh: Pointer to head of the raw notifier chain
> - * @n: Entry to remove from notifier chain
> - *
> - * Removes a notifier from a raw notifier chain.
> - * All locking must be provided by the caller.
> - */
> -void __init notifier_chain_unregister(
> -    struct notifier_head *nh, struct notifier_block *n)
> -{
> -    list_del(&n->chain);
> -}

Why did you move the function?

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-05-31 10:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31  2:35 [PATCH] xen: notifier: refine 'notifier_head', use 'list_head' directly Baodong Chen
2019-05-31  2:35 ` [Xen-devel] " Baodong Chen
2019-05-31 10:22 ` Julien Grall [this message]
2019-05-31 10:22   ` Julien Grall
2019-06-03  1:25   ` chenbaodong
2019-06-03  1:25     ` [Xen-devel] " chenbaodong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6db51cab-7372-d55d-c0a5-481afc21e5c8@arm.com \
    --to=julien.grall@arm.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chenbaodong@mxnavi.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.