From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com> Cc: davem@davemloft.net, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org, Jorgen Hansen <jhansen@vmware.com>, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-hyperv@vger.kernel.org, Dexuan Cui <decui@microsoft.com>, netdev@vger.kernel.org Subject: Re: [PATCH net-next 0/3] vsock: support network namespace Date: Wed, 29 Apr 2020 17:21:42 +0800 [thread overview] Message-ID: <6dc937e4-0ef9-617d-c9c8-8b1f8c428d90@redhat.com> (raw) In-Reply-To: <20200428160052.o3ihui4262xogyg4@steredhat> On 2020/4/29 上午12:00, Stefano Garzarella wrote: > On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote: >> On 2020/4/27 下午10:25, Stefano Garzarella wrote: >>> Hi David, Michael, Stefan, >>> I'm restarting to work on this topic since Kata guys are interested to >>> have that, especially on the guest side. >>> >>> While working on the v2 I had few doubts, and I'd like to have your >>> suggestions: >>> >>> 1. netns assigned to the device inside the guest >>> >>> Currently I assigned this device to 'init_net'. Maybe it is better >>> if we allow the user to decide which netns assign to the device >>> or to disable this new feature to have the same behavior as before >>> (host reachable from any netns). >>> I think we can handle this in the vsock core and not in the single >>> transports. >>> >>> The simplest way that I found, is to add a new >>> IOCTL_VM_SOCKETS_ASSIGN_G2H_NETNS to /dev/vsock to enable the feature >>> and assign the device to the same netns of the process that do the >>> ioctl(), but I'm not sure it is clean enough. >>> >>> Maybe it is better to add new rtnetlink messages, but I'm not sure if >>> it is feasible since we don't have a netdev device. >>> >>> What do you suggest? >> As we've discussed, it should be a netdev probably in either guest or host >> side. And it would be much simpler if we want do implement namespace then. >> No new API is needed. >> > Thanks Jason! > > It would be cool, but I don't have much experience on netdev. > Do you see any particular obstacles? I don't see but if there's we can try to find a solution or ask for netdev experts for that. I do hear from somebody that is interested in having netdev in the past. > > I'll take a look to understand how to do it, surely in the guest would > be very useful to have the vsock device as a netdev and maybe also in the host. Yes, it's worth to have a try then we will have a unified management interface and we will benefit from it in the future. Starting form guest is good idea which should be less complicated than host. Thanks > > Stefano >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Stefano Garzarella <sgarzare@redhat.com> Cc: linux-hyperv@vger.kernel.org, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, Dexuan Cui <decui@microsoft.com>, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Stefan Hajnoczi <stefanha@redhat.com>, davem@davemloft.net, Jorgen Hansen <jhansen@vmware.com> Subject: Re: [PATCH net-next 0/3] vsock: support network namespace Date: Wed, 29 Apr 2020 17:21:42 +0800 [thread overview] Message-ID: <6dc937e4-0ef9-617d-c9c8-8b1f8c428d90@redhat.com> (raw) In-Reply-To: <20200428160052.o3ihui4262xogyg4@steredhat> On 2020/4/29 上午12:00, Stefano Garzarella wrote: > On Tue, Apr 28, 2020 at 04:13:22PM +0800, Jason Wang wrote: >> On 2020/4/27 下午10:25, Stefano Garzarella wrote: >>> Hi David, Michael, Stefan, >>> I'm restarting to work on this topic since Kata guys are interested to >>> have that, especially on the guest side. >>> >>> While working on the v2 I had few doubts, and I'd like to have your >>> suggestions: >>> >>> 1. netns assigned to the device inside the guest >>> >>> Currently I assigned this device to 'init_net'. Maybe it is better >>> if we allow the user to decide which netns assign to the device >>> or to disable this new feature to have the same behavior as before >>> (host reachable from any netns). >>> I think we can handle this in the vsock core and not in the single >>> transports. >>> >>> The simplest way that I found, is to add a new >>> IOCTL_VM_SOCKETS_ASSIGN_G2H_NETNS to /dev/vsock to enable the feature >>> and assign the device to the same netns of the process that do the >>> ioctl(), but I'm not sure it is clean enough. >>> >>> Maybe it is better to add new rtnetlink messages, but I'm not sure if >>> it is feasible since we don't have a netdev device. >>> >>> What do you suggest? >> As we've discussed, it should be a netdev probably in either guest or host >> side. And it would be much simpler if we want do implement namespace then. >> No new API is needed. >> > Thanks Jason! > > It would be cool, but I don't have much experience on netdev. > Do you see any particular obstacles? I don't see but if there's we can try to find a solution or ask for netdev experts for that. I do hear from somebody that is interested in having netdev in the past. > > I'll take a look to understand how to do it, surely in the guest would > be very useful to have the vsock device as a netdev and maybe also in the host. Yes, it's worth to have a try then we will have a unified management interface and we will benefit from it in the future. Starting form guest is good idea which should be less complicated than host. Thanks > > Stefano > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-04-29 9:22 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-16 17:24 [PATCH net-next 0/3] vsock: support network namespace Stefano Garzarella 2020-01-16 17:24 ` Stefano Garzarella 2020-01-16 17:24 ` [PATCH net-next 1/3] vsock: add network namespace support Stefano Garzarella 2020-01-16 17:24 ` Stefano Garzarella 2020-01-20 9:06 ` David Miller 2020-01-20 10:17 ` Stefano Garzarella 2020-01-20 12:03 ` Michael S. Tsirkin 2020-01-20 13:58 ` Stefano Garzarella 2020-01-20 16:04 ` Michael S. Tsirkin 2020-01-20 16:53 ` Stefano Garzarella 2020-01-20 22:02 ` Michael S. Tsirkin 2020-01-21 9:07 ` Stefano Garzarella 2020-01-21 11:14 ` Michael S. Tsirkin 2020-01-21 13:13 ` Stefano Garzarella 2020-01-21 15:43 ` Stefan Hajnoczi 2020-01-21 13:59 ` Stefan Hajnoczi 2020-01-21 14:31 ` Michael S. Tsirkin 2020-01-21 15:44 ` Stefan Hajnoczi 2020-01-16 17:24 ` [PATCH net-next 2/3] vsock/virtio_transport_common: handle netns of received packets Stefano Garzarella 2020-01-16 17:24 ` Stefano Garzarella 2020-01-16 17:24 ` [PATCH net-next 3/3] vhost/vsock: use netns of process that opens the vhost-vsock device Stefano Garzarella 2020-01-16 17:24 ` Stefano Garzarella 2020-01-21 15:50 ` [PATCH net-next 0/3] vsock: support network namespace Stefan Hajnoczi 2020-01-22 9:13 ` Stefano Garzarella 2020-04-27 14:25 ` Stefano Garzarella 2020-04-27 14:31 ` Michael S. Tsirkin 2020-04-27 15:21 ` Stefano Garzarella 2020-04-28 8:13 ` Jason Wang 2020-04-28 16:00 ` Stefano Garzarella 2020-04-29 9:21 ` Jason Wang [this message] 2020-04-29 9:21 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6dc937e4-0ef9-617d-c9c8-8b1f8c428d90@redhat.com \ --to=jasowang@redhat.com \ --cc=davem@davemloft.net \ --cc=decui@microsoft.com \ --cc=jhansen@vmware.com \ --cc=kvm@vger.kernel.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=sgarzare@redhat.com \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.