From: Krzysztof Kozlowski <krzk@kernel.org> To: wangseok.lee@samsung.com, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzk+dt@kernel.org" <krzk+dt@kernel.org>, "kishon@ti.com" <kishon@ti.com>, "vkoul@kernel.org" <vkoul@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "jesper.nilsson@axis.com" <jesper.nilsson@axis.com>, "lars.persson@axis.com" <lars.persson@axis.com> Cc: "bhelgaas@google.com" <bhelgaas@google.com>, "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "kw@linux.com" <kw@linux.com>, "linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>, "kernel@axis.com" <kernel@axis.com>, 전문기 <moonki.jun@samsung.com> Subject: Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver Date: Tue, 29 Mar 2022 08:41:59 +0200 [thread overview] Message-ID: <6dec8b28-5e6e-b53b-6351-aaa797d9078d@kernel.org> (raw) In-Reply-To: <20220329034949epcms2p1717d820646c878f314b03e07c2d092ba@epcms2p1> On 29/03/2022 05:49, 이왕석 wrote: >> --------- Original Message --------- >> Sender : Krzysztof Kozlowski <krzk@kernel.org> >> Date : 2022-03-28 20:44 (GMT+9) >> Title : Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver >> >> On 28/03/2022 13:29, 이왕석 wrote: >>>> --------- Original Message --------- >>>> Sender : Krzysztof Kozlowski <krzk@kernel.org> >>>> Date : 2022-03-28 18:38 (GMT+9) >>>> Title : Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver >>>> >>>> On 28/03/2022 11:02, 이왕석 wrote: >>>>>> --------- Original Message --------- >>>>>> Sender : Krzysztof Kozlowski <krzk@kernel.org> >>>>>> Date : 2022-03-28 16:12 (GMT+9) >>>>>> Title : Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver >>>>>> >>>>>> On 28/03/2022 03:44, 이왕석 wrote: >>>>>>> This series patches include newly PCIe support for Axis ARTPEC-8 SoC. >>>>>>> ARTPEC-8 is the SoC platform of Axis Communications. >>>>>>> PCIe controller driver and phy driver have been newly added. >>>>>>> There is also a new MAINTAINER in the addition of phy driver. >>>>>>> PCIe controller is designed based on Design-Ware PCIe controller IP >>>>>>> and PCIe phy is desinged based on SAMSUNG PHY IP. >>>>>>> It also includes modifications to the Design-Ware controller driver to >>>>>>> run the 64bit-based ARTPEC-8 PCIe controller driver. >>>>>>> It consists of 6 patches in total. >>>>>>> >>>>>>> This series has been tested on AXIS SW bring-up board >>>>>>> with ARTPEC-8 chipset. >>>>>> >>>>>> You lost mail threading. This makes reading this difficult for us. Plus >>>>>> you sent something non-applicable (patch #2), so please resend. >>>>>> >>>>>> Knowing recent Samsung reluctance to extend existing drivers and always >>>>>> duplicate, please provide description/analysis why this driver cannot be >>>>>> combined with existing driver. The answer like: we need several syscon >>>>>> because we do not implement other frameworks (like interconnect) are not >>>>>> valid. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>> >>>>> Hello, Krzysztof >>>>> Thanks for your review. >>>>> >>>>> patch#2 was sent to the wrong format so sent again. >>>>> Sorry for causing confusion. >>>> >>>> The first sending was HTML. Second was broken text, so still not working. >>>> >>>> Please resend everything with proper threading. >>> >>> Hello, Krzysztof >>> >>> I sent patch#2 three times. >>> due to the influence of the email system, >>> there was something wrong with the first and second mails. >>> Sorry for causing confusion. >>> Did you receive the third patch i sent you? >> >> Maybe, I don't know. It's not threaded so it's difficult to find it >> among other 100 emails... > > I think you also received a normal patch# 2. > >>> >>>>> This patch is specialized in Artpec-8, >>>>> the SoC Platform of Axis Communication, and is newly applied. >>>>> Since the target SoC platform is different from the driver previously >>>>> used by Samsung, it is difficult to merge with the existing driver. >>>> >>>> Recently I always saw such answers and sometimes it was true, sometimes >>>> not. What is exactly different? >>>> >>>> Best regards, >>>> Krzysztof >>> >>> The main reason this patch should be added is that >>> this patch is not the driver applied to exynos platform. >> >> Still this does not explain why you need separate driver. > > PCIe driver of artpec-8 is not available in exynos platform. > because the PCIe of artpec and exynos have very different > hardware in SoC design. > Not only it is the SoC different, > but the hardware design of PCIe is also different. > Therefore, we are using driver's compatible > as axis, artpec8-pcie rather than samsung, artpec8-pcie. You keep repeating the same over and over. What is different? Drivers can support different devices, I already wrote it. Just because device is different does not mean it should have separate driver. > >>> Because the SoC platform is different, >>> the IP configuration of PCIe is also different. >> >> What is exactly different? Usually drivers can support IP blocks with >> some differences... >> >>> We will organize a driver for Artpec-8 platform and >>> if there is no special reason, maintain this >>> without adding it from the next series. >> >> I don't understand this. >> >> >> Best regards, >> Krzysztof > > Also, as you know, > exynos driver is designed according to exynos SoC platform, > so both function and variable names start with exynos. That's hardly a problem... > Compared to the existing exynos driver, > you can see that the structure and type of function are different. No, I cannot see it. You coded the driver that way, you can code it in other way. > For this reason, it is difficult to use the existing exynos driver > for artpec. Naming of functions and structures is not making it difficult. That's not the reason. > Our idea is to register a new PCIe driver for artpec-8 SoC platform > and maintain it in the future. We also want to maintain Exynos PCIe driver in the future. Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org> To: wangseok.lee@samsung.com, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzk+dt@kernel.org" <krzk+dt@kernel.org>, "kishon@ti.com" <kishon@ti.com>, "vkoul@kernel.org" <vkoul@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "jesper.nilsson@axis.com" <jesper.nilsson@axis.com>, "lars.persson@axis.com" <lars.persson@axis.com> Cc: "bhelgaas@google.com" <bhelgaas@google.com>, "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>, "kw@linux.com" <kw@linux.com>, "linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>, "kernel@axis.com" <kernel@axis.com>, 전문기 <moonki.jun@samsung.com> Subject: Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver Date: Tue, 29 Mar 2022 08:41:59 +0200 [thread overview] Message-ID: <6dec8b28-5e6e-b53b-6351-aaa797d9078d@kernel.org> (raw) In-Reply-To: <20220329034949epcms2p1717d820646c878f314b03e07c2d092ba@epcms2p1> On 29/03/2022 05:49, 이왕석 wrote: >> --------- Original Message --------- >> Sender : Krzysztof Kozlowski <krzk@kernel.org> >> Date : 2022-03-28 20:44 (GMT+9) >> Title : Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver >> >> On 28/03/2022 13:29, 이왕석 wrote: >>>> --------- Original Message --------- >>>> Sender : Krzysztof Kozlowski <krzk@kernel.org> >>>> Date : 2022-03-28 18:38 (GMT+9) >>>> Title : Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver >>>> >>>> On 28/03/2022 11:02, 이왕석 wrote: >>>>>> --------- Original Message --------- >>>>>> Sender : Krzysztof Kozlowski <krzk@kernel.org> >>>>>> Date : 2022-03-28 16:12 (GMT+9) >>>>>> Title : Re: [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver >>>>>> >>>>>> On 28/03/2022 03:44, 이왕석 wrote: >>>>>>> This series patches include newly PCIe support for Axis ARTPEC-8 SoC. >>>>>>> ARTPEC-8 is the SoC platform of Axis Communications. >>>>>>> PCIe controller driver and phy driver have been newly added. >>>>>>> There is also a new MAINTAINER in the addition of phy driver. >>>>>>> PCIe controller is designed based on Design-Ware PCIe controller IP >>>>>>> and PCIe phy is desinged based on SAMSUNG PHY IP. >>>>>>> It also includes modifications to the Design-Ware controller driver to >>>>>>> run the 64bit-based ARTPEC-8 PCIe controller driver. >>>>>>> It consists of 6 patches in total. >>>>>>> >>>>>>> This series has been tested on AXIS SW bring-up board >>>>>>> with ARTPEC-8 chipset. >>>>>> >>>>>> You lost mail threading. This makes reading this difficult for us. Plus >>>>>> you sent something non-applicable (patch #2), so please resend. >>>>>> >>>>>> Knowing recent Samsung reluctance to extend existing drivers and always >>>>>> duplicate, please provide description/analysis why this driver cannot be >>>>>> combined with existing driver. The answer like: we need several syscon >>>>>> because we do not implement other frameworks (like interconnect) are not >>>>>> valid. >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>> >>>>> Hello, Krzysztof >>>>> Thanks for your review. >>>>> >>>>> patch#2 was sent to the wrong format so sent again. >>>>> Sorry for causing confusion. >>>> >>>> The first sending was HTML. Second was broken text, so still not working. >>>> >>>> Please resend everything with proper threading. >>> >>> Hello, Krzysztof >>> >>> I sent patch#2 three times. >>> due to the influence of the email system, >>> there was something wrong with the first and second mails. >>> Sorry for causing confusion. >>> Did you receive the third patch i sent you? >> >> Maybe, I don't know. It's not threaded so it's difficult to find it >> among other 100 emails... > > I think you also received a normal patch# 2. > >>> >>>>> This patch is specialized in Artpec-8, >>>>> the SoC Platform of Axis Communication, and is newly applied. >>>>> Since the target SoC platform is different from the driver previously >>>>> used by Samsung, it is difficult to merge with the existing driver. >>>> >>>> Recently I always saw such answers and sometimes it was true, sometimes >>>> not. What is exactly different? >>>> >>>> Best regards, >>>> Krzysztof >>> >>> The main reason this patch should be added is that >>> this patch is not the driver applied to exynos platform. >> >> Still this does not explain why you need separate driver. > > PCIe driver of artpec-8 is not available in exynos platform. > because the PCIe of artpec and exynos have very different > hardware in SoC design. > Not only it is the SoC different, > but the hardware design of PCIe is also different. > Therefore, we are using driver's compatible > as axis, artpec8-pcie rather than samsung, artpec8-pcie. You keep repeating the same over and over. What is different? Drivers can support different devices, I already wrote it. Just because device is different does not mean it should have separate driver. > >>> Because the SoC platform is different, >>> the IP configuration of PCIe is also different. >> >> What is exactly different? Usually drivers can support IP blocks with >> some differences... >> >>> We will organize a driver for Artpec-8 platform and >>> if there is no special reason, maintain this >>> without adding it from the next series. >> >> I don't understand this. >> >> >> Best regards, >> Krzysztof > > Also, as you know, > exynos driver is designed according to exynos SoC platform, > so both function and variable names start with exynos. That's hardly a problem... > Compared to the existing exynos driver, > you can see that the structure and type of function are different. No, I cannot see it. You coded the driver that way, you can code it in other way. > For this reason, it is difficult to use the existing exynos driver > for artpec. Naming of functions and structures is not making it difficult. That's not the reason. > Our idea is to register a new PCIe driver for artpec-8 SoC platform > and maintain it in the future. We also want to maintain Exynos PCIe driver in the future. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-03-29 6:42 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CGME20220328014430epcms2p7063834feb0abdf2f38a62723c96c9ff1@epcms2p7> 2022-03-28 1:44 ` [PATCH 0/5] Add support for Axis, ARTPEC-8 PCIe driver 이왕석 2022-03-28 1:44 ` 이왕석 2022-03-28 7:11 ` Krzysztof Kozlowski 2022-03-28 7:11 ` Krzysztof Kozlowski [not found] ` <CGME20220328014430epcms2p7063834feb0abdf2f38a62723c96c9ff1@epcms2p8> 2022-03-28 9:02 ` 이왕석 2022-03-28 9:02 ` 이왕석 2022-03-28 9:38 ` Krzysztof Kozlowski 2022-03-28 9:38 ` Krzysztof Kozlowski [not found] ` <CGME20220328014430epcms2p7063834feb0abdf2f38a62723c96c9ff1@epcms2p4> 2022-03-28 11:29 ` 이왕석 2022-03-28 11:29 ` 이왕석 2022-03-28 11:40 ` Krzysztof Kozlowski 2022-03-28 11:40 ` Krzysztof Kozlowski 2022-04-13 6:45 ` Vinod Koul 2022-04-13 6:45 ` Vinod Koul [not found] ` <CGME20220328014430epcms2p7063834feb0abdf2f38a62723c96c9ff1@epcms2p1> 2022-03-29 3:49 ` 이왕석 2022-03-29 3:49 ` 이왕석 2022-03-29 6:41 ` Krzysztof Kozlowski [this message] 2022-03-29 6:41 ` Krzysztof Kozlowski [not found] <CGME20220418072049epcms2p463a9f01d8ae3e29f75b746a0dce934f1@epcms2p4> 2022-04-18 7:20 ` Wangseok Lee 2022-04-18 7:20 ` Wangseok Lee 2022-04-18 16:52 ` Krzysztof Kozlowski 2022-04-18 16:52 ` Krzysztof Kozlowski [not found] ` <CGME20220418072049epcms2p463a9f01d8ae3e29f75b746a0dce934f1@epcms2p1> 2022-04-21 23:57 ` Wangseok Lee 2022-04-21 23:57 ` Wangseok Lee 2022-05-02 10:14 ` Vinod Koul 2022-05-02 10:14 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6dec8b28-5e6e-b53b-6351-aaa797d9078d@kernel.org \ --to=krzk@kernel.org \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=jesper.nilsson@axis.com \ --cc=kernel@axis.com \ --cc=kishon@ti.com \ --cc=krzk+dt@kernel.org \ --cc=kw@linux.com \ --cc=lars.persson@axis.com \ --cc=linux-arm-kernel@axis.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=moonki.jun@samsung.com \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ --cc=wangseok.lee@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.