* [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2019-07-16 13:10 ` Bogdan Togorean
0 siblings, 0 replies; 24+ messages in thread
From: Bogdan Togorean @ 2019-07-16 13:10 UTC (permalink / raw)
To: a.hajda
Cc: Laurent.pinchart, airlied, daniel, sam, swinslow,
benjamin.gaignard, bogdan.togorean, tglx, matt.redfearn,
dri-devel, linux-kernel
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 9c8af882bf12: ("drm: Add adv7511 encoder driver")
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f6d2681f6927..4508a304d23f 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -756,8 +756,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.22.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2019-07-16 13:10 ` Bogdan Togorean
0 siblings, 0 replies; 24+ messages in thread
From: Bogdan Togorean @ 2019-07-16 13:10 UTC (permalink / raw)
To: a.hajda
Cc: Laurent.pinchart, airlied, daniel, sam, swinslow,
benjamin.gaignard, bogdan.togorean, tglx, matt.redfearn,
dri-devel, linux-kernel
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 9c8af882bf12: ("drm: Add adv7511 encoder driver")
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f6d2681f6927..4508a304d23f 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -756,8 +756,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.22.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
2019-07-16 13:10 ` Bogdan Togorean
@ 2023-07-18 6:28 ` Alexandru Ardelean
-1 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 6:28 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: architt, bogdan.togorean, nuno.sa, daniel, airlied, jonas,
Laurent.pinchart, rfoss, neil.armstrong, andrzej.hajda, festevam
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
* added Fixes: tag
* added Reviewed-by: tag for Nuno
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..09290a377957 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.41.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 6:28 ` Alexandru Ardelean
0 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 6:28 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: neil.armstrong, architt, rfoss, andrzej.hajda, jonas, nuno.sa,
bogdan.togorean, Laurent.pinchart
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
* added Fixes: tag
* added Reviewed-by: tag for Nuno
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..09290a377957 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.41.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-18 6:28 ` Alexandru Ardelean
@ 2023-07-18 7:03 ` Nuno Sá
-1 siblings, 0 replies; 24+ messages in thread
From: Nuno Sá @ 2023-07-18 7:03 UTC (permalink / raw)
To: Alexandru Ardelean, linux-kernel, dri-devel
Cc: architt, bogdan.togorean, nuno.sa, daniel, airlied, jonas,
Laurent.pinchart, rfoss, neil.armstrong, andrzej.hajda, festevam
On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote:
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> ---
>
It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :)
- Nuno Sá
> Changelog v1 -> v2:
> *
> https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> * added Fixes: tag
> * added Reviewed-by: tag for Nuno
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index ddceafa7b637..09290a377957 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 7:03 ` Nuno Sá
0 siblings, 0 replies; 24+ messages in thread
From: Nuno Sá @ 2023-07-18 7:03 UTC (permalink / raw)
To: Alexandru Ardelean, linux-kernel, dri-devel
Cc: neil.armstrong, architt, rfoss, andrzej.hajda, jonas, nuno.sa,
bogdan.togorean, Laurent.pinchart
On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote:
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> ---
>
It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :)
- Nuno Sá
> Changelog v1 -> v2:
> *
> https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> * added Fixes: tag
> * added Reviewed-by: tag for Nuno
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index ddceafa7b637..09290a377957 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-18 7:03 ` Nuno Sá
@ 2023-07-18 8:35 ` Alexandru Ardelean
-1 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 8:35 UTC (permalink / raw)
To: Nuno Sá
Cc: linux-kernel, dri-devel, architt, bogdan.togorean, nuno.sa,
daniel, airlied, jonas, Laurent.pinchart, rfoss, neil.armstrong,
andrzej.hajda, festevam
On Tue, Jul 18, 2023 at 10:00 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote:
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > ---
> >
>
> It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :)
oops; yes;
will send a V3;
thanks for the notification;
>
> - Nuno Sá
>
> > Changelog v1 -> v2:
> > *
> > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> > * added Fixes: tag
> > * added Reviewed-by: tag for Nuno
> >
> > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > index ddceafa7b637..09290a377957 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> > else
> > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
> >
> > - regmap_update_bits(adv7511->regmap, 0xfb,
> > - 0x6, low_refresh_rate << 1);
> > + if (adv7511->type == ADV7511)
> > + regmap_update_bits(adv7511->regmap, 0xfb,
> > + 0x6, low_refresh_rate << 1);
> > + else
> > + regmap_update_bits(adv7511->regmap, 0x4a,
> > + 0xc, low_refresh_rate << 2);
> > +
> > regmap_update_bits(adv7511->regmap, 0x17,
> > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 8:35 ` Alexandru Ardelean
0 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 8:35 UTC (permalink / raw)
To: Nuno Sá
Cc: neil.armstrong, architt, rfoss, andrzej.hajda, jonas,
linux-kernel, dri-devel, nuno.sa, bogdan.togorean,
Laurent.pinchart
On Tue, Jul 18, 2023 at 10:00 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote:
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > ---
> >
>
> It looks like you dropped your S-o-b tag in v2? I guess it was not on purpose :)
oops; yes;
will send a V3;
thanks for the notification;
>
> - Nuno Sá
>
> > Changelog v1 -> v2:
> > *
> > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> > * added Fixes: tag
> > * added Reviewed-by: tag for Nuno
> >
> > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > index ddceafa7b637..09290a377957 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> > else
> > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
> >
> > - regmap_update_bits(adv7511->regmap, 0xfb,
> > - 0x6, low_refresh_rate << 1);
> > + if (adv7511->type == ADV7511)
> > + regmap_update_bits(adv7511->regmap, 0xfb,
> > + 0x6, low_refresh_rate << 1);
> > + else
> > + regmap_update_bits(adv7511->regmap, 0x4a,
> > + 0xc, low_refresh_rate << 2);
> > +
> > regmap_update_bits(adv7511->regmap, 0x17,
> > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> >
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
2019-07-16 13:10 ` Bogdan Togorean
@ 2023-07-18 8:42 ` Alexandru Ardelean
-1 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 8:42 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: bogdan.togorean, nuno.sa, daniel, airlied, jonas,
Laurent.pinchart, rfoss, neil.armstrong, andrzej.hajda, festevam,
Alexandru Ardelean
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
* Added my S-o-b tag back
Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
* added Fixes: tag
* added Reviewed-by: tag for Nuno
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..09290a377957 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.41.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 8:42 ` Alexandru Ardelean
0 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 8:42 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: neil.armstrong, rfoss, andrzej.hajda, jonas, nuno.sa,
Laurent.pinchart, Alexandru Ardelean, bogdan.togorean
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
* Added my S-o-b tag back
Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
* added Fixes: tag
* added Reviewed-by: tag for Nuno
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..09290a377957 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.41.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-18 8:42 ` Alexandru Ardelean
@ 2023-07-18 8:49 ` Robert Foss
-1 siblings, 0 replies; 24+ messages in thread
From: Robert Foss @ 2023-07-18 8:49 UTC (permalink / raw)
To: Alexandru Ardelean
Cc: linux-kernel, dri-devel, bogdan.togorean, nuno.sa, daniel,
airlied, jonas, Laurent.pinchart, neil.armstrong, andrzej.hajda,
festevam
On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
>
> Changelog v2 -> v3:
> * https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
> * Added my S-o-b tag back
>
> Changelog v1 -> v2:
> * https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> * added Fixes: tag
> * added Reviewed-by: tag for Nuno
>
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index ddceafa7b637..09290a377957 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.41.0
>
This looks good, but I'm seeing some checkpatch style warnings, with
those fixed feel free to add my r-b.
CHECK: Alignment should match open parenthesis
#32: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:791:
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
CHECK: Alignment should match open parenthesis
#35: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:794:
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
total: 0 errors, 0 warnings, 2 checks, 15 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 1955dfe734e4 ("drm: adv7511: Fix low refresh rate register for
ADV7533/5") has style problems, please review.
NOTE: If any of the errors are false positives, please report
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 8:49 ` Robert Foss
0 siblings, 0 replies; 24+ messages in thread
From: Robert Foss @ 2023-07-18 8:49 UTC (permalink / raw)
To: Alexandru Ardelean
Cc: neil.armstrong, andrzej.hajda, jonas, linux-kernel, dri-devel,
nuno.sa, bogdan.togorean, Laurent.pinchart
On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
>
> Changelog v2 -> v3:
> * https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
> * Added my S-o-b tag back
>
> Changelog v1 -> v2:
> * https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> * added Fixes: tag
> * added Reviewed-by: tag for Nuno
>
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index ddceafa7b637..09290a377957 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.41.0
>
This looks good, but I'm seeing some checkpatch style warnings, with
those fixed feel free to add my r-b.
CHECK: Alignment should match open parenthesis
#32: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:791:
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
CHECK: Alignment should match open parenthesis
#35: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:794:
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
total: 0 errors, 0 warnings, 2 checks, 15 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 1955dfe734e4 ("drm: adv7511: Fix low refresh rate register for
ADV7533/5") has style problems, please review.
NOTE: If any of the errors are false positives, please report
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-18 8:49 ` Robert Foss
@ 2023-07-18 11:45 ` Alexandru Ardelean
-1 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 11:45 UTC (permalink / raw)
To: Robert Foss
Cc: linux-kernel, dri-devel, bogdan.togorean, nuno.sa, daniel,
airlied, jonas, Laurent.pinchart, neil.armstrong, andrzej.hajda,
festevam
On Tue, Jul 18, 2023 at 11:50 AM Robert Foss <rfoss@kernel.org> wrote:
>
> On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
> >
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> > ---
> >
> > Changelog v2 -> v3:
> > * https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
> > * Added my S-o-b tag back
> >
> > Changelog v1 -> v2:
> > * https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> > * added Fixes: tag
> > * added Reviewed-by: tag for Nuno
> >
> >
> > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > index ddceafa7b637..09290a377957 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> > else
> > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
> >
> > - regmap_update_bits(adv7511->regmap, 0xfb,
> > - 0x6, low_refresh_rate << 1);
> > + if (adv7511->type == ADV7511)
> > + regmap_update_bits(adv7511->regmap, 0xfb,
> > + 0x6, low_refresh_rate << 1);
> > + else
> > + regmap_update_bits(adv7511->regmap, 0x4a,
> > + 0xc, low_refresh_rate << 2);
> > +
> > regmap_update_bits(adv7511->regmap, 0x17,
> > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> >
> > --
> > 2.41.0
> >
>
> This looks good, but I'm seeing some checkpatch style warnings, with
> those fixed feel free to add my r-b.
Thanks.
Will do.
May I ask what options you are using for checkpatch.pl?
I don't seem to get those warnings.
And I'm basing on an "exynos-drm-fixes"branch from here
https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/
(I'll admit it may not be the correct branch)
# /scripts/checkpatch.pl
v3-0001-drm-adv7511-Fix-low-refresh-rate-register-for-ADV.patch
total: 0 errors, 0 warnings, 15 lines checked
v3-0001-drm-adv7511-Fix-low-refresh-rate-register-for-ADV.patch has no
obvious style problems and is ready for submission.
>
> CHECK: Alignment should match open parenthesis
> #32: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:791:
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
>
> CHECK: Alignment should match open parenthesis
> #35: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:794:
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
>
> total: 0 errors, 0 warnings, 2 checks, 15 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Commit 1955dfe734e4 ("drm: adv7511: Fix low refresh rate register for
> ADV7533/5") has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 11:45 ` Alexandru Ardelean
0 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 11:45 UTC (permalink / raw)
To: Robert Foss
Cc: neil.armstrong, andrzej.hajda, jonas, linux-kernel, dri-devel,
nuno.sa, bogdan.togorean, Laurent.pinchart
On Tue, Jul 18, 2023 at 11:50 AM Robert Foss <rfoss@kernel.org> wrote:
>
> On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
> >
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> > ---
> >
> > Changelog v2 -> v3:
> > * https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
> > * Added my S-o-b tag back
> >
> > Changelog v1 -> v2:
> > * https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> > * added Fixes: tag
> > * added Reviewed-by: tag for Nuno
> >
> >
> > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > index ddceafa7b637..09290a377957 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> > else
> > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
> >
> > - regmap_update_bits(adv7511->regmap, 0xfb,
> > - 0x6, low_refresh_rate << 1);
> > + if (adv7511->type == ADV7511)
> > + regmap_update_bits(adv7511->regmap, 0xfb,
> > + 0x6, low_refresh_rate << 1);
> > + else
> > + regmap_update_bits(adv7511->regmap, 0x4a,
> > + 0xc, low_refresh_rate << 2);
> > +
> > regmap_update_bits(adv7511->regmap, 0x17,
> > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> >
> > --
> > 2.41.0
> >
>
> This looks good, but I'm seeing some checkpatch style warnings, with
> those fixed feel free to add my r-b.
Thanks.
Will do.
May I ask what options you are using for checkpatch.pl?
I don't seem to get those warnings.
And I'm basing on an "exynos-drm-fixes"branch from here
https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/
(I'll admit it may not be the correct branch)
# /scripts/checkpatch.pl
v3-0001-drm-adv7511-Fix-low-refresh-rate-register-for-ADV.patch
total: 0 errors, 0 warnings, 15 lines checked
v3-0001-drm-adv7511-Fix-low-refresh-rate-register-for-ADV.patch has no
obvious style problems and is ready for submission.
>
> CHECK: Alignment should match open parenthesis
> #32: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:791:
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
>
> CHECK: Alignment should match open parenthesis
> #35: FILE: drivers/gpu/drm/bridge/adv7511/adv7511_drv.c:794:
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
>
> total: 0 errors, 0 warnings, 2 checks, 15 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> Commit 1955dfe734e4 ("drm: adv7511: Fix low refresh rate register for
> ADV7533/5") has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-18 11:45 ` Alexandru Ardelean
@ 2023-07-18 12:21 ` Nuno Sá
-1 siblings, 0 replies; 24+ messages in thread
From: Nuno Sá @ 2023-07-18 12:21 UTC (permalink / raw)
To: Alexandru Ardelean, Robert Foss
Cc: linux-kernel, dri-devel, bogdan.togorean, nuno.sa, daniel,
airlied, jonas, Laurent.pinchart, neil.armstrong, andrzej.hajda,
festevam
On Tue, 2023-07-18 at 14:45 +0300, Alexandru Ardelean wrote:
> On Tue, Jul 18, 2023 at 11:50 AM Robert Foss <rfoss@kernel.org> wrote:
> >
> > On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean <alex@shruggie.ro>
> > wrote:
> > >
> > > From: Bogdan Togorean <bogdan.togorean@analog.com>
> > >
> > > For ADV7533 and ADV7535 low refresh rate is selected using
> > > bits [3:2] of 0x4a main register.
> > > So depending on ADV model write 0xfb or 0x4a register.
> > >
> > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> > > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> > > ---
> > >
> > > Changelog v2 -> v3:
> > > *
> > > https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
> > > * Added my S-o-b tag back
> > >
> > > Changelog v1 -> v2:
> > > *
> > > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> > > * added Fixes: tag
> > > * added Reviewed-by: tag for Nuno
> > >
> > >
> > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> > > 1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > index ddceafa7b637..09290a377957 100644
> > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> > > else
> > > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
> > >
> > > - regmap_update_bits(adv7511->regmap, 0xfb,
> > > - 0x6, low_refresh_rate << 1);
> > > + if (adv7511->type == ADV7511)
> > > + regmap_update_bits(adv7511->regmap, 0xfb,
> > > + 0x6, low_refresh_rate << 1);
> > > + else
> > > + regmap_update_bits(adv7511->regmap, 0x4a,
> > > + 0xc, low_refresh_rate << 2);
> > > +
> > > regmap_update_bits(adv7511->regmap, 0x17,
> > > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> > >
> > > --
> > > 2.41.0
> > >
> >
> > This looks good, but I'm seeing some checkpatch style warnings, with
> > those fixed feel free to add my r-b.
>
> Thanks.
> Will do.
> May I ask what options you are using for checkpatch.pl?
'--strict' should trigger those CHECKS...
Cool enough (or not) it seems the option is not really there when you type
--help
- Nuno Sá
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v3] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 12:21 ` Nuno Sá
0 siblings, 0 replies; 24+ messages in thread
From: Nuno Sá @ 2023-07-18 12:21 UTC (permalink / raw)
To: Alexandru Ardelean, Robert Foss
Cc: neil.armstrong, andrzej.hajda, jonas, linux-kernel, dri-devel,
nuno.sa, bogdan.togorean, Laurent.pinchart
On Tue, 2023-07-18 at 14:45 +0300, Alexandru Ardelean wrote:
> On Tue, Jul 18, 2023 at 11:50 AM Robert Foss <rfoss@kernel.org> wrote:
> >
> > On Tue, Jul 18, 2023 at 10:42 AM Alexandru Ardelean <alex@shruggie.ro>
> > wrote:
> > >
> > > From: Bogdan Togorean <bogdan.togorean@analog.com>
> > >
> > > For ADV7533 and ADV7535 low refresh rate is selected using
> > > bits [3:2] of 0x4a main register.
> > > So depending on ADV model write 0xfb or 0x4a register.
> > >
> > > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> > > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> > > ---
> > >
> > > Changelog v2 -> v3:
> > > *
> > > https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
> > > * Added my S-o-b tag back
> > >
> > > Changelog v1 -> v2:
> > > *
> > > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
> > > * added Fixes: tag
> > > * added Reviewed-by: tag for Nuno
> > >
> > >
> > > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> > > 1 file changed, 7 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > index ddceafa7b637..09290a377957 100644
> > > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> > > else
> > > low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
> > >
> > > - regmap_update_bits(adv7511->regmap, 0xfb,
> > > - 0x6, low_refresh_rate << 1);
> > > + if (adv7511->type == ADV7511)
> > > + regmap_update_bits(adv7511->regmap, 0xfb,
> > > + 0x6, low_refresh_rate << 1);
> > > + else
> > > + regmap_update_bits(adv7511->regmap, 0x4a,
> > > + 0xc, low_refresh_rate << 2);
> > > +
> > > regmap_update_bits(adv7511->regmap, 0x17,
> > > 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> > >
> > > --
> > > 2.41.0
> > >
> >
> > This looks good, but I'm seeing some checkpatch style warnings, with
> > those fixed feel free to add my r-b.
>
> Thanks.
> Will do.
> May I ask what options you are using for checkpatch.pl?
'--strict' should trigger those CHECKS...
Cool enough (or not) it seems the option is not really there when you type
--help
- Nuno Sá
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
2019-07-16 13:10 ` Bogdan Togorean
@ 2023-07-19 6:01 ` Alexandru Ardelean
-1 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-19 6:01 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: neil.armstrong, rfoss, andrzej.hajda, jonas, nuno.sa,
Laurent.pinchart, Alexandru Ardelean, bogdan.togorean
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..8d6c93296503 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.41.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-19 6:01 ` Alexandru Ardelean
0 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-19 6:01 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: bogdan.togorean, nuno.sa, daniel, airlied, jonas,
Laurent.pinchart, rfoss, neil.armstrong, andrzej.hajda, festevam,
Alexandru Ardelean
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
Reviewed-by: Robert Foss <rfoss@kernel.org>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ddceafa7b637..8d6c93296503 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.41.0
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-19 6:01 ` Alexandru Ardelean
@ 2023-07-20 7:30 ` Alexandru Ardelean
-1 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-20 7:30 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: bogdan.togorean, nuno.sa, daniel, airlied, jonas,
Laurent.pinchart, rfoss, neil.armstrong, andrzej.hajda, festevam
On Wed, Jul 19, 2023 at 9:02 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Robert Foss <rfoss@kernel.org>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
Right.
I forgot a changelog here.
Apologies
Changelog v3 -> v4:
* Ran ./scripts/checkpatch.pl --strict
* Added Reviewed-by: Robert Foss <rfoss@kernel.org>
Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
* Added my S-o-b tag back
Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
* added Fixes: tag
* added Reviewed-by: tag for Nuno
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index ddceafa7b637..8d6c93296503 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-20 7:30 ` Alexandru Ardelean
0 siblings, 0 replies; 24+ messages in thread
From: Alexandru Ardelean @ 2023-07-20 7:30 UTC (permalink / raw)
To: linux-kernel, dri-devel
Cc: neil.armstrong, rfoss, andrzej.hajda, jonas, nuno.sa,
Laurent.pinchart, bogdan.togorean
On Wed, Jul 19, 2023 at 9:02 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Robert Foss <rfoss@kernel.org>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
Right.
I forgot a changelog here.
Apologies
Changelog v3 -> v4:
* Ran ./scripts/checkpatch.pl --strict
* Added Reviewed-by: Robert Foss <rfoss@kernel.org>
Changelog v2 -> v3:
* https://lore.kernel.org/dri-devel/1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com/T/#u
* Added my S-o-b tag back
Changelog v1 -> v2:
* https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@analog.com/
* added Fixes: tag
* added Reviewed-by: tag for Nuno
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index ddceafa7b637..8d6c93296503 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-19 6:01 ` Alexandru Ardelean
@ 2023-07-20 7:44 ` Frieder Schrempf
-1 siblings, 0 replies; 24+ messages in thread
From: Frieder Schrempf @ 2023-07-20 7:44 UTC (permalink / raw)
To: Alexandru Ardelean, linux-kernel, dri-devel
Cc: neil.armstrong, rfoss, andrzej.hajda, jonas, nuno.sa,
Laurent.pinchart, bogdan.togorean
On 19.07.23 08:01, Alexandru Ardelean wrote:
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Robert Foss <rfoss@kernel.org>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-20 7:44 ` Frieder Schrempf
0 siblings, 0 replies; 24+ messages in thread
From: Frieder Schrempf @ 2023-07-20 7:44 UTC (permalink / raw)
To: Alexandru Ardelean, linux-kernel, dri-devel
Cc: neil.armstrong, rfoss, jonas, nuno.sa, Laurent.pinchart,
andrzej.hajda, bogdan.togorean
On 19.07.23 08:01, Alexandru Ardelean wrote:
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533")
> Reviewed-by: Robert Foss <rfoss@kernel.org>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-19 6:01 ` Alexandru Ardelean
@ 2023-07-21 11:48 ` Robert Foss
-1 siblings, 0 replies; 24+ messages in thread
From: Robert Foss @ 2023-07-21 11:48 UTC (permalink / raw)
To: linux-kernel, Alexandru Ardelean, dri-devel
Cc: Robert Foss, festevam, andrzej.hajda, daniel, bogdan.togorean,
airlied, nuno.sa, Laurent.pinchart, neil.armstrong, jonas
On Wed, 19 Jul 2023 09:01:43 +0300, Alexandru Ardelean wrote:
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
>
> [...]
Applied, thanks!
[1/1] drm: adv7511: Fix low refresh rate register for ADV7533/5
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d281eeaa4de2
Rob
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v4] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-21 11:48 ` Robert Foss
0 siblings, 0 replies; 24+ messages in thread
From: Robert Foss @ 2023-07-21 11:48 UTC (permalink / raw)
To: linux-kernel, Alexandru Ardelean, dri-devel
Cc: neil.armstrong, Robert Foss, andrzej.hajda, jonas, nuno.sa,
bogdan.togorean, Laurent.pinchart
On Wed, 19 Jul 2023 09:01:43 +0300, Alexandru Ardelean wrote:
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
>
> [...]
Applied, thanks!
[1/1] drm: adv7511: Fix low refresh rate register for ADV7533/5
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d281eeaa4de2
Rob
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2023-07-21 11:48 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16 13:10 [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5 Bogdan Togorean
2019-07-16 13:10 ` Bogdan Togorean
2023-07-18 6:28 ` [PATCH V2] " Alexandru Ardelean
2023-07-18 6:28 ` Alexandru Ardelean
2023-07-18 7:03 ` Nuno Sá
2023-07-18 7:03 ` Nuno Sá
2023-07-18 8:35 ` Alexandru Ardelean
2023-07-18 8:35 ` Alexandru Ardelean
2023-07-18 8:42 ` [PATCH v3] " Alexandru Ardelean
2023-07-18 8:42 ` Alexandru Ardelean
2023-07-18 8:49 ` Robert Foss
2023-07-18 8:49 ` Robert Foss
2023-07-18 11:45 ` Alexandru Ardelean
2023-07-18 11:45 ` Alexandru Ardelean
2023-07-18 12:21 ` Nuno Sá
2023-07-18 12:21 ` Nuno Sá
2023-07-19 6:01 ` [PATCH v4] " Alexandru Ardelean
2023-07-19 6:01 ` Alexandru Ardelean
2023-07-20 7:30 ` Alexandru Ardelean
2023-07-20 7:30 ` Alexandru Ardelean
2023-07-20 7:44 ` Frieder Schrempf
2023-07-20 7:44 ` Frieder Schrempf
2023-07-21 11:48 ` Robert Foss
2023-07-21 11:48 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.