* [PATCH net-next v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource()
@ 2021-06-11 4:50 Yang Yingliang
2021-06-11 6:57 ` weiyongjun (A)
0 siblings, 1 reply; 3+ messages in thread
From: Yang Yingliang @ 2021-06-11 4:50 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: davem, kuba, andrew
Use devm_platform_get_and_ioremap_resource() to simplify
code.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
v2:
only convert the first platform_get_resource()
---
drivers/net/mdio/mdio-mscc-miim.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
index b36e5ea04ddf..071c654bab29 100644
--- a/drivers/net/mdio/mdio-mscc-miim.c
+++ b/drivers/net/mdio/mdio-mscc-miim.c
@@ -139,10 +139,6 @@ static int mscc_miim_probe(struct platform_device *pdev)
struct mscc_miim_dev *dev;
int ret;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res)
- return -ENODEV;
-
bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
if (!bus)
return -ENOMEM;
@@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device *pdev)
bus->parent = &pdev->dev;
dev = bus->priv;
- dev->regs = devm_ioremap_resource(&pdev->dev, res);
+ dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(dev->regs)) {
dev_err(&pdev->dev, "Unable to map MIIM registers\n");
return PTR_ERR(dev->regs);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource()
2021-06-11 4:50 [PATCH net-next v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
@ 2021-06-11 6:57 ` weiyongjun (A)
2021-06-11 7:40 ` Yang Yingliang
0 siblings, 1 reply; 3+ messages in thread
From: weiyongjun (A) @ 2021-06-11 6:57 UTC (permalink / raw)
To: Yang Yingliang, linux-kernel, netdev; +Cc: davem, kuba, andrew
> Use devm_platform_get_and_ioremap_resource() to simplify
> code.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
> only convert the first platform_get_resource()
> ---
> drivers/net/mdio/mdio-mscc-miim.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
> index b36e5ea04ddf..071c654bab29 100644
> --- a/drivers/net/mdio/mdio-mscc-miim.c
> +++ b/drivers/net/mdio/mdio-mscc-miim.c
> @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct platform_device *pdev)
> struct mscc_miim_dev *dev;
> int ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res)
> - return -ENODEV;
> -
> bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
> if (!bus)
> return -ENOMEM;
> @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device *pdev)
> bus->parent = &pdev->dev;
>
> dev = bus->priv;
> - dev->regs = devm_ioremap_resource(&pdev->dev, res);
> + dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
res not used later, so should be
dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(dev->regs)) {
> dev_err(&pdev->dev, "Unable to map MIIM registers\n");
> return PTR_ERR(dev->regs);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource()
2021-06-11 6:57 ` weiyongjun (A)
@ 2021-06-11 7:40 ` Yang Yingliang
0 siblings, 0 replies; 3+ messages in thread
From: Yang Yingliang @ 2021-06-11 7:40 UTC (permalink / raw)
To: weiyongjun (A), linux-kernel, netdev; +Cc: davem, kuba, andrew
On 2021/6/11 14:57, weiyongjun (A) wrote:
>
>> Use devm_platform_get_and_ioremap_resource() to simplify
>> code.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> v2:
>> only convert the first platform_get_resource()
>> ---
>> drivers/net/mdio/mdio-mscc-miim.c | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/mdio/mdio-mscc-miim.c
>> b/drivers/net/mdio/mdio-mscc-miim.c
>> index b36e5ea04ddf..071c654bab29 100644
>> --- a/drivers/net/mdio/mdio-mscc-miim.c
>> +++ b/drivers/net/mdio/mdio-mscc-miim.c
>> @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct
>> platform_device *pdev)
>> struct mscc_miim_dev *dev;
>> int ret;
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res)
>> - return -ENODEV;
>> -
>> bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
>> if (!bus)
>> return -ENOMEM;
>> @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device
>> *pdev)
>> bus->parent = &pdev->dev;
>> dev = bus->priv;
>> - dev->regs = devm_ioremap_resource(&pdev->dev, res);
>> + dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>
>
> res not used later, so should be
>
> dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
Yes, I will send a v3 later.
Thanks,
Yang
>
>
>> if (IS_ERR(dev->regs)) {
>> dev_err(&pdev->dev, "Unable to map MIIM registers\n");
>> return PTR_ERR(dev->regs);
> .
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-11 7:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11 4:50 [PATCH net-next v2] net: mdio: mscc-miim: Use devm_platform_get_and_ioremap_resource() Yang Yingliang
2021-06-11 6:57 ` weiyongjun (A)
2021-06-11 7:40 ` Yang Yingliang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.