All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	linux-gpio@vger.kernel.org, Rob Herring <robherring2@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: zynq: Setup chip->base based on alias ID
Date: Wed, 11 Apr 2018 15:55:01 +0200	[thread overview]
Message-ID: <6ee982f8eb6e07f9ecbb0cc5093152f4a16b9c31.1523454899.git.michal.simek@xilinx.com> (raw)

In past Xilinx gpio-zynq driver was setting up gpio chip->base as 0
which was chagned to autodetection when driver was upstreamed. Older
systems, which were using this old version, setup SW stack which expects
zynq gpio base as 0 and right now there is no way how to set this up.

The patch is adding an option to setup chip->base based on aliases which
is something what some other drivers are doing too.
It means when gpio0 alias is setup then chip->base is 0. When gpio alias
is not setup gpiochip_find_base() set it up properly which is current
behavior.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/gpio/gpio-zynq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 23bb10576def..412cb5f31a9b 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -831,7 +831,7 @@ static int zynq_gpio_probe(struct platform_device *pdev)
 	chip->free = zynq_gpio_free;
 	chip->direction_input = zynq_gpio_dir_in;
 	chip->direction_output = zynq_gpio_dir_out;
-	chip->base = -1;
+	chip->base = of_alias_get_id(pdev->dev.of_node, "gpio");
 	chip->ngpio = gpio->p_data->ngpio;
 
 	/* Retrieve GPIO clock */
-- 
2.17.0

WARNING: multiple messages have this Message-ID (diff)
From: michal.simek@xilinx.com (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: zynq: Setup chip->base based on alias ID
Date: Wed, 11 Apr 2018 15:55:01 +0200	[thread overview]
Message-ID: <6ee982f8eb6e07f9ecbb0cc5093152f4a16b9c31.1523454899.git.michal.simek@xilinx.com> (raw)

In past Xilinx gpio-zynq driver was setting up gpio chip->base as 0
which was chagned to autodetection when driver was upstreamed. Older
systems, which were using this old version, setup SW stack which expects
zynq gpio base as 0 and right now there is no way how to set this up.

The patch is adding an option to setup chip->base based on aliases which
is something what some other drivers are doing too.
It means when gpio0 alias is setup then chip->base is 0. When gpio alias
is not setup gpiochip_find_base() set it up properly which is current
behavior.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/gpio/gpio-zynq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c
index 23bb10576def..412cb5f31a9b 100644
--- a/drivers/gpio/gpio-zynq.c
+++ b/drivers/gpio/gpio-zynq.c
@@ -831,7 +831,7 @@ static int zynq_gpio_probe(struct platform_device *pdev)
 	chip->free = zynq_gpio_free;
 	chip->direction_input = zynq_gpio_dir_in;
 	chip->direction_output = zynq_gpio_dir_out;
-	chip->base = -1;
+	chip->base = of_alias_get_id(pdev->dev.of_node, "gpio");
 	chip->ngpio = gpio->p_data->ngpio;
 
 	/* Retrieve GPIO clock */
-- 
2.17.0

             reply	other threads:[~2018-04-11 13:55 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-11 13:55 Michal Simek [this message]
2018-04-11 13:55 ` [PATCH] gpio: zynq: Setup chip->base based on alias ID Michal Simek
2018-04-26 13:08 ` Linus Walleij
2018-04-26 13:08   ` Linus Walleij
2018-04-26 13:35   ` Michal Simek
2018-04-26 13:35     ` Michal Simek
2018-05-02 10:10     ` Linus Walleij
2018-05-02 10:10       ` Linus Walleij
2018-05-02 10:15       ` Michal Simek
2018-05-02 10:15         ` Michal Simek
2018-05-02 13:01         ` Linus Walleij
2018-05-02 13:01           ` Linus Walleij
2018-05-02 13:41           ` Michal Simek
2018-05-02 13:41             ` Michal Simek
2018-05-02 13:56             ` Linus Walleij
2018-05-02 13:56               ` Linus Walleij
2018-05-02 14:19               ` Michal Simek
2018-05-02 14:19                 ` Michal Simek
2018-05-15 13:26                 ` Michal Simek
2018-05-15 13:26                   ` Michal Simek
2018-05-23  9:44                   ` Linus Walleij
2018-05-23  9:44                     ` Linus Walleij
2018-05-23 10:26                     ` Michal Simek
2018-05-23 10:26                       ` Michal Simek
2018-05-23  9:42                 ` Linus Walleij
2018-05-23  9:42                   ` Linus Walleij
2018-05-23 10:17                   ` Michal Simek
2018-05-23 10:17                     ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ee982f8eb6e07f9ecbb0cc5093152f4a16b9c31.1523454899.git.michal.simek@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monstr@monstr.eu \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=robherring2@gmail.com \
    --cc=s.trumtrar@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.