From: John Garry <john.garry@huawei.com> To: <Tudor.Ambarus@microchip.com>, <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <richard@nod.at>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mtd: spi-nor: Fix direction of the write_sr() transfer Date: Fri, 4 Oct 2019 16:17:38 +0100 [thread overview] Message-ID: <6eecffe2-539f-f1a1-2008-3877c5f5c3ef@huawei.com> (raw) In-Reply-To: <60f0c52f-1301-57eb-59ba-b2893107d5d6@huawei.com> On 04/10/2019 12:31, John Garry wrote: > On 04/10/2019 11:48, Tudor.Ambarus@microchip.com wrote: >> John, does this fix your problem? > > It fixes the problem in the flash_lock -u command no longer errors like > this: > root@ubuntu:/home/john# sudo flash_lock -u /dev/mtd0 > flash_lock: error!: could not unlock device: /dev/mtd0 > > However, with this change, even when the flash is unlocked I cannot > write, so there is something else wrong. It's probably a bug in my > under-development driver. I'm looking at it now. Just to confirm, I tested an earlier HW version with my driver and flash lock/unlock function is ok. There seems something wrong with the latest HW version which I need to understand. Anyway: Tested-by: John Garry <john.garry@huawei.com> Thanks, John > >> >> On 10/04/2019 01:47 PM, Tudor Ambarus - M18064 wrote: >>> From: Tudor Ambarus <tudor.ambarus@microchip.com> >>> >>> write_sr() sends data to the SPI memory, fix the direction. >>> >>> Fixes: b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c") >>> Reported-by: John Garry <john.garry@huawei.com> >>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> >>> --- >>> drivers/mtd/spi-nor/spi-nor.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c >>> b/drivers/mtd/spi-nor/spi-nor.c >>> index 1d8621d43160..7acf4a93b592 100644 >>> --- a/drivers/mtd/spi-nor/spi-nor.c >>> +++ b/drivers/mtd/spi-nor/spi-nor.c >>> @@ -487,7 +487,7 @@ static int write_sr(struct spi_nor *nor, u8 val) >>> SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WRSR, 1), >>> SPI_MEM_OP_NO_ADDR, >>> SPI_MEM_OP_NO_DUMMY, >>> - SPI_MEM_OP_DATA_IN(1, nor->bouncebuf, 1)); >>> + SPI_MEM_OP_DATA_OUT(1, nor->bouncebuf, 1)); >>> >>> return spi_mem_exec_op(nor->spimem, &op); >>> } >>> >
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com> To: <Tudor.Ambarus@microchip.com>, <vigneshr@ti.com>, <miquel.raynal@bootlin.com>, <richard@nod.at>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mtd: spi-nor: Fix direction of the write_sr() transfer Date: Fri, 4 Oct 2019 16:17:38 +0100 [thread overview] Message-ID: <6eecffe2-539f-f1a1-2008-3877c5f5c3ef@huawei.com> (raw) In-Reply-To: <60f0c52f-1301-57eb-59ba-b2893107d5d6@huawei.com> On 04/10/2019 12:31, John Garry wrote: > On 04/10/2019 11:48, Tudor.Ambarus@microchip.com wrote: >> John, does this fix your problem? > > It fixes the problem in the flash_lock -u command no longer errors like > this: > root@ubuntu:/home/john# sudo flash_lock -u /dev/mtd0 > flash_lock: error!: could not unlock device: /dev/mtd0 > > However, with this change, even when the flash is unlocked I cannot > write, so there is something else wrong. It's probably a bug in my > under-development driver. I'm looking at it now. Just to confirm, I tested an earlier HW version with my driver and flash lock/unlock function is ok. There seems something wrong with the latest HW version which I need to understand. Anyway: Tested-by: John Garry <john.garry@huawei.com> Thanks, John > >> >> On 10/04/2019 01:47 PM, Tudor Ambarus - M18064 wrote: >>> From: Tudor Ambarus <tudor.ambarus@microchip.com> >>> >>> write_sr() sends data to the SPI memory, fix the direction. >>> >>> Fixes: b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c") >>> Reported-by: John Garry <john.garry@huawei.com> >>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> >>> --- >>> drivers/mtd/spi-nor/spi-nor.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/mtd/spi-nor/spi-nor.c >>> b/drivers/mtd/spi-nor/spi-nor.c >>> index 1d8621d43160..7acf4a93b592 100644 >>> --- a/drivers/mtd/spi-nor/spi-nor.c >>> +++ b/drivers/mtd/spi-nor/spi-nor.c >>> @@ -487,7 +487,7 @@ static int write_sr(struct spi_nor *nor, u8 val) >>> SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_WRSR, 1), >>> SPI_MEM_OP_NO_ADDR, >>> SPI_MEM_OP_NO_DUMMY, >>> - SPI_MEM_OP_DATA_IN(1, nor->bouncebuf, 1)); >>> + SPI_MEM_OP_DATA_OUT(1, nor->bouncebuf, 1)); >>> >>> return spi_mem_exec_op(nor->spimem, &op); >>> } >>> > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-10-04 15:17 UTC|newest] Thread overview: 193+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-24 7:45 [PATCH v2 00/22] mtd: spi-nor: Quad Enable and (un)lock methods Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` [PATCH v2 01/22] mtd: spi-nor: hisi-sfc: Drop nor->erase NULL assignment Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-10-10 6:49 ` Boris Brezillon 2019-10-10 6:49 ` Boris Brezillon 2019-10-10 6:49 ` Boris Brezillon 2019-10-10 6:49 ` Boris Brezillon 2019-10-23 21:24 ` Tudor.Ambarus 2019-10-23 21:24 ` Tudor.Ambarus 2019-10-23 21:24 ` Tudor.Ambarus 2019-10-23 21:24 ` Tudor.Ambarus 2019-09-24 7:45 ` [PATCH v2 02/22] mtd: spi-nor: Introduce 'struct spi_nor_controller_ops' Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-10-10 6:51 ` Boris Brezillon 2019-10-10 6:51 ` Boris Brezillon 2019-10-10 6:51 ` Boris Brezillon 2019-10-10 6:51 ` Boris Brezillon 2019-10-23 21:24 ` Tudor.Ambarus 2019-10-23 21:24 ` Tudor.Ambarus 2019-10-23 21:24 ` Tudor.Ambarus 2019-10-23 21:24 ` Tudor.Ambarus 2019-09-24 7:45 ` [PATCH v2 03/22] mtd: spi-nor: cadence-quadspi: Fix cqspi_command_read() definition Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-09-24 7:45 ` Tudor.Ambarus 2019-10-10 6:54 ` Boris Brezillon 2019-10-10 6:54 ` Boris Brezillon 2019-10-10 6:54 ` Boris Brezillon 2019-10-10 6:54 ` Boris Brezillon 2019-10-23 21:25 ` Tudor.Ambarus 2019-10-23 21:25 ` Tudor.Ambarus 2019-10-23 21:25 ` Tudor.Ambarus 2019-10-23 21:25 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 04/22] mtd: spi-nor: Rename nor->params to nor->flash Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-10 7:05 ` Boris Brezillon 2019-10-10 7:05 ` Boris Brezillon 2019-10-10 7:05 ` Boris Brezillon 2019-10-10 7:05 ` Boris Brezillon 2019-10-23 21:34 ` Tudor.Ambarus 2019-10-23 21:34 ` Tudor.Ambarus 2019-10-23 21:34 ` Tudor.Ambarus 2019-10-23 21:34 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 05/22] mtd: spi-nor: Rework read_sr() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-10 7:13 ` Boris Brezillon 2019-10-10 7:13 ` Boris Brezillon 2019-10-10 7:13 ` Boris Brezillon 2019-10-10 7:13 ` Boris Brezillon 2019-09-24 7:46 ` [PATCH v2 06/22] mtd: spi-nor: Rework read_fsr() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-10 7:14 ` Boris Brezillon 2019-10-10 7:14 ` Boris Brezillon 2019-10-10 7:14 ` Boris Brezillon 2019-10-10 7:14 ` Boris Brezillon 2019-09-24 7:46 ` [PATCH v2 07/22] mtd: spi-nor: Rework read_cr() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-10-10 7:16 ` Boris Brezillon 2019-09-24 7:46 ` [PATCH v2 08/22] mtd: spi-nor: Rework write_enable/disable() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-10 7:21 ` Boris Brezillon 2019-10-10 7:21 ` Boris Brezillon 2019-10-10 7:21 ` Boris Brezillon 2019-10-10 7:21 ` Boris Brezillon 2019-10-23 23:39 ` Tudor.Ambarus 2019-10-23 23:39 ` Tudor.Ambarus 2019-10-23 23:39 ` Tudor.Ambarus 2019-10-23 23:39 ` Tudor.Ambarus 2019-10-24 6:04 ` Boris Brezillon 2019-10-24 6:04 ` Boris Brezillon 2019-10-24 6:04 ` Boris Brezillon 2019-10-24 6:04 ` Boris Brezillon 2019-10-24 11:01 ` Tudor.Ambarus 2019-10-24 11:01 ` Tudor.Ambarus 2019-10-24 11:01 ` Tudor.Ambarus 2019-10-24 11:01 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 09/22] mtd: spi-nor: Fix retlen handling in sst_write() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-10 7:33 ` Boris Brezillon 2019-10-10 7:33 ` Boris Brezillon 2019-10-10 7:33 ` Boris Brezillon 2019-10-10 7:33 ` Boris Brezillon 2019-10-25 7:34 ` Tudor.Ambarus 2019-10-25 7:34 ` Tudor.Ambarus 2019-10-25 7:34 ` Tudor.Ambarus 2019-10-25 7:34 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 10/22] mtd: spi-nor: Rework write_sr() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-10-04 9:39 ` John Garry 2019-10-04 9:39 ` John Garry 2019-10-04 9:39 ` John Garry 2019-10-04 9:39 ` John Garry 2019-10-04 10:03 ` Tudor.Ambarus 2019-10-04 10:03 ` Tudor.Ambarus 2019-10-04 10:03 ` Tudor.Ambarus 2019-10-04 10:03 ` Tudor.Ambarus 2019-10-04 10:26 ` John Garry 2019-10-04 10:26 ` John Garry 2019-10-04 10:26 ` John Garry 2019-10-04 10:26 ` John Garry 2019-10-04 10:47 ` [PATCH] mtd: spi-nor: Fix direction of the write_sr() transfer Tudor.Ambarus 2019-10-04 10:47 ` Tudor.Ambarus 2019-10-04 10:48 ` Tudor.Ambarus 2019-10-04 10:48 ` Tudor.Ambarus 2019-10-04 11:31 ` John Garry 2019-10-04 11:31 ` John Garry 2019-10-04 15:17 ` John Garry [this message] 2019-10-04 15:17 ` John Garry 2019-10-04 15:50 ` Tudor.Ambarus 2019-10-04 15:50 ` Tudor.Ambarus 2019-10-04 16:06 ` Vignesh Raghavendra 2019-10-04 16:06 ` Vignesh Raghavendra 2019-10-04 16:09 ` Miquel Raynal 2019-10-04 16:09 ` Miquel Raynal 2019-09-24 7:46 ` [PATCH v2 11/22] mtd: spi-nor: Rework spi_nor_read/write_sr2() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 12/22] mtd: spi-nor: Report error in spi_nor_xread_sr() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 13/22] mtd: spi-nor: Void return type for spi_nor_clear_sr/fsr() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 14/22] mtd: spi-nor: Drop duplicated new line Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 15/22] mtd: spi-nor: Drop spansion_quad_enable() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 16/22] mtd: spi-nor: Fix errno on quad_enable methods Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 17/22] mtd: spi-nor: Check all the bits written, not just the BP ones Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 18/22] mtd: spi-nor: Fix clearing of QE bit on lock()/unlock() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 19/22] mtd: spi-nor: Rework macronix_quad_enable() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` [PATCH v2 20/22] mtd: spi-nor: Rework spansion(_no)_read_cr_quad_enable() Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:46 ` Tudor.Ambarus 2019-09-24 7:47 ` [PATCH v2 21/22] mtd: spi-nor: Update sr2_bit7_quad_enable() Tudor.Ambarus 2019-09-24 7:47 ` Tudor.Ambarus 2019-09-24 7:47 ` Tudor.Ambarus 2019-09-24 7:47 ` Tudor.Ambarus 2019-09-24 7:47 ` [PATCH v2 22/22] mtd: spi-nor: Rework the disabling of block write protection Tudor.Ambarus 2019-09-24 7:47 ` Tudor.Ambarus 2019-09-24 7:47 ` Tudor.Ambarus 2019-09-24 7:47 ` Tudor.Ambarus 2019-09-25 10:11 ` [PATCH v2 00/22] mtd: spi-nor: Quad Enable and (un)lock methods Tudor.Ambarus 2019-09-25 10:11 ` Tudor.Ambarus 2019-09-25 10:11 ` Tudor.Ambarus 2019-09-25 10:11 ` Tudor.Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6eecffe2-539f-f1a1-2008-3877c5f5c3ef@huawei.com \ --to=john.garry@huawei.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.