* [Fail] generic/530 check failed on overlay
@ 2019-05-08 7:30 JeffleXu
2019-05-09 1:54 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: JeffleXu @ 2019-05-08 7:30 UTC (permalink / raw)
To: fstests; +Cc: darrick.wong, guaneryu
When I run "./check -overlay generic/530", it failed with following log
```
generic/530 1s ... - output mismatch (see
/root/xfstests/results//generic/530.out.bad)
--- tests/generic/530.out 2019-05-07 16:18:55.951796117 +0800
+++ /root/xfstests/results//generic/530.out.bad 2019-05-08
14:55:30.976816701 +0800
@@ -1,2 +1,3 @@
QA output created by 530
+shutdown: Inappropriate ioctl for device
silence is golden
...
```
xfstests version: 1.1.1.1
kernel: linux 4.19
the commit that imports generic/530: e6703b90
https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=e6703b903a5025b3eccac758f5bdd8e847f62c39
I find that the error is due to the following snippet in
src/t_open_tmpfiles.c
```c
ret = ioctl(min_fd, XFS_IOC_GOINGDOWN, &flag);
if (ret) {
perror("shutdown");
exit(2);
}
```
XFS_IOC_GOINGDOWN is specifically defined in XFS filesystem, while it is
not
supported in overlay filesystem.
In my understanding, test cases in "tests/generic" should be generic for
all
filesystem types, and the XFS_IOC_GOINGDOWN macro used by generic/530 is
obviously against this rule. Or maybe I missed something important and
would
approciate if someone could give me some indication.
thx
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Fail] generic/530 check failed on overlay
2019-05-08 7:30 [Fail] generic/530 check failed on overlay JeffleXu
@ 2019-05-09 1:54 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2019-05-09 1:54 UTC (permalink / raw)
To: JeffleXu; +Cc: fstests, guaneryu
On Wed, May 08, 2019 at 03:30:11PM +0800, JeffleXu wrote:
> When I run "./check -overlay generic/530", it failed with following log
>
>
> ```
>
> generic/530 1s ... - output mismatch (see
> /root/xfstests/results//generic/530.out.bad)
> --- tests/generic/530.out 2019-05-07 16:18:55.951796117 +0800
> +++ /root/xfstests/results//generic/530.out.bad 2019-05-08
> 14:55:30.976816701 +0800
> @@ -1,2 +1,3 @@
> QA output created by 530
> +shutdown: Inappropriate ioctl for device
Odd... I would've thought the _require_scratch_shutdown would have
stopped this test? What's the underlying filesystem?
--D
> silence is golden
> ...
>
> ```
>
>
> xfstests version: 1.1.1.1
>
> kernel: linux 4.19
>
> the commit that imports generic/530: e6703b90
>
> https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git/commit/?id=e6703b903a5025b3eccac758f5bdd8e847f62c39
>
>
>
> I find that the error is due to the following snippet in
> src/t_open_tmpfiles.c
>
>
> ```c
>
> ret = ioctl(min_fd, XFS_IOC_GOINGDOWN, &flag);
> if (ret) {
> perror("shutdown");
> exit(2);
> }
>
> ```
>
>
> XFS_IOC_GOINGDOWN is specifically defined in XFS filesystem, while it is not
>
> supported in overlay filesystem.
>
>
> In my understanding, test cases in "tests/generic" should be generic for all
>
> filesystem types, and the XFS_IOC_GOINGDOWN macro used by generic/530 is
>
> obviously against this rule. Or maybe I missed something important and would
>
> approciate if someone could give me some indication.
>
>
> thx
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-09 1:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 7:30 [Fail] generic/530 check failed on overlay JeffleXu
2019-05-09 1:54 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.