All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] power: supply: cw2015: Attach OF ID table to the driver
@ 2020-05-30 16:40 Andy Shevchenko
  2020-05-30 17:00 ` Tobias Schramm
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-05-30 16:40 UTC (permalink / raw)
  To: Tobias Schrammm, linux-pm, Sebastian Reichel
  Cc: Andy Shevchenko, kbuild test robot

It appears that OF ID table was hanging around without being attached
to the driver. Attach it properly.

Fixes: b4c7715c10c1 ("power: supply: add CellWise cw2015 fuel gauge driver")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/power/supply/cw2015_battery.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
index 19f62ea957ee..0146f1bfc29b 100644
--- a/drivers/power/supply/cw2015_battery.c
+++ b/drivers/power/supply/cw2015_battery.c
@@ -734,6 +734,7 @@ MODULE_DEVICE_TABLE(of, cw2015_of_match);
 static struct i2c_driver cw_bat_driver = {
 	.driver = {
 		.name = "cw2015",
+		.of_match_table = cw2015_of_match,
 		.pm = &cw_bat_pm_ops,
 	},
 	.probe_new = cw_bat_probe,
-- 
2.27.0.rc2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] power: supply: cw2015: Attach OF ID table to the driver
  2020-05-30 16:40 [PATCH v1] power: supply: cw2015: Attach OF ID table to the driver Andy Shevchenko
@ 2020-05-30 17:00 ` Tobias Schramm
  2020-06-05 23:16   ` Sebastian Reichel
  0 siblings, 1 reply; 3+ messages in thread
From: Tobias Schramm @ 2020-05-30 17:00 UTC (permalink / raw)
  To: Andy Shevchenko, linux-pm, Sebastian Reichel; +Cc: kbuild test robot

Hi Andy,

> diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
> index 19f62ea957ee..0146f1bfc29b 100644
> --- a/drivers/power/supply/cw2015_battery.c
> +++ b/drivers/power/supply/cw2015_battery.c
> @@ -734,6 +734,7 @@ MODULE_DEVICE_TABLE(of, cw2015_of_match);
>  static struct i2c_driver cw_bat_driver = {
>  	.driver = {
>  		.name = "cw2015",
> +		.of_match_table = cw2015_of_match,
>  		.pm = &cw_bat_pm_ops,
>  	},
>  	.probe_new = cw_bat_probe,
> 

LGTM.

Acked-By: Tobias Schramm <t.schramm@manjaro.org>
Tested-By: Tobias Schramm <t.schramm@manjaro.org>

Thanks,

Tobias

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] power: supply: cw2015: Attach OF ID table to the driver
  2020-05-30 17:00 ` Tobias Schramm
@ 2020-06-05 23:16   ` Sebastian Reichel
  0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2020-06-05 23:16 UTC (permalink / raw)
  To: Tobias Schramm; +Cc: Andy Shevchenko, linux-pm, kbuild test robot

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

Hi,

On Sat, May 30, 2020 at 07:00:47PM +0200, Tobias Schramm wrote:
> Hi Andy,
> 
> > diff --git a/drivers/power/supply/cw2015_battery.c b/drivers/power/supply/cw2015_battery.c
> > index 19f62ea957ee..0146f1bfc29b 100644
> > --- a/drivers/power/supply/cw2015_battery.c
> > +++ b/drivers/power/supply/cw2015_battery.c
> > @@ -734,6 +734,7 @@ MODULE_DEVICE_TABLE(of, cw2015_of_match);
> >  static struct i2c_driver cw_bat_driver = {
> >  	.driver = {
> >  		.name = "cw2015",
> > +		.of_match_table = cw2015_of_match,
> >  		.pm = &cw_bat_pm_ops,
> >  	},
> >  	.probe_new = cw_bat_probe,
> > 
> 
> LGTM.
> 
> Acked-By: Tobias Schramm <t.schramm@manjaro.org>
> Tested-By: Tobias Schramm <t.schramm@manjaro.org>

Thanks, queued.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-05 23:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-30 16:40 [PATCH v1] power: supply: cw2015: Attach OF ID table to the driver Andy Shevchenko
2020-05-30 17:00 ` Tobias Schramm
2020-06-05 23:16   ` Sebastian Reichel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.