* [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support
@ 2021-04-14 20:10 Peter Seiderer
2021-04-14 20:10 ` [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency Peter Seiderer
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Peter Seiderer @ 2021-04-14 20:10 UTC (permalink / raw)
To: buildroot
- needs protobuf-c (not protobuf)
- protobuf-c configure tests are not cross-compile capable, even with
ifeq ($(BR2_PACKAGE_PROTOBUF_C),y)
POSTGIS_DEPENDENCIES += protobuf-c
POSTGIS_CONF_OPTS += --with-protobuf
POSTGIS_CONF_ENV += \
ac_cv_lib_protobuf_c_protobuf_c_message_init=yes \
ac_cv_lib_protobuf_c_protobuf_c_version=yes
else
POSTGIS_CONF_OPTS += --without-protobuf
endif
configure aborts with:
checking for PROTOBUFC... yes
checking protobuf-c/protobuf-c.h usability... yes
checking protobuf-c/protobuf-c.h presence... yes
checking for protobuf-c/protobuf-c.h... yes
checking for protobuf_c_message_init in -lprotobuf-c... (cached) yes
checking for protobuf_c_version in -lprotobuf-c... (cached) yes
checking protobuf-c version... configure: error: in `.../build/postgis-3.1.1':
configure: error: cannot run test program while cross compiling
Fixes:
- http://autobuild.buildroot.net/results/8b95086b5e0876d0a4e41330446e767e4abd3729
checking for PROTOBUFC... no
libprotobuf-c not found in pkg-config
checking protobuf-c/protobuf-c.h usability... no
checking protobuf-c/protobuf-c.h presence... no
checking for protobuf-c/protobuf-c.h... no
configure: error: unable to find protobuf-c/protobuf-c.h using CPPFLAGS. You can disable MVT and Geobuf support using --without-protobuf
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/postgis/postgis.mk | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
index 1661f48ff2..92a9968993 100644
--- a/package/postgis/postgis.mk
+++ b/package/postgis/postgis.mk
@@ -18,7 +18,8 @@ POSTGIS_DEPENDENCIES = postgresql libgeos proj libxml2
POSTGIS_CONF_OPTS += \
--with-pgconfig=$(STAGING_DIR)/usr/bin/pg_config \
--with-geosconfig=$(STAGING_DIR)/usr/bin/geos-config \
- --with-xml2config=$(STAGING_DIR)/usr/bin/xml2-config
+ --with-xml2config=$(STAGING_DIR)/usr/bin/xml2-config \
+ --without-protobuf
ifeq ($(BR2_PACKAGE_LIBGDAL),y)
POSTGIS_DEPENDENCIES += libgdal
@@ -27,11 +28,4 @@ else
POSTGIS_CONF_OPTS += --without-raster
endif
-ifeq ($(BR2_PACKAGE_PROTOBUF),y)
-POSTGIS_DEPENDENCIES += protobuf
-POSTGIS_CONF_OPTS += --with-protobuf
-else
-POSTGIS_CONF_OPTS += --without-protobuf
-endif
-
$(eval $(autotools-package))
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency
2021-04-14 20:10 [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Peter Seiderer
@ 2021-04-14 20:10 ` Peter Seiderer
2021-04-15 4:31 ` Maxim Kochetkov
2021-04-14 20:10 ` [Buildroot] [PATCH v1 3/3] package/postgis: add optional pcre dependency Peter Seiderer
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Peter Seiderer @ 2021-04-14 20:10 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/postgis/postgis.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
index 92a9968993..5a2987b182 100644
--- a/package/postgis/postgis.mk
+++ b/package/postgis/postgis.mk
@@ -28,4 +28,11 @@ else
POSTGIS_CONF_OPTS += --without-raster
endif
+ifeq ($(BR2_PACKAGE_JSON_C),y)
+POSTGIS_DEPENDENCIES += json-c
+POSTGIS_CONF_OPTS += --with-json
+else
+POSTGIS_CONF_OPTS += --without-json
+endif
+
$(eval $(autotools-package))
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1 3/3] package/postgis: add optional pcre dependency
2021-04-14 20:10 [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Peter Seiderer
2021-04-14 20:10 ` [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency Peter Seiderer
@ 2021-04-14 20:10 ` Peter Seiderer
2021-04-15 4:31 ` Maxim Kochetkov
2021-04-15 4:30 ` [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Maxim Kochetkov
2021-04-15 19:17 ` Arnout Vandecappelle
3 siblings, 1 reply; 7+ messages in thread
From: Peter Seiderer @ 2021-04-14 20:10 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
package/postgis/postgis.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
index 5a2987b182..c6c1b8ff50 100644
--- a/package/postgis/postgis.mk
+++ b/package/postgis/postgis.mk
@@ -35,4 +35,8 @@ else
POSTGIS_CONF_OPTS += --without-json
endif
+ifeq ($(BR2_PACKAGE_PCRE),y)
+POSTGIS_DEPENDENCIES += pcre
+endif
+
$(eval $(autotools-package))
--
2.31.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support
2021-04-14 20:10 [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Peter Seiderer
2021-04-14 20:10 ` [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency Peter Seiderer
2021-04-14 20:10 ` [Buildroot] [PATCH v1 3/3] package/postgis: add optional pcre dependency Peter Seiderer
@ 2021-04-15 4:30 ` Maxim Kochetkov
2021-04-15 19:17 ` Arnout Vandecappelle
3 siblings, 0 replies; 7+ messages in thread
From: Maxim Kochetkov @ 2021-04-15 4:30 UTC (permalink / raw)
To: buildroot
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
14.04.2021 23:10, Peter Seiderer ?????:
> - needs protobuf-c (not protobuf)
> - protobuf-c configure tests are not cross-compile capable, even with
>
> ifeq ($(BR2_PACKAGE_PROTOBUF_C),y)
> POSTGIS_DEPENDENCIES += protobuf-c
> POSTGIS_CONF_OPTS += --with-protobuf
> POSTGIS_CONF_ENV += \
> ac_cv_lib_protobuf_c_protobuf_c_message_init=yes \
> ac_cv_lib_protobuf_c_protobuf_c_version=yes
> else
> POSTGIS_CONF_OPTS += --without-protobuf
> endif
>
> configure aborts with:
>
> checking for PROTOBUFC... yes
> checking protobuf-c/protobuf-c.h usability... yes
> checking protobuf-c/protobuf-c.h presence... yes
> checking for protobuf-c/protobuf-c.h... yes
> checking for protobuf_c_message_init in -lprotobuf-c... (cached) yes
> checking for protobuf_c_version in -lprotobuf-c... (cached) yes
> checking protobuf-c version... configure: error: in `.../build/postgis-3.1.1':
> configure: error: cannot run test program while cross compiling
>
> Fixes:
>
> - http://autobuild.buildroot.net/results/8b95086b5e0876d0a4e41330446e767e4abd3729
>
> checking for PROTOBUFC... no
> libprotobuf-c not found in pkg-config
> checking protobuf-c/protobuf-c.h usability... no
> checking protobuf-c/protobuf-c.h presence... no
> checking for protobuf-c/protobuf-c.h... no
> configure: error: unable to find protobuf-c/protobuf-c.h using CPPFLAGS. You can disable MVT and Geobuf support using --without-protobuf
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/postgis/postgis.mk | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
> index 1661f48ff2..92a9968993 100644
> --- a/package/postgis/postgis.mk
> +++ b/package/postgis/postgis.mk
> @@ -18,7 +18,8 @@ POSTGIS_DEPENDENCIES = postgresql libgeos proj libxml2
> POSTGIS_CONF_OPTS += \
> --with-pgconfig=$(STAGING_DIR)/usr/bin/pg_config \
> --with-geosconfig=$(STAGING_DIR)/usr/bin/geos-config \
> - --with-xml2config=$(STAGING_DIR)/usr/bin/xml2-config
> + --with-xml2config=$(STAGING_DIR)/usr/bin/xml2-config \
> + --without-protobuf
>
> ifeq ($(BR2_PACKAGE_LIBGDAL),y)
> POSTGIS_DEPENDENCIES += libgdal
> @@ -27,11 +28,4 @@ else
> POSTGIS_CONF_OPTS += --without-raster
> endif
>
> -ifeq ($(BR2_PACKAGE_PROTOBUF),y)
> -POSTGIS_DEPENDENCIES += protobuf
> -POSTGIS_CONF_OPTS += --with-protobuf
> -else
> -POSTGIS_CONF_OPTS += --without-protobuf
> -endif
> -
> $(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency
2021-04-14 20:10 ` [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency Peter Seiderer
@ 2021-04-15 4:31 ` Maxim Kochetkov
0 siblings, 0 replies; 7+ messages in thread
From: Maxim Kochetkov @ 2021-04-15 4:31 UTC (permalink / raw)
To: buildroot
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
14.04.2021 23:10, Peter Seiderer ?????:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/postgis/postgis.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
> index 92a9968993..5a2987b182 100644
> --- a/package/postgis/postgis.mk
> +++ b/package/postgis/postgis.mk
> @@ -28,4 +28,11 @@ else
> POSTGIS_CONF_OPTS += --without-raster
> endif
>
> +ifeq ($(BR2_PACKAGE_JSON_C),y)
> +POSTGIS_DEPENDENCIES += json-c
> +POSTGIS_CONF_OPTS += --with-json
> +else
> +POSTGIS_CONF_OPTS += --without-json
> +endif
> +
> $(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1 3/3] package/postgis: add optional pcre dependency
2021-04-14 20:10 ` [Buildroot] [PATCH v1 3/3] package/postgis: add optional pcre dependency Peter Seiderer
@ 2021-04-15 4:31 ` Maxim Kochetkov
0 siblings, 0 replies; 7+ messages in thread
From: Maxim Kochetkov @ 2021-04-15 4:31 UTC (permalink / raw)
To: buildroot
Reviewed-by: Maxim Kochetkov <fido_max@inbox.ru>
14.04.2021 23:10, Peter Seiderer ?????:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/postgis/postgis.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
> index 5a2987b182..c6c1b8ff50 100644
> --- a/package/postgis/postgis.mk
> +++ b/package/postgis/postgis.mk
> @@ -35,4 +35,8 @@ else
> POSTGIS_CONF_OPTS += --without-json
> endif
>
> +ifeq ($(BR2_PACKAGE_PCRE),y)
> +POSTGIS_DEPENDENCIES += pcre
> +endif
> +
> $(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support
2021-04-14 20:10 [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Peter Seiderer
` (2 preceding siblings ...)
2021-04-15 4:30 ` [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Maxim Kochetkov
@ 2021-04-15 19:17 ` Arnout Vandecappelle
3 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2021-04-15 19:17 UTC (permalink / raw)
To: buildroot
On 14/04/2021 22:10, Peter Seiderer wrote:
> - needs protobuf-c (not protobuf)
> - protobuf-c configure tests are not cross-compile capable, even with
It's a pity to disable it rather than fix it, but I guess it should be fixed by
someone who cares.
Series applied to master, thanks.
Regards,
Arnout
>
> ifeq ($(BR2_PACKAGE_PROTOBUF_C),y)
> POSTGIS_DEPENDENCIES += protobuf-c
> POSTGIS_CONF_OPTS += --with-protobuf
> POSTGIS_CONF_ENV += \
> ac_cv_lib_protobuf_c_protobuf_c_message_init=yes \
> ac_cv_lib_protobuf_c_protobuf_c_version=yes
> else
> POSTGIS_CONF_OPTS += --without-protobuf
> endif
>
> configure aborts with:
>
> checking for PROTOBUFC... yes
> checking protobuf-c/protobuf-c.h usability... yes
> checking protobuf-c/protobuf-c.h presence... yes
> checking for protobuf-c/protobuf-c.h... yes
> checking for protobuf_c_message_init in -lprotobuf-c... (cached) yes
> checking for protobuf_c_version in -lprotobuf-c... (cached) yes
> checking protobuf-c version... configure: error: in `.../build/postgis-3.1.1':
> configure: error: cannot run test program while cross compiling
>
> Fixes:
>
> - http://autobuild.buildroot.net/results/8b95086b5e0876d0a4e41330446e767e4abd3729
>
> checking for PROTOBUFC... no
> libprotobuf-c not found in pkg-config
> checking protobuf-c/protobuf-c.h usability... no
> checking protobuf-c/protobuf-c.h presence... no
> checking for protobuf-c/protobuf-c.h... no
> configure: error: unable to find protobuf-c/protobuf-c.h using CPPFLAGS. You can disable MVT and Geobuf support using --without-protobuf
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> package/postgis/postgis.mk | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/package/postgis/postgis.mk b/package/postgis/postgis.mk
> index 1661f48ff2..92a9968993 100644
> --- a/package/postgis/postgis.mk
> +++ b/package/postgis/postgis.mk
> @@ -18,7 +18,8 @@ POSTGIS_DEPENDENCIES = postgresql libgeos proj libxml2
> POSTGIS_CONF_OPTS += \
> --with-pgconfig=$(STAGING_DIR)/usr/bin/pg_config \
> --with-geosconfig=$(STAGING_DIR)/usr/bin/geos-config \
> - --with-xml2config=$(STAGING_DIR)/usr/bin/xml2-config
> + --with-xml2config=$(STAGING_DIR)/usr/bin/xml2-config \
> + --without-protobuf
>
> ifeq ($(BR2_PACKAGE_LIBGDAL),y)
> POSTGIS_DEPENDENCIES += libgdal
> @@ -27,11 +28,4 @@ else
> POSTGIS_CONF_OPTS += --without-raster
> endif
>
> -ifeq ($(BR2_PACKAGE_PROTOBUF),y)
> -POSTGIS_DEPENDENCIES += protobuf
> -POSTGIS_CONF_OPTS += --with-protobuf
> -else
> -POSTGIS_CONF_OPTS += --without-protobuf
> -endif
> -
> $(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-15 19:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 20:10 [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Peter Seiderer
2021-04-14 20:10 ` [Buildroot] [PATCH v1 2/3] package/postgis: add optional json-c dependency Peter Seiderer
2021-04-15 4:31 ` Maxim Kochetkov
2021-04-14 20:10 ` [Buildroot] [PATCH v1 3/3] package/postgis: add optional pcre dependency Peter Seiderer
2021-04-15 4:31 ` Maxim Kochetkov
2021-04-15 4:30 ` [Buildroot] [PATCH v1 1/3] package/postgis: disable protobuf support Maxim Kochetkov
2021-04-15 19:17 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.