* [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
@ 2017-04-06 5:21 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-04-06 5:21 UTC (permalink / raw)
To: Archit Taneja, Neil Armstrong
Cc: David Airlie, Laurent Pinchart, Jose Abreu, Daniel Vetter,
Kieran Bingham, dri-devel, kernel-janitors
There was supposed to be a break before the next case statement.
Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 84cc949eae2b..8b605039c613 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
frame.extended_colorimetry HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
+ break;
case V4L2_YCBCR_ENC_709:
if (hdmi->hdmi_data.enc_in_encoding = V4L2_YCBCR_ENC_XV709)
frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
@ 2017-04-06 5:21 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2017-04-06 5:21 UTC (permalink / raw)
To: Archit Taneja, Neil Armstrong
Cc: David Airlie, Laurent Pinchart, Jose Abreu, Daniel Vetter,
Kieran Bingham, dri-devel, kernel-janitors
There was supposed to be a break before the next case statement.
Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 84cc949eae2b..8b605039c613 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
frame.extended_colorimetry =
HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
+ break;
case V4L2_YCBCR_ENC_709:
if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
2017-04-06 5:21 ` Dan Carpenter
@ 2017-04-06 7:41 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-04-06 7:41 UTC (permalink / raw)
To: Dan Carpenter, Archit Taneja
Cc: David Airlie, Laurent Pinchart, Jose Abreu, Daniel Vetter,
Kieran Bingham, dri-devel, kernel-janitors
On 04/06/2017 07:21 AM, Dan Carpenter wrote:
> There was supposed to be a break before the next case statement.
>
> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 84cc949eae2b..8b605039c613 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
> frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
> frame.extended_colorimetry > HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> + break;
> case V4L2_YCBCR_ENC_709:
> if (hdmi->hdmi_data.enc_in_encoding = V4L2_YCBCR_ENC_XV709)
> frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
>
Thanks for the fix !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
@ 2017-04-06 7:41 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-04-06 7:41 UTC (permalink / raw)
To: Dan Carpenter, Archit Taneja
Cc: David Airlie, Laurent Pinchart, Jose Abreu, Daniel Vetter,
Kieran Bingham, dri-devel, kernel-janitors
On 04/06/2017 07:21 AM, Dan Carpenter wrote:
> There was supposed to be a break before the next case statement.
>
> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 84cc949eae2b..8b605039c613 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
> frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
> frame.extended_colorimetry =
> HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
> + break;
> case V4L2_YCBCR_ENC_709:
> if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
> frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
>
Thanks for the fix !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
2017-04-06 7:41 ` Neil Armstrong
@ 2017-04-06 8:58 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-04-06 8:58 UTC (permalink / raw)
To: Dan Carpenter, Archit Taneja
Cc: Jose Abreu, Laurent Pinchart, Daniel Vetter, kernel-janitors,
dri-devel, Kieran Bingham
On 04/06/2017 09:41 AM, Neil Armstrong wrote:
> On 04/06/2017 07:21 AM, Dan Carpenter wrote:
>> There was supposed to be a break before the next case statement.
>>
>> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> index 84cc949eae2b..8b605039c613 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
>> frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
>> frame.extended_colorimetry >> HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
>> + break;
>> case V4L2_YCBCR_ENC_709:
>> if (hdmi->hdmi_data.enc_in_encoding = V4L2_YCBCR_ENC_XV709)
>> frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
>>
>
> Thanks for the fix !
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
Applied to drm-misc-next
Thanks,
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm: bridge: dw-hdmi: Add a missing break statement
@ 2017-04-06 8:58 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2017-04-06 8:58 UTC (permalink / raw)
To: Dan Carpenter, Archit Taneja
Cc: Jose Abreu, Laurent Pinchart, Daniel Vetter, kernel-janitors,
dri-devel, Kieran Bingham
On 04/06/2017 09:41 AM, Neil Armstrong wrote:
> On 04/06/2017 07:21 AM, Dan Carpenter wrote:
>> There was supposed to be a break before the next case statement.
>>
>> Fixes: def23aa7e982 ("drm: bridge: dw-hdmi: Switch to V4L bus format and encodings")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> index 84cc949eae2b..8b605039c613 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> @@ -1318,6 +1318,7 @@ static void hdmi_config_AVI(struct dw_hdmi *hdmi, struct drm_display_mode *mode)
>> frame.colorimetry = HDMI_COLORIMETRY_ITU_601;
>> frame.extended_colorimetry =
>> HDMI_EXTENDED_COLORIMETRY_XV_YCC_601;
>> + break;
>> case V4L2_YCBCR_ENC_709:
>> if (hdmi->hdmi_data.enc_in_encoding == V4L2_YCBCR_ENC_XV709)
>> frame.colorimetry = HDMI_COLORIMETRY_EXTENDED;
>>
>
> Thanks for the fix !
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
Applied to drm-misc-next
Thanks,
Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-06 8:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06 5:21 [PATCH] drm: bridge: dw-hdmi: Add a missing break statement Dan Carpenter
2017-04-06 5:21 ` Dan Carpenter
2017-04-06 7:41 ` Neil Armstrong
2017-04-06 7:41 ` Neil Armstrong
2017-04-06 8:58 ` Neil Armstrong
2017-04-06 8:58 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.