From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Roman Bolshakov <r.bolshakov@yadro.com>,
Cameron Esfahani <dirty@apple.com>,
Kamil Rytarowski <kamil@netbsd.org>,
Reinoud Zandijk <reinoud@netbsd.org>,
Colin Xu <colin.xu@intel.com>,
haxm-team@intel.com, Sunil Muthuswamy <sunilmut@microsoft.com>,
Wenchao Wang <wenchao.wang@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: Include 'hw/i386/apic.h' locally
Date: Wed, 29 Sep 2021 17:16:50 +0200 [thread overview]
Message-ID: <6fa5f79c-8d3b-9534-26d6-ebe1ba937491@vivier.eu> (raw)
In-Reply-To: <f9e3c54f-a7cb-a043-f7fd-9d9d0dd61c16@vivier.eu>
Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
>> On 9/16/21 00:05, Paolo Bonzini wrote:
>>> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
>>>> Instead of including a sysemu-specific header in "cpu.h"
>>>> (which is shared with user-mode emulations), include it
>>>> locally when required.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thank you, Cc'ing qemu-trivial@ :)
>>
>
> Applied to my trivial-patches branch.
>
We have a problem:
.../target/i386/tcg/sysemu/seg_helper.c:145:9: error: implicit declaration of function
'apic_poll_irq' [-Werror=implicit-function-declaration]
145 | apic_poll_irq(cpu->apic_state);
| ^~~~~~~~~~~~~
.../target/i386/tcg/sysemu/seg_helper.c:145:9: error: nested extern declaration of 'apic_poll_irq'
[-Werror=nested-externs]
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>,
Kamil Rytarowski <kamil@netbsd.org>,
Cameron Esfahani <dirty@apple.com>,
qemu-devel@nongnu.org, Roman Bolshakov <r.bolshakov@yadro.com>,
Reinoud Zandijk <reinoud@netbsd.org>,
Colin Xu <colin.xu@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
haxm-team@intel.com, Sunil Muthuswamy <sunilmut@microsoft.com>,
Wenchao Wang <wenchao.wang@intel.com>
Subject: Re: [PATCH] target/i386: Include 'hw/i386/apic.h' locally
Date: Wed, 29 Sep 2021 17:16:50 +0200 [thread overview]
Message-ID: <6fa5f79c-8d3b-9534-26d6-ebe1ba937491@vivier.eu> (raw)
In-Reply-To: <f9e3c54f-a7cb-a043-f7fd-9d9d0dd61c16@vivier.eu>
Le 29/09/2021 à 17:00, Laurent Vivier a écrit :
> Le 29/09/2021 à 16:08, Philippe Mathieu-Daudé a écrit :
>> On 9/16/21 00:05, Paolo Bonzini wrote:
>>> On 02/09/21 17:22, Philippe Mathieu-Daudé wrote:
>>>> Instead of including a sysemu-specific header in "cpu.h"
>>>> (which is shared with user-mode emulations), include it
>>>> locally when required.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Thank you, Cc'ing qemu-trivial@ :)
>>
>
> Applied to my trivial-patches branch.
>
We have a problem:
.../target/i386/tcg/sysemu/seg_helper.c:145:9: error: implicit declaration of function
'apic_poll_irq' [-Werror=implicit-function-declaration]
145 | apic_poll_irq(cpu->apic_state);
| ^~~~~~~~~~~~~
.../target/i386/tcg/sysemu/seg_helper.c:145:9: error: nested extern declaration of 'apic_poll_irq'
[-Werror=nested-externs]
next prev parent reply other threads:[~2021-09-29 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 15:22 [PATCH] target/i386: Include 'hw/i386/apic.h' locally Philippe Mathieu-Daudé
2021-09-02 15:22 ` Philippe Mathieu-Daudé
2021-09-15 14:36 ` Philippe Mathieu-Daudé
2021-09-15 14:36 ` Philippe Mathieu-Daudé
2021-09-15 22:05 ` Paolo Bonzini
2021-09-15 22:05 ` Paolo Bonzini
2021-09-29 14:08 ` Philippe Mathieu-Daudé
2021-09-29 14:08 ` Philippe Mathieu-Daudé
2021-09-29 15:00 ` Laurent Vivier
2021-09-29 15:00 ` Laurent Vivier
2021-09-29 15:16 ` Laurent Vivier [this message]
2021-09-29 15:16 ` Laurent Vivier
2021-09-29 16:06 ` Philippe Mathieu-Daudé
2021-09-29 16:06 ` Philippe Mathieu-Daudé
2021-09-29 16:23 ` Laurent Vivier
2021-09-29 16:23 ` Laurent Vivier
2021-09-29 16:29 ` Philippe Mathieu-Daudé
2021-09-29 16:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa5f79c-8d3b-9534-26d6-ebe1ba937491@vivier.eu \
--to=laurent@vivier.eu \
--cc=colin.xu@intel.com \
--cc=dirty@apple.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=haxm-team@intel.com \
--cc=kamil@netbsd.org \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=r.bolshakov@yadro.com \
--cc=reinoud@netbsd.org \
--cc=richard.henderson@linaro.org \
--cc=sunilmut@microsoft.com \
--cc=wenchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.