From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>, kernel test robot <lkp@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Mark Brown <broonie@kernel.org>,
James Clark <james.clark@arm.com>, Rob Herring <robh@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V8 5/6] arm64/perf: Add branch stack support in ARMV8 PMU
Date: Thu, 9 Feb 2023 08:18:11 +0530 [thread overview]
Message-ID: <6fd66a78-6c18-3b61-483b-0e821082aaac@arm.com> (raw)
In-Reply-To: <Y+QA0tRk2VVJ4gwu@FVFF77S0Q05N.cambridge.arm.com>
On 2/9/23 01:36, Mark Rutland wrote:
> On Mon, Feb 06, 2023 at 09:46:25AM +0530, Anshuman Khandual wrote:
>> On 2/3/23 17:01, Will Deacon wrote:
>>> On Tue, Jan 31, 2023 at 12:28:17AM +0800, kernel test robot wrote:
>
> [...]
>
>>> This looks like it should be fixed. I'd also like to see Mark's ack on the
>>
>> This build warning is triggered when CONFIG_PERF_EVENTS is not enabled, when
>> all the fallback stubs in there try to use has_branch_stack() which does not
>> get defined. The following change, fixes the problem.
>
> I expect that you'll post a v9 with that folded in, and I've just made some
> comments on v7 which I expect will require some changes, so I'm going to wait
> for v9 for further review to keep this manageable.
Sure, will work on a V9 and post when ready.
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <will@kernel.org>, kernel test robot <lkp@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Mark Brown <broonie@kernel.org>,
James Clark <james.clark@arm.com>, Rob Herring <robh@kernel.org>,
Marc Zyngier <maz@kernel.org>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V8 5/6] arm64/perf: Add branch stack support in ARMV8 PMU
Date: Thu, 9 Feb 2023 08:18:11 +0530 [thread overview]
Message-ID: <6fd66a78-6c18-3b61-483b-0e821082aaac@arm.com> (raw)
In-Reply-To: <Y+QA0tRk2VVJ4gwu@FVFF77S0Q05N.cambridge.arm.com>
On 2/9/23 01:36, Mark Rutland wrote:
> On Mon, Feb 06, 2023 at 09:46:25AM +0530, Anshuman Khandual wrote:
>> On 2/3/23 17:01, Will Deacon wrote:
>>> On Tue, Jan 31, 2023 at 12:28:17AM +0800, kernel test robot wrote:
>
> [...]
>
>>> This looks like it should be fixed. I'd also like to see Mark's ack on the
>>
>> This build warning is triggered when CONFIG_PERF_EVENTS is not enabled, when
>> all the fallback stubs in there try to use has_branch_stack() which does not
>> get defined. The following change, fixes the problem.
>
> I expect that you'll post a v9 with that folded in, and I've just made some
> comments on v7 which I expect will require some changes, so I'm going to wait
> for v9 for further review to keep this manageable.
Sure, will work on a V9 and post when ready.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-09 2:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 12:59 [PATCH V8 0/6] arm64/perf: Enable branch stack sampling Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
2023-01-23 12:59 ` [PATCH V8 1/6] drivers: perf: arm_pmu: Add new sched_task() callback Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
2023-01-23 12:59 ` [PATCH V8 2/6] arm64/perf: Add BRBE registers and fields Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
2023-01-23 12:59 ` [PATCH V8 3/6] arm64/perf: Add branch stack support in struct arm_pmu Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
2023-01-23 12:59 ` [PATCH V8 4/6] arm64/perf: Add branch stack support in struct pmu_hw_events Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
2023-01-23 12:59 ` [PATCH V8 5/6] arm64/perf: Add branch stack support in ARMV8 PMU Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
2023-01-30 16:28 ` kernel test robot
2023-01-30 16:28 ` kernel test robot
2023-02-03 11:31 ` Will Deacon
2023-02-03 11:31 ` Will Deacon
2023-02-06 4:16 ` Anshuman Khandual
2023-02-06 4:16 ` Anshuman Khandual
2023-02-08 20:06 ` Mark Rutland
2023-02-08 20:06 ` Mark Rutland
2023-02-09 2:48 ` Anshuman Khandual [this message]
2023-02-09 2:48 ` Anshuman Khandual
2023-01-23 12:59 ` [PATCH V8 6/6] arm64/perf: Enable branch stack events via FEAT_BRBE Anshuman Khandual
2023-01-23 12:59 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fd66a78-6c18-3b61-483b-0e821082aaac@arm.com \
--to=anshuman.khandual@arm.com \
--cc=acme@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.clark@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.