Re: [PATCH v2 2/3] ARM: dts: stm32: add STM32MP1-based Phytec SoM

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Steffen,

On 16.05.22 14:16, Steffen Trumtrar wrote:
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		retram: retram@38000000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x38000000 0x10000>;
> +			no-map;
> +		};
> +
> +		mcuram: mcuram@30000000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x30000000 0x40000>;
> +			no-map;
> +		};
> +
> +		mcuram2: mcuram2@10000000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x10000000 0x40000>;
> +			no-map;

Is this intended? Or do you want to use SRAM fully
from e.g. userspace?

> +&uart4 {
> +	pinctrl-names = "default", "sleep", "idle";
> +	pinctrl-0 = <&uart4_pins_a>;
> +	pinctrl-1 = <&uart4_sleep_pins_a>;
> +	pinctrl-2 = <&uart4_idle_pins_a>;
> +	pinctrl-3 = <&uart4_pins_a>;
> +	status = "okay";
> +};

As you are using uart4 as the Linux console, you'll need to:

  /delete-property/dmas;     
  /delete-property/dma-names;

because the STM32 UART driver doesn't support DMA for the console
and dma properties have been added into the SoC dtsi in
v5.18-rc1, commit:

  0f18f728ba62 ("ARM: dts: stm32: add DMA configuration to UART nodes on stm32mp151")

Cheers,
Ahmad

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel