All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
To: Marcin Wojtas <mw@semihalf.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Cc: davem@davemloft.net, linux@arm.linux.org.uk, andrew@lunn.ch,
	f.fainelli@gmail.com, antoine.tenart@free-electrons.com,
	thomas.petazzoni@free-electrons.com,
	gregory.clement@free-electrons.com,
	ezequiel.garcia@free-electrons.com, nadavh@marvell.com,
	neta@marvell.com, ard.biesheuvel@linaro.org, jaz@semihalf.com,
	tn@semihalf.com
Subject: Re: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support
Date: Mon, 18 Dec 2017 15:09:59 +0100	[thread overview]
Message-ID: <7060d587-48c1-6553-a3b8-e340e745234f@intel.com> (raw)
In-Reply-To: <1513588684-15647-1-git-send-email-mw@semihalf.com>

On 12/18/2017 10:17 AM, Marcin Wojtas wrote:
> Hi,
>
> This patchset introduces ACPI support in mvpp2 and mvmdio drivers.
> First three patches introduce fwnode helpers for obtaining PHY
> information from nodes and also MDIO fwnode API for registering
> the bus with its PHY/devices.
>
> Following patches update code of the mvmdio and mvpp2 drivers
> to support ACPI tables handling. The latter is done in 4 steps,
> as can be seen in the commits. For the details, please
> refer to the commit messages.
>
> Drivers operation was tested on top of the net-next branch
> with both DT and ACPI. Although for compatibility reasons
> with older platforms, the mvmdio driver keeps using
> of_ MDIO registering, new fwnode_ one proved to fully work
> with DT as well (tested on MacchiatoBin board).
>
> mvpp2/mvmdio driver can work with the ACPI representation, as exposed
> on a public branch:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/marvell-armada-wip
> It was compiled together with the most recent Tianocore EDK2 revision.
> Please refer to the firmware build instruction on MacchiatoBin board:
> http://wiki.macchiatobin.net/tiki-index.php?page=Build+from+source+-+UEFI+EDK+II
>
> Above support configures 1G to use its PHY normally. 10G can work now
> only with the link interrupt mode. Somehow reading of the
> string property in fwnode_mdiobus_child_is_phy works only with
> DT and cannot cope with 10G PHY nodes as in:
> https://pastebin.com/3JnYpU0A
>
> Above root cause will be further checked. In the meantime I will
> appreciate any comments or remarks for the kernel patches.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (8):
>    device property: Introduce fwnode_get_mac_address()
>    device property: Introduce fwnode_get_phy_mode()
>    mdio_bus: Introduce fwnode MDIO helpers
>    net: mvmdio: add ACPI support
>    net: mvpp2: simplify maintaining enabled ports' list
>    net: mvpp2: use device_*/fwnode_* APIs instead of of_*
>    net: mvpp2: handle PHY with its fwnode
>    net: mvpp2: enable ACPI support in the driver
>
>   drivers/base/property.c               |  52 +++--
>   drivers/net/ethernet/marvell/mvmdio.c |  42 +++-
>   drivers/net/ethernet/marvell/mvpp2.c  | 246 ++++++++++++--------
>   drivers/net/phy/mdio_bus.c            | 218 +++++++++++++++++
>   include/linux/mdio.h                  |   3 +
>   include/linux/property.h              |   3 +
>   6 files changed, 454 insertions(+), 110 deletions(-)
>
Please CC linux-acpi on all submissions of patches touching ACPI, 
property.c or property.h.

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: rafael.j.wysocki@intel.com (Rafael J. Wysocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support
Date: Mon, 18 Dec 2017 15:09:59 +0100	[thread overview]
Message-ID: <7060d587-48c1-6553-a3b8-e340e745234f@intel.com> (raw)
In-Reply-To: <1513588684-15647-1-git-send-email-mw@semihalf.com>

On 12/18/2017 10:17 AM, Marcin Wojtas wrote:
> Hi,
>
> This patchset introduces ACPI support in mvpp2 and mvmdio drivers.
> First three patches introduce fwnode helpers for obtaining PHY
> information from nodes and also MDIO fwnode API for registering
> the bus with its PHY/devices.
>
> Following patches update code of the mvmdio and mvpp2 drivers
> to support ACPI tables handling. The latter is done in 4 steps,
> as can be seen in the commits. For the details, please
> refer to the commit messages.
>
> Drivers operation was tested on top of the net-next branch
> with both DT and ACPI. Although for compatibility reasons
> with older platforms, the mvmdio driver keeps using
> of_ MDIO registering, new fwnode_ one proved to fully work
> with DT as well (tested on MacchiatoBin board).
>
> mvpp2/mvmdio driver can work with the ACPI representation, as exposed
> on a public branch:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/marvell-armada-wip
> It was compiled together with the most recent Tianocore EDK2 revision.
> Please refer to the firmware build instruction on MacchiatoBin board:
> http://wiki.macchiatobin.net/tiki-index.php?page=Build+from+source+-+UEFI+EDK+II
>
> Above support configures 1G to use its PHY normally. 10G can work now
> only with the link interrupt mode. Somehow reading of the
> string property in fwnode_mdiobus_child_is_phy works only with
> DT and cannot cope with 10G PHY nodes as in:
> https://pastebin.com/3JnYpU0A
>
> Above root cause will be further checked. In the meantime I will
> appreciate any comments or remarks for the kernel patches.
>
> Best regards,
> Marcin
>
> Marcin Wojtas (8):
>    device property: Introduce fwnode_get_mac_address()
>    device property: Introduce fwnode_get_phy_mode()
>    mdio_bus: Introduce fwnode MDIO helpers
>    net: mvmdio: add ACPI support
>    net: mvpp2: simplify maintaining enabled ports' list
>    net: mvpp2: use device_*/fwnode_* APIs instead of of_*
>    net: mvpp2: handle PHY with its fwnode
>    net: mvpp2: enable ACPI support in the driver
>
>   drivers/base/property.c               |  52 +++--
>   drivers/net/ethernet/marvell/mvmdio.c |  42 +++-
>   drivers/net/ethernet/marvell/mvpp2.c  | 246 ++++++++++++--------
>   drivers/net/phy/mdio_bus.c            | 218 +++++++++++++++++
>   include/linux/mdio.h                  |   3 +
>   include/linux/property.h              |   3 +
>   6 files changed, 454 insertions(+), 110 deletions(-)
>
Please CC linux-acpi on all submissions of patches touching ACPI, 
property.c or property.h.

Thanks!

  parent reply	other threads:[~2017-12-18 14:10 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-18  9:17 [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support Marcin Wojtas
2017-12-18  9:17 ` Marcin Wojtas
2017-12-18  9:17 ` Marcin Wojtas
2017-12-18  9:17 ` [net-next: PATCH 1/8] device property: Introduce fwnode_get_mac_address() Marcin Wojtas
2017-12-18  9:17   ` Marcin Wojtas
2017-12-18  9:17   ` Marcin Wojtas
2017-12-18  9:17 ` [net-next: PATCH 2/8] device property: Introduce fwnode_get_phy_mode() Marcin Wojtas
2017-12-18  9:17   ` Marcin Wojtas
2017-12-18  9:17 ` [net-next: PATCH 3/8] mdio_bus: Introduce fwnode MDIO helpers Marcin Wojtas
2017-12-18  9:17   ` Marcin Wojtas
2017-12-18  9:17   ` Marcin Wojtas
2017-12-18  9:18 ` [net-next: PATCH 4/8] net: mvmdio: add ACPI support Marcin Wojtas
2017-12-18  9:18   ` Marcin Wojtas
2017-12-18  9:18 ` [net-next: PATCH 5/8] net: mvpp2: simplify maintaining enabled ports' list Marcin Wojtas
2017-12-18  9:18   ` Marcin Wojtas
2017-12-18  9:18   ` Marcin Wojtas
2017-12-18  9:18 ` [net-next: PATCH 6/8] net: mvpp2: use device_*/fwnode_* APIs instead of of_* Marcin Wojtas
2017-12-18  9:18   ` Marcin Wojtas
2017-12-18  9:18 ` [net-next: PATCH 7/8] net: mvpp2: handle PHY with its fwnode Marcin Wojtas
2017-12-18  9:18   ` Marcin Wojtas
2017-12-18  9:18 ` [net-next: PATCH 8/8] net: mvpp2: enable ACPI support in the driver Marcin Wojtas
2017-12-18  9:18   ` Marcin Wojtas
2017-12-18  9:40 ` [net-next: PATCH 0/8] Armada 7k/8k PP2 ACPI support Ard Biesheuvel
2017-12-18  9:40   ` Ard Biesheuvel
2017-12-18 15:49   ` Marcin Wojtas
2017-12-18 15:49     ` Marcin Wojtas
2017-12-18 15:49     ` Marcin Wojtas
2018-01-03 11:00   ` Graeme Gregory
2018-01-03 11:00     ` Graeme Gregory
2018-01-03 11:00     ` Graeme Gregory
2018-01-03 11:12     ` Marcin Wojtas
2018-01-03 11:12       ` Marcin Wojtas
2018-01-03 11:12       ` Marcin Wojtas
2018-01-03 12:47       ` Andrew Lunn
2018-01-03 12:47         ` Andrew Lunn
2018-01-03 12:47         ` Andrew Lunn
2018-01-03 13:13         ` Marcin Wojtas
2018-01-03 13:13           ` Marcin Wojtas
2018-01-03 13:13           ` Marcin Wojtas
2018-01-03 13:33           ` Andrew Lunn
2018-01-03 13:33             ` Andrew Lunn
2018-01-03 13:33             ` Andrew Lunn
2018-01-03 13:36             ` Marcin Wojtas
2018-01-03 13:36               ` Marcin Wojtas
2018-01-03 13:36               ` Marcin Wojtas
2018-01-04 16:09       ` Graeme Gregory
2018-01-04 16:09         ` Graeme Gregory
2018-01-04 16:09         ` Graeme Gregory
2018-01-04 16:20         ` Andrew Lunn
2018-01-04 16:20           ` Andrew Lunn
2018-01-04 16:20           ` Andrew Lunn
2018-01-08 14:45           ` Graeme Gregory
2018-01-08 14:45             ` Graeme Gregory
2018-01-08 14:45             ` Graeme Gregory
2018-01-08 14:53             ` Andrew Lunn
2018-01-08 14:53               ` Andrew Lunn
2018-01-08 14:53               ` Andrew Lunn
2018-01-08 15:14               ` Graeme Gregory
2018-01-08 15:14                 ` Graeme Gregory
2018-01-08 15:14                 ` Graeme Gregory
2018-01-08 15:42                 ` Andrew Lunn
2018-01-08 15:42                   ` Andrew Lunn
2018-01-08 15:42                   ` Andrew Lunn
2018-01-08 17:17                   ` Marcin Wojtas
2018-01-08 17:17                     ` Marcin Wojtas
2018-01-08 17:17                     ` Marcin Wojtas
2018-01-09 10:19                     ` Graeme Gregory
2018-01-09 10:19                       ` Graeme Gregory
2018-01-09 10:19                       ` Graeme Gregory
2018-01-09 10:22                       ` Marcin Wojtas
2018-01-09 10:22                         ` Marcin Wojtas
2018-01-09 10:22                         ` Marcin Wojtas
2018-01-09 13:00                         ` Andrew Lunn
2018-01-09 13:00                           ` Andrew Lunn
2018-01-09 13:00                           ` Andrew Lunn
2018-01-18 12:31                           ` Lorenzo Pieralisi
2018-01-18 12:31                             ` Lorenzo Pieralisi
2018-01-18 12:31                             ` Lorenzo Pieralisi
2018-01-18 12:31                             ` Lorenzo Pieralisi
2018-01-18 13:00                             ` Andrew Lunn
2018-01-18 13:00                               ` Andrew Lunn
2018-01-18 13:00                               ` Andrew Lunn
2018-01-18 13:00                               ` Andrew Lunn
2018-01-19 18:07                               ` Marcin Wojtas
2018-01-19 18:07                                 ` Marcin Wojtas
2018-01-19 18:07                                 ` Marcin Wojtas
2018-01-19 18:07                                 ` Marcin Wojtas
2018-01-19 18:53                                 ` Andrew Lunn
2018-01-19 18:53                                   ` Andrew Lunn
2018-01-19 18:53                                   ` Andrew Lunn
2018-01-19 18:53                                   ` Andrew Lunn
2018-01-20 19:52                                 ` Mika Westerberg
2018-01-20 19:52                                   ` Mika Westerberg
2018-01-20 19:52                                   ` Mika Westerberg
2018-01-21  1:08                                   ` Andrew Lunn
2018-01-21  1:08                                     ` Andrew Lunn
2018-01-21  1:08                                     ` Andrew Lunn
2018-01-21  1:08                                     ` Andrew Lunn
2018-01-21 10:27                                     ` Mika Westerberg
2018-01-21 10:27                                       ` Mika Westerberg
2018-01-21 10:27                                       ` Mika Westerberg
2018-01-21 10:27                                       ` Mika Westerberg
2018-01-21 16:13                                       ` Andrew Lunn
2018-01-21 16:13                                         ` Andrew Lunn
2018-01-21 16:13                                         ` Andrew Lunn
2018-01-21 16:13                                         ` Andrew Lunn
2018-01-21 17:13                                         ` Ard Biesheuvel
2018-01-21 17:13                                           ` Ard Biesheuvel
2018-01-21 17:13                                           ` Ard Biesheuvel
2018-01-21 17:13                                           ` Ard Biesheuvel
2018-01-21 18:55                                           ` Andrew Lunn
2018-01-21 18:55                                             ` Andrew Lunn
2018-01-21 18:55                                             ` Andrew Lunn
2018-01-21 18:55                                             ` Andrew Lunn
2017-12-18 14:09 ` Rafael J. Wysocki [this message]
2017-12-18 14:09   ` Rafael J. Wysocki
2017-12-19 18:48 ` David Miller
2017-12-19 18:48   ` David Miller
2017-12-19 18:59   ` Marcin Wojtas
2017-12-19 18:59     ` Marcin Wojtas
2017-12-19 20:46     ` Andrew Lunn
2017-12-19 20:46       ` Andrew Lunn
2017-12-19 23:13       ` Marcin Wojtas
2017-12-19 23:13         ` Marcin Wojtas
2017-12-21 19:21 ` Antoine Tenart
2017-12-21 19:21   ` Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7060d587-48c1-6553-a3b8-e340e745234f@intel.com \
    --to=rafael.j.wysocki@intel.com \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@free-electrons.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=davem@davemloft.net \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jaz@semihalf.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=neta@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tn@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.