All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] unicore32: Fix build error
@ 2014-08-10 15:29 Guenter Roeck
  2014-08-10 15:39 ` Richard Weinberger
  2014-08-15 19:38 ` Guenter Roeck
  0 siblings, 2 replies; 8+ messages in thread
From: Guenter Roeck @ 2014-08-10 15:29 UTC (permalink / raw)
  To: Guan Xuetao; +Cc: linux-kernel, Guenter Roeck, Richard Weinberger

unicore32 builds fail with

arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
arch/unicore32/kernel/signal.c:257: error:
			‘usig’ undeclared (first use in this function)
arch/unicore32/kernel/signal.c:279: error:
			‘usig’ undeclared (first use in this function)
arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
arch/unicore32/kernel/signal.c: In function ‘do_signal’:
arch/unicore32/kernel/signal.c:376: error:
			implicit declaration of function ‘get_signsl’
make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
make: *** [arch/unicore32/kernel/signal.o] Error 2

Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
signal_setup_done()").

This code never even compiled. Reverting the patch does not work,
since previously used functions no longer exist, so try to fix it up.
Compile tested only.

Cc: Richard Weinberger <richard@nod.at>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/unicore32/kernel/signal.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/unicore32/kernel/signal.c b/arch/unicore32/kernel/signal.c
index 780d773..7c8fb70 100644
--- a/arch/unicore32/kernel/signal.c
+++ b/arch/unicore32/kernel/signal.c
@@ -254,7 +254,8 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set,
 
 	err |= setup_sigframe(frame, regs, set);
 	if (err == 0)
-		err |= setup_return(regs, &ksig->ka, frame->retcode, frame, usig);
+		err |= setup_return(regs, &ksig->ka, frame->retcode, frame,
+				    ksig->sig);
 
 	return err;
 }
@@ -276,7 +277,8 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set,
 	err |= __save_altstack(&frame->sig.uc.uc_stack, regs->UCreg_sp);
 	err |= setup_sigframe(&frame->sig, regs, set);
 	if (err == 0)
-		err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame, usig);
+		err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame,
+				    ksig->sig);
 
 	if (err == 0) {
 		/*
@@ -303,7 +305,6 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs,
 			  int syscall)
 {
 	struct thread_info *thread = current_thread_info();
-	struct task_struct *tsk = current;
 	sigset_t *oldset = sigmask_to_save();
 	int usig = ksig->sig;
 	int ret;
@@ -373,7 +374,7 @@ static void do_signal(struct pt_regs *regs, int syscall)
 	if (!user_mode(regs))
 		return;
 
-	if (get_signsl(&ksig)) {
+	if (get_signal(&ksig)) {
 		handle_signal(&ksig, regs, syscall);
 		return;
 	}
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] unicore32: Fix build error
  2014-08-10 15:29 [PATCH] unicore32: Fix build error Guenter Roeck
@ 2014-08-10 15:39 ` Richard Weinberger
  2014-08-10 16:30   ` Guenter Roeck
  2014-08-15 19:38 ` Guenter Roeck
  1 sibling, 1 reply; 8+ messages in thread
From: Richard Weinberger @ 2014-08-10 15:39 UTC (permalink / raw)
  To: Guenter Roeck, Guan Xuetao; +Cc: linux-kernel

Guenther,

Am 10.08.2014 17:29, schrieb Guenter Roeck:
> unicore32 builds fail with
> 
> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
> arch/unicore32/kernel/signal.c:257: error:
> 			‘usig’ undeclared (first use in this function)
> arch/unicore32/kernel/signal.c:279: error:
> 			‘usig’ undeclared (first use in this function)
> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
> arch/unicore32/kernel/signal.c:376: error:
> 			implicit declaration of function ‘get_signsl’
> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
> make: *** [arch/unicore32/kernel/signal.o] Error 2
> 
> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
> signal_setup_done()").
> 
> This code never even compiled. Reverting the patch does not work,
> since previously used functions no longer exist, so try to fix it up.
> Compile tested only.

Where did you get the unicore32 cross compiler from?

The collection on kernel.org is missing it:
https://www.kernel.org/pub/tools/crosstool/

This is why it did not get any build testing.

Thanks,
//richard

> Cc: Richard Weinberger <richard@nod.at>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  arch/unicore32/kernel/signal.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/unicore32/kernel/signal.c b/arch/unicore32/kernel/signal.c
> index 780d773..7c8fb70 100644
> --- a/arch/unicore32/kernel/signal.c
> +++ b/arch/unicore32/kernel/signal.c
> @@ -254,7 +254,8 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set,
>  
>  	err |= setup_sigframe(frame, regs, set);
>  	if (err == 0)
> -		err |= setup_return(regs, &ksig->ka, frame->retcode, frame, usig);
> +		err |= setup_return(regs, &ksig->ka, frame->retcode, frame,
> +				    ksig->sig);
>  
>  	return err;
>  }
> @@ -276,7 +277,8 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set,
>  	err |= __save_altstack(&frame->sig.uc.uc_stack, regs->UCreg_sp);
>  	err |= setup_sigframe(&frame->sig, regs, set);
>  	if (err == 0)
> -		err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame, usig);
> +		err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame,
> +				    ksig->sig);
>  
>  	if (err == 0) {
>  		/*
> @@ -303,7 +305,6 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs,
>  			  int syscall)
>  {
>  	struct thread_info *thread = current_thread_info();
> -	struct task_struct *tsk = current;
>  	sigset_t *oldset = sigmask_to_save();
>  	int usig = ksig->sig;
>  	int ret;
> @@ -373,7 +374,7 @@ static void do_signal(struct pt_regs *regs, int syscall)
>  	if (!user_mode(regs))
>  		return;
>  
> -	if (get_signsl(&ksig)) {
> +	if (get_signal(&ksig)) {
>  		handle_signal(&ksig, regs, syscall);
>  		return;
>  	}
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] unicore32: Fix build error
  2014-08-10 15:39 ` Richard Weinberger
@ 2014-08-10 16:30   ` Guenter Roeck
  2014-08-11  5:04     ` 回复： " Xuetao Guan 
  0 siblings, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2014-08-10 16:30 UTC (permalink / raw)
  To: Richard Weinberger, Guan Xuetao; +Cc: linux-kernel

On 08/10/2014 08:39 AM, Richard Weinberger wrote:
> Guenther,
>
> Am 10.08.2014 17:29, schrieb Guenter Roeck:
>> unicore32 builds fail with
>>
>> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
>> arch/unicore32/kernel/signal.c:257: error:
>> 			‘usig’ undeclared (first use in this function)
>> arch/unicore32/kernel/signal.c:279: error:
>> 			‘usig’ undeclared (first use in this function)
>> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
>> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
>> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
>> arch/unicore32/kernel/signal.c:376: error:
>> 			implicit declaration of function ‘get_signsl’
>> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
>> make: *** [arch/unicore32/kernel/signal.o] Error 2
>>
>> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
>> signal_setup_done()").
>>
>> This code never even compiled. Reverting the patch does not work,
>> since previously used functions no longer exist, so try to fix it up.
>> Compile tested only.
>
> Where did you get the unicore32 cross compiler from?
>
mprc.pku.edu.cn/~guanxuetao/linux/uc4-1.0.5-hard.tgz

Guenter


^ permalink raw reply	[flat|nested] 8+ messages in thread
* 回复： Re: [PATCH] unicore32: Fix build error
  2014-08-10 16:30   ` Guenter Roeck
@ 2014-08-11  5:04     ` Xuetao Guan 
  0 siblings, 0 replies; 8+ messages in thread
From: Xuetao Guan  @ 2014-08-11  5:04 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Richard Weinberger, Guan Xuetao, linux-kernel


----- Guenter Roeck <linux@roeck-us.net> 写道：
> On 08/10/2014 08:39 AM, Richard Weinberger wrote:
> > Guenther,
> >
> > Am 10.08.2014 17:29, schrieb Guenter Roeck:
> >> unicore32 builds fail with
> >>
> >> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
> >> arch/unicore32/kernel/signal.c:257: error:
> >> 			‘usig’ undeclared (first use in this function)
> >> arch/unicore32/kernel/signal.c:279: error:
> >> 			‘usig’ undeclared (first use in this function)
> >> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
> >> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
> >> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
> >> arch/unicore32/kernel/signal.c:376: error:
> >> 			implicit declaration of function ‘get_signsl’
> >> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
> >> make: *** [arch/unicore32/kernel/signal.o] Error 2
> >>
> >> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
> >> signal_setup_done()").
> >>
> >> This code never even compiled. Reverting the patch does not work,
> >> since previously used functions no longer exist, so try to fix it up.
> >> Compile tested only.
> >
> > Where did you get the unicore32 cross compiler from?
> >
> mprc.pku.edu.cn/~guanxuetao/linux/uc4-1.0.5-hard.tgz
> 
> Guenter

Yes, this toolchain can generate unicore32 binaries.
Thanks Guenter.

Xuetao

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] unicore32: Fix build error
  2014-08-10 15:29 [PATCH] unicore32: Fix build error Guenter Roeck
  2014-08-10 15:39 ` Richard Weinberger
@ 2014-08-15 19:38 ` Guenter Roeck
  2014-08-16  0:45   ` 回复： " Xuetao Guan 
  1 sibling, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2014-08-15 19:38 UTC (permalink / raw)
  To: Guan Xuetao; +Cc: linux-kernel, Richard Weinberger

On 08/10/2014 08:29 AM, Guenter Roeck wrote:
> unicore32 builds fail with
>
> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
> arch/unicore32/kernel/signal.c:257: error:
> 			‘usig’ undeclared (first use in this function)
> arch/unicore32/kernel/signal.c:279: error:
> 			‘usig’ undeclared (first use in this function)
> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
> arch/unicore32/kernel/signal.c:376: error:
> 			implicit declaration of function ‘get_signsl’
> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
> make: *** [arch/unicore32/kernel/signal.o] Error 2
>
> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
> signal_setup_done()").
>
> This code never even compiled. Reverting the patch does not work,
> since previously used functions no longer exist, so try to fix it up.
> Compile tested only.
>
> Cc: Richard Weinberger <richard@nod.at>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

ping ...

Failure is still present in upstream kernel (v3.16-11383-gc9d2642).

Guenter

> ---
>   arch/unicore32/kernel/signal.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/unicore32/kernel/signal.c b/arch/unicore32/kernel/signal.c
> index 780d773..7c8fb70 100644
> --- a/arch/unicore32/kernel/signal.c
> +++ b/arch/unicore32/kernel/signal.c
> @@ -254,7 +254,8 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set,
>
>   	err |= setup_sigframe(frame, regs, set);
>   	if (err == 0)
> -		err |= setup_return(regs, &ksig->ka, frame->retcode, frame, usig);
> +		err |= setup_return(regs, &ksig->ka, frame->retcode, frame,
> +				    ksig->sig);
>
>   	return err;
>   }
> @@ -276,7 +277,8 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set,
>   	err |= __save_altstack(&frame->sig.uc.uc_stack, regs->UCreg_sp);
>   	err |= setup_sigframe(&frame->sig, regs, set);
>   	if (err == 0)
> -		err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame, usig);
> +		err |= setup_return(regs, &ksig->ka, frame->sig.retcode, frame,
> +				    ksig->sig);
>
>   	if (err == 0) {
>   		/*
> @@ -303,7 +305,6 @@ static void handle_signal(struct ksignal *ksig, struct pt_regs *regs,
>   			  int syscall)
>   {
>   	struct thread_info *thread = current_thread_info();
> -	struct task_struct *tsk = current;
>   	sigset_t *oldset = sigmask_to_save();
>   	int usig = ksig->sig;
>   	int ret;
> @@ -373,7 +374,7 @@ static void do_signal(struct pt_regs *regs, int syscall)
>   	if (!user_mode(regs))
>   		return;
>
> -	if (get_signsl(&ksig)) {
> +	if (get_signal(&ksig)) {
>   		handle_signal(&ksig, regs, syscall);
>   		return;
>   	}
>


^ permalink raw reply	[flat|nested] 8+ messages in thread
* 回复： Re: [PATCH] unicore32: Fix build error
  2014-08-15 19:38 ` Guenter Roeck
@ 2014-08-16  0:45   ` Xuetao Guan 
  2014-08-16  2:21     ` Guenter Roeck
  0 siblings, 1 reply; 8+ messages in thread
From: Xuetao Guan  @ 2014-08-16  0:45 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Guan Xuetao, linux-kernel, Richard Weinberger


----- Guenter Roeck <linux@roeck-us.net> 写道：
> On 08/10/2014 08:29 AM, Guenter Roeck wrote:
> > unicore32 builds fail with
> >
> > arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
> > arch/unicore32/kernel/signal.c:257: error:
> > 			‘usig’ undeclared (first use in this function)
> > arch/unicore32/kernel/signal.c:279: error:
> > 			‘usig’ undeclared (first use in this function)
> > arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
> > arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
> > arch/unicore32/kernel/signal.c: In function ‘do_signal’:
> > arch/unicore32/kernel/signal.c:376: error:
> > 			implicit declaration of function ‘get_signsl’
> > make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
> > make: *** [arch/unicore32/kernel/signal.o] Error 2
> >
> > Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
> > signal_setup_done()").
> >
> > This code never even compiled. Reverting the patch does not work,
> > since previously used functions no longer exist, so try to fix it up.
> > Compile tested only.
> >
> > Cc: Richard Weinberger <richard@nod.at>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> ping ...
> 
> Failure is still present in upstream kernel (v3.16-11383-gc9d2642).
> 
> Guenter
> 

Thanks. I'll fix it.

Xuetao

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: 回复： Re: [PATCH] unicore32: Fix build error
  2014-08-16  0:45   ` 回复： " Xuetao Guan 
@ 2014-08-16  2:21     ` Guenter Roeck
  2014-08-18  0:26       ` 回复： " Xuetao Guan 
  0 siblings, 1 reply; 8+ messages in thread
From: Guenter Roeck @ 2014-08-16  2:21 UTC (permalink / raw)
  To: Xuetao Guan; +Cc: Guan Xuetao, linux-kernel, Richard Weinberger

On 08/15/2014 05:45 PM, Xuetao Guan  wrote:
>
> ----- Guenter Roeck <linux@roeck-us.net> 写道：
>> On 08/10/2014 08:29 AM, Guenter Roeck wrote:
>>> unicore32 builds fail with
>>>
>>> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
>>> arch/unicore32/kernel/signal.c:257: error:
>>> 			‘usig’ undeclared (first use in this function)
>>> arch/unicore32/kernel/signal.c:279: error:
>>> 			‘usig’ undeclared (first use in this function)
>>> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
>>> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
>>> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
>>> arch/unicore32/kernel/signal.c:376: error:
>>> 			implicit declaration of function ‘get_signsl’
>>> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
>>> make: *** [arch/unicore32/kernel/signal.o] Error 2
>>>
>>> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
>>> signal_setup_done()").
>>>
>>> This code never even compiled. Reverting the patch does not work,
>>> since previously used functions no longer exist, so try to fix it up.
>>> Compile tested only.
>>>
>>> Cc: Richard Weinberger <richard@nod.at>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> ping ...
>>
>> Failure is still present in upstream kernel (v3.16-11383-gc9d2642).
>>
>> Guenter
>>
>
> Thanks. I'll fix it.
>

More a question of applying (and if possible testing) the patch I provided.

Thanks,
Guenter



^ permalink raw reply	[flat|nested] 8+ messages in thread
* 回复： Re: 回复： Re: [PATCH] unicore32: Fix build error
  2014-08-16  2:21     ` Guenter Roeck
@ 2014-08-18  0:26       ` Xuetao Guan 
  0 siblings, 0 replies; 8+ messages in thread
From: Xuetao Guan  @ 2014-08-18  0:26 UTC (permalink / raw)
  To: Guenter Roeck; +Cc: Guan Xuetao, linux-kernel, Richard Weinberger


----- Guenter Roeck <linux@roeck-us.net> 写道：
> On 08/15/2014 05:45 PM, Xuetao Guan  wrote:
> >
> > ----- Guenter Roeck <linux@roeck-us.net> 写道：
> >> On 08/10/2014 08:29 AM, Guenter Roeck wrote:
> >>> unicore32 builds fail with
> >>>
> >>> arch/unicore32/kernel/signal.c: In function ‘setup_frame’:
> >>> arch/unicore32/kernel/signal.c:257: error:
> >>> 			‘usig’ undeclared (first use in this function)
> >>> arch/unicore32/kernel/signal.c:279: error:
> >>> 			‘usig’ undeclared (first use in this function)
> >>> arch/unicore32/kernel/signal.c: In function ‘handle_signal’:
> >>> arch/unicore32/kernel/signal.c:306: warning: unused variable ‘tsk’
> >>> arch/unicore32/kernel/signal.c: In function ‘do_signal’:
> >>> arch/unicore32/kernel/signal.c:376: error:
> >>> 			implicit declaration of function ‘get_signsl’
> >>> make[1]: *** [arch/unicore32/kernel/signal.o] Error 1
> >>> make: *** [arch/unicore32/kernel/signal.o] Error 2
> >>>
> >>> Bisect points to commit 649671c90eaf ("unicore32: Use get_signal()
> >>> signal_setup_done()").
> >>>
> >>> This code never even compiled. Reverting the patch does not work,
> >>> since previously used functions no longer exist, so try to fix it up.
> >>> Compile tested only.
> >>>
> >>> Cc: Richard Weinberger <richard@nod.at>
> >>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >>
> >> ping ...
> >>
> >> Failure is still present in upstream kernel (v3.16-11383-gc9d2642).
> >>
> >> Guenter
> >>
> >
> > Thanks. I'll fix it.
> >
> 
> More a question of applying (and if possible testing) the patch I provided.
> 
> Thanks,
> Guenter
> 
> 
Ok, I'll do it.

Xuetao

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-08-18  0:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-10 15:29 [PATCH] unicore32: Fix build error Guenter Roeck
2014-08-10 15:39 ` Richard Weinberger
2014-08-10 16:30   ` Guenter Roeck
2014-08-11  5:04     ` 回复： " Xuetao Guan 
2014-08-15 19:38 ` Guenter Roeck
2014-08-16  0:45   ` 回复： " Xuetao Guan 
2014-08-16  2:21     ` Guenter Roeck
2014-08-18  0:26       ` 回复： " Xuetao Guan 

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.