From: chrisudeussen@googlemail.com (Christian Deussen)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Is this a Bug?
Date: Tue, 21 Jun 2011 23:57:02 +0200 [thread overview]
Message-ID: <7088ABF5-4E3C-4FA6-BFD0-C163251CCB3D@gmail.com> (raw)
Hi,
I just compiled my first Kernel from linus' tree and saw a warning in "sound/soc/codecs/wm8958-dsp2.c".
I think a found a bug, but I am not sure. And I don`t want to waste the Kernel-dev's time on the lkml.
In function wm8958_dsp2_fw(), at line 64, there is an uninitialized variable used.
u32 data 32;
...
/*not related code*/
...
if (memcmp(fw->data, "WMFW", 4) != 0) {
dev_err(codec->dev, "%s: firmware has bad file magic %08x\n",
name, data32); //shouldn't fw->data be used?
goto err;
}
Am I right? And does this detail matter anyway?
I made several small fixes for warnings and added some #ifdef CONFIG_BLA when code wasnt used. Are those changes welcome on the LKML?
Thanks for your time.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20110621/f2281b8e/attachment.html
next reply other threads:[~2011-06-21 21:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 21:57 Christian Deussen [this message]
2011-06-21 22:49 ` Is this a Bug? Greg Freemyer
2011-06-22 7:28 ` Wilson Felipe
2011-06-22 19:50 ` julie Sullivan
2011-06-22 21:21 ` julie Sullivan
2011-06-23 12:16 ` Christian D.
2011-06-23 13:03 ` Jonathan Neuschäfer
2011-06-23 18:49 ` Jonathan Neuschäfer
-- strict thread matches above, loose matches on Subject: below --
2017-06-21 3:08 Is this a bug? Peter Teoh
2013-02-19 9:32 David Wade
2013-02-19 9:42 ` Andreas Ericsson
2013-02-19 9:47 ` Erik Faye-Lund
2013-02-19 11:02 ` Duy Nguyen
2013-02-22 19:29 ` Phil Hord
2013-02-22 21:48 ` Junio C Hamano
2011-04-02 8:05 Ding Dinghua
2011-04-02 16:32 ` Amir Goldstein
2011-04-03 9:24 ` Ding Dinghua
2011-04-03 14:51 ` Yongqiang Yang
2011-04-03 15:44 ` Amir Goldstein
2011-03-24 0:46 is " Jay
2011-03-25 15:18 ` Steven Rostedt
2005-08-20 0:14 is this a bug ? Ashwin Chaugule
2005-08-19 13:19 ` Thomas Gleixner
2005-08-20 1:36 ` Ashwin Chaugule
2005-08-19 18:25 ` Thomas Gleixner
2005-08-19 19:31 ` ashwinc
2002-07-15 13:57 Is this a bug? Tisserand Patrice
2002-07-15 14:08 ` Takashi Iwai
2001-08-07 11:51 is " Thodoris Pitikaris
2001-08-07 13:51 ` Andrzej Krzysztofowicz
2001-08-08 2:19 ` Dr. Kelsey Hudson
2001-08-08 3:15 ` J Sloan
2001-08-08 3:45 ` Dr. Kelsey Hudson
2001-08-08 10:53 ` David Weinehall
2001-08-08 11:05 ` Alan Cox
2001-08-08 12:59 ` Ron Flory
2001-08-08 16:51 ` jury gerold
2001-08-10 9:12 ` Eric W. Biederman
2001-08-10 12:22 ` jury gerold
2001-08-10 16:22 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7088ABF5-4E3C-4FA6-BFD0-C163251CCB3D@gmail.com \
--to=chrisudeussen@googlemail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.