All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ding Dinghua <dingdinghua85@gmail.com>
To: linux-ext4@vger.kernel.org
Subject: Is this a bug?
Date: Sat, 2 Apr 2011 16:05:50 +0800	[thread overview]
Message-ID: <BANLkTinPYj7_qpKcZgp3Oya1LXzcbfBczQ@mail.gmail.com> (raw)

When truncate files and free blocks, the following codes make me puzzled:

void ext4_free_blocks(handle_t *handle, struct inode *inode,
                      struct buffer_head *bh, ext4_fsblk_t block,
                      unsigned long count, int flags)
{
        if (flags & EXT4_FREE_BLOCKS_FORGET) {
                struct buffer_head *tbh = bh;
                int i;

                BUG_ON(bh && (count > 1));

                for (i = 0; i < count; i++) {
                        if (!bh)
                                tbh = sb_find_get_block(inode->i_sb,
                                                        block + i);
                        if (unlikely(!tbh))
                                continue;
                        ext4_forget(handle, flags & EXT4_FREE_BLOCKS_METADATA,
                                    inode, tbh, block + i);
                }
        }
}

I notice that ext4_forget mainly do two things:
    a)  call jbd2_journa_forget to forget the modification of some buffer head
    b)  or deal with the revoke issue
however, if we are freeing data blocks && ext4_forget get into branch a),
tbh is not the buffer_head which journal took care of in ext4_write_begin,
so i'm puzzled with this.

Could anyone explain it to me? Thanks.

--
Ding Dinghua

             reply	other threads:[~2011-04-02  8:05 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-02  8:05 Ding Dinghua [this message]
2011-04-02 16:32 ` Is this a bug? Amir Goldstein
2011-04-03  9:24   ` Ding Dinghua
2011-04-03 14:51     ` Yongqiang Yang
2011-04-03 15:44       ` Amir Goldstein
  -- strict thread matches above, loose matches on Subject: below --
2017-06-21  3:08 Peter Teoh
2013-02-19  9:32 David Wade
2013-02-19  9:42 ` Andreas Ericsson
2013-02-19  9:47 ` Erik Faye-Lund
2013-02-19 11:02   ` Duy Nguyen
2013-02-22 19:29     ` Phil Hord
2013-02-22 21:48       ` Junio C Hamano
2011-06-21 21:57 Is this a Bug? Christian Deussen
2011-06-21 22:49 ` Greg Freemyer
2011-06-22  7:28   ` Wilson Felipe
2011-06-22 19:50     ` julie Sullivan
2011-06-22 21:21       ` julie Sullivan
2011-06-23 12:16         ` Christian D.
2011-06-23 13:03           ` Jonathan Neuschäfer
2011-06-23 18:49 ` Jonathan Neuschäfer
2011-03-24  0:46 is this a bug? Jay
2011-03-25 15:18 ` Steven Rostedt
2005-08-20  0:14 is this a bug ? Ashwin Chaugule
2005-08-19 13:19 ` Thomas Gleixner
2005-08-20  1:36   ` Ashwin Chaugule
2005-08-19 18:25     ` Thomas Gleixner
2005-08-19 19:31       ` ashwinc
2002-07-15 13:57 Is this a bug? Tisserand Patrice
2002-07-15 14:08 ` Takashi Iwai
2001-08-07 11:51 is " Thodoris Pitikaris
2001-08-07 13:51 ` Andrzej Krzysztofowicz
2001-08-08  2:19 ` Dr. Kelsey Hudson
2001-08-08  3:15   ` J Sloan
2001-08-08  3:45     ` Dr. Kelsey Hudson
2001-08-08 10:53       ` David Weinehall
2001-08-08 11:05   ` Alan Cox
2001-08-08 12:59   ` Ron Flory
2001-08-08 16:51 ` jury gerold
2001-08-10  9:12   ` Eric W. Biederman
2001-08-10 12:22     ` jury gerold
2001-08-10 16:22       ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BANLkTinPYj7_qpKcZgp3Oya1LXzcbfBczQ@mail.gmail.com \
    --to=dingdinghua85@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.