All of lore.kernel.org
 help / color / mirror / Atom feed
* RFC: proposal for VM reset hcall
@ 2013-07-01 15:56 Yoder Stuart-B08248
  2013-07-01 16:48 ` Scott Wood
  0 siblings, 1 reply; 9+ messages in thread
From: Yoder Stuart-B08248 @ 2013-07-01 15:56 UTC (permalink / raw)
  To: Alexander Graf, Wood Scott-B07421, Bhushan Bharat-R65777; +Cc: kvm

For the e500 PV platform we need a VM reset mechanisms.

Hypercall: KVM_HC_VM_RESET
Description:  Requests that the virtual machine be reset.  The
              hcall takes no arguments. If successful the hcall does not
              return.

Arguments:
     r11    hcall-token   KVM_HC_VM_RESET

Return values
     r3     status        Status of the hcall.  If the hcall succeeds
                          it does not return.  If an error occurs
                          EV_INTERNAL is returned.


Implementation notes:

   -expect hcall token to be defined with KVM_HCALL_TOKEN(KVM_HC_VM_RESET)

   -the KVM_HC_FEATURES hcall should be expanded with a new feature bit
    to advertise the reset hcall to the VM:  #define KVM_FEATURE_VM_RESET


Regards,
Stuart



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: RFC: proposal for VM reset hcall
  2013-07-01 15:56 RFC: proposal for VM reset hcall Yoder Stuart-B08248
@ 2013-07-01 16:48 ` Scott Wood
  2013-07-01 17:28   ` Yoder Stuart-B08248
  0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2013-07-01 16:48 UTC (permalink / raw)
  To: Yoder Stuart-B08248
  Cc: Alexander Graf, Wood Scott-B07421, Bhushan Bharat-R65777, kvm

On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
> For the e500 PV platform we need a VM reset mechanisms.
> 
> Hypercall: KVM_HC_VM_RESET
> Description:  Requests that the virtual machine be reset.  The
>               hcall takes no arguments. If successful the hcall does  
> not
>               return.
> 
> Arguments:
>      r11    hcall-token   KVM_HC_VM_RESET
> 
> Return values
>      r3     status        Status of the hcall.  If the hcall succeeds
>                           it does not return.  If an error occurs
>                           EV_INTERNAL is returned.
> 
> 
> Implementation notes:
> 
>    -expect hcall token to be defined with  
> KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
> 
>    -the KVM_HC_FEATURES hcall should be expanded with a new feature  
> bit
>     to advertise the reset hcall to the VM:  #define  
> KVM_FEATURE_VM_RESET

What about shutdown rather than reset?

-Scott

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: RFC: proposal for VM reset hcall
  2013-07-01 16:48 ` Scott Wood
@ 2013-07-01 17:28   ` Yoder Stuart-B08248
  2013-07-01 17:32     ` Scott Wood
  0 siblings, 1 reply; 9+ messages in thread
From: Yoder Stuart-B08248 @ 2013-07-01 17:28 UTC (permalink / raw)
  To: Wood Scott-B07421; +Cc: Alexander Graf, Bhushan Bharat-R65777, kvm



> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Monday, July 01, 2013 11:49 AM
> To: Yoder Stuart-B08248
> Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777; kvm@vger.kernel.org
> Subject: Re: RFC: proposal for VM reset hcall
> 
> On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
> > For the e500 PV platform we need a VM reset mechanisms.
> >
> > Hypercall: KVM_HC_VM_RESET
> > Description:  Requests that the virtual machine be reset.  The
> >               hcall takes no arguments. If successful the hcall does
> > not
> >               return.
> >
> > Arguments:
> >      r11    hcall-token   KVM_HC_VM_RESET
> >
> > Return values
> >      r3     status        Status of the hcall.  If the hcall succeeds
> >                           it does not return.  If an error occurs
> >                           EV_INTERNAL is returned.
> >
> >
> > Implementation notes:
> >
> >    -expect hcall token to be defined with
> > KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
> >
> >    -the KVM_HC_FEATURES hcall should be expanded with a new feature
> > bit
> >     to advertise the reset hcall to the VM:  #define
> > KVM_FEATURE_VM_RESET
> 
> What about shutdown rather than reset?

'Shutdown' means something completely to me than 'reset',
and doesn't imply a reboot or reset.   I think the name
should be reset/restart/reboot.

Stuart


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: RFC: proposal for VM reset hcall
  2013-07-01 17:28   ` Yoder Stuart-B08248
@ 2013-07-01 17:32     ` Scott Wood
  2013-07-01 17:44       ` Yoder Stuart-B08248
  0 siblings, 1 reply; 9+ messages in thread
From: Scott Wood @ 2013-07-01 17:32 UTC (permalink / raw)
  To: Yoder Stuart-B08248
  Cc: Wood Scott-B07421, Alexander Graf, Bhushan Bharat-R65777, kvm

On 07/01/2013 12:28:34 PM, Yoder Stuart-B08248 wrote:
> 
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Monday, July 01, 2013 11:49 AM
> > To: Yoder Stuart-B08248
> > Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777;  
> kvm@vger.kernel.org
> > Subject: Re: RFC: proposal for VM reset hcall
> >
> > On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
> > > For the e500 PV platform we need a VM reset mechanisms.
> > >
> > > Hypercall: KVM_HC_VM_RESET
> > > Description:  Requests that the virtual machine be reset.  The
> > >               hcall takes no arguments. If successful the hcall  
> does
> > > not
> > >               return.
> > >
> > > Arguments:
> > >      r11    hcall-token   KVM_HC_VM_RESET
> > >
> > > Return values
> > >      r3     status        Status of the hcall.  If the hcall  
> succeeds
> > >                           it does not return.  If an error occurs
> > >                           EV_INTERNAL is returned.
> > >
> > >
> > > Implementation notes:
> > >
> > >    -expect hcall token to be defined with
> > > KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
> > >
> > >    -the KVM_HC_FEATURES hcall should be expanded with a new  
> feature
> > > bit
> > >     to advertise the reset hcall to the VM:  #define
> > > KVM_FEATURE_VM_RESET
> >
> > What about shutdown rather than reset?
> 
> 'Shutdown' means something completely to me than 'reset',
> and doesn't imply a reboot or reset.   I think the name
> should be reset/restart/reboot.

My point is that Alex talked about wanting both reboot and shutdown  
support.  I wasn't suggesting a name change.

-Scott

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: RFC: proposal for VM reset hcall
  2013-07-01 17:32     ` Scott Wood
@ 2013-07-01 17:44       ` Yoder Stuart-B08248
  2013-07-01 19:45         ` Alexander Graf
  0 siblings, 1 reply; 9+ messages in thread
From: Yoder Stuart-B08248 @ 2013-07-01 17:44 UTC (permalink / raw)
  To: Wood Scott-B07421; +Cc: Alexander Graf, Bhushan Bharat-R65777, kvm



> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Monday, July 01, 2013 12:32 PM
> To: Yoder Stuart-B08248
> Cc: Wood Scott-B07421; Alexander Graf; Bhushan Bharat-R65777; kvm@vger.kernel.org
> Subject: Re: RFC: proposal for VM reset hcall
> 
> On 07/01/2013 12:28:34 PM, Yoder Stuart-B08248 wrote:
> >
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Monday, July 01, 2013 11:49 AM
> > > To: Yoder Stuart-B08248
> > > Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777;
> > kvm@vger.kernel.org
> > > Subject: Re: RFC: proposal for VM reset hcall
> > >
> > > On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
> > > > For the e500 PV platform we need a VM reset mechanisms.
> > > >
> > > > Hypercall: KVM_HC_VM_RESET
> > > > Description:  Requests that the virtual machine be reset.  The
> > > >               hcall takes no arguments. If successful the hcall
> > does
> > > > not
> > > >               return.
> > > >
> > > > Arguments:
> > > >      r11    hcall-token   KVM_HC_VM_RESET
> > > >
> > > > Return values
> > > >      r3     status        Status of the hcall.  If the hcall
> > succeeds
> > > >                           it does not return.  If an error occurs
> > > >                           EV_INTERNAL is returned.
> > > >
> > > >
> > > > Implementation notes:
> > > >
> > > >    -expect hcall token to be defined with
> > > > KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
> > > >
> > > >    -the KVM_HC_FEATURES hcall should be expanded with a new
> > feature
> > > > bit
> > > >     to advertise the reset hcall to the VM:  #define
> > > > KVM_FEATURE_VM_RESET
> > >
> > > What about shutdown rather than reset?
> >
> > 'Shutdown' means something completely to me than 'reset',
> > and doesn't imply a reboot or reset.   I think the name
> > should be reset/restart/reboot.
> 
> My point is that Alex talked about wanting both reboot and shutdown
> support.  I wasn't suggesting a name change.

Ok, let's get Alex's input as to what shutdown support would
look like.  Not sure what a 'shutdown' hcall would do.

Stuart


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: RFC: proposal for VM reset hcall
  2013-07-01 17:44       ` Yoder Stuart-B08248
@ 2013-07-01 19:45         ` Alexander Graf
  2013-07-01 19:58           ` Yoder Stuart-B08248
  0 siblings, 1 reply; 9+ messages in thread
From: Alexander Graf @ 2013-07-01 19:45 UTC (permalink / raw)
  To: Yoder Stuart-B08248; +Cc: Wood Scott-B07421, Bhushan Bharat-R65777, kvm



Am 01.07.2013 um 19:44 schrieb Yoder Stuart-B08248 <B08248@freescale.com>:

> 
> 
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Monday, July 01, 2013 12:32 PM
>> To: Yoder Stuart-B08248
>> Cc: Wood Scott-B07421; Alexander Graf; Bhushan Bharat-R65777; kvm@vger.kernel.org
>> Subject: Re: RFC: proposal for VM reset hcall
>> 
>> On 07/01/2013 12:28:34 PM, Yoder Stuart-B08248 wrote:
>>> 
>>> 
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Monday, July 01, 2013 11:49 AM
>>>> To: Yoder Stuart-B08248
>>>> Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777;
>>> kvm@vger.kernel.org
>>>> Subject: Re: RFC: proposal for VM reset hcall
>>>> 
>>>> On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
>>>>> For the e500 PV platform we need a VM reset mechanisms.
>>>>> 
>>>>> Hypercall: KVM_HC_VM_RESET
>>>>> Description:  Requests that the virtual machine be reset.  The
>>>>>              hcall takes no arguments. If successful the hcall
>>> does
>>>>> not
>>>>>              return.
>>>>> 
>>>>> Arguments:
>>>>>     r11    hcall-token   KVM_HC_VM_RESET
>>>>> 
>>>>> Return values
>>>>>     r3     status        Status of the hcall.  If the hcall
>>> succeeds
>>>>>                          it does not return.  If an error occurs
>>>>>                          EV_INTERNAL is returned.
>>>>> 
>>>>> 
>>>>> Implementation notes:
>>>>> 
>>>>>   -expect hcall token to be defined with
>>>>> KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
>>>>> 
>>>>>   -the KVM_HC_FEATURES hcall should be expanded with a new
>>> feature
>>>>> bit
>>>>>    to advertise the reset hcall to the VM:  #define
>>>>> KVM_FEATURE_VM_RESET
>>>> 
>>>> What about shutdown rather than reset?
>>> 
>>> 'Shutdown' means something completely to me than 'reset',
>>> and doesn't imply a reboot or reset.   I think the name
>>> should be reset/restart/reboot.
>> 
>> My point is that Alex talked about wanting both reboot and shutdown
>> support.  I wasn't suggesting a name change.
> 
> Ok, let's get Alex's input as to what shutdown support would
> look like.  Not sure what a 'shutdown' hcall would do.

I don't have a strong opinion on whether shutdown is a sub-op of reboot or an individual hcall, but it should be there as well :). It certainly makes autotest a lot happier.


Alex

> 
> Stuart
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: RFC: proposal for VM reset hcall
  2013-07-01 19:45         ` Alexander Graf
@ 2013-07-01 19:58           ` Yoder Stuart-B08248
  2013-07-01 20:01             ` Alexander Graf
  2013-07-01 20:02             ` Alexander Graf
  0 siblings, 2 replies; 9+ messages in thread
From: Yoder Stuart-B08248 @ 2013-07-01 19:58 UTC (permalink / raw)
  To: Alexander Graf; +Cc: Wood Scott-B07421, Bhushan Bharat-R65777, kvm



> -----Original Message-----
> From: Alexander Graf [mailto:agraf@suse.de]
> Sent: Monday, July 01, 2013 2:46 PM
> To: Yoder Stuart-B08248
> Cc: Wood Scott-B07421; Bhushan Bharat-R65777; kvm@vger.kernel.org
> Subject: Re: RFC: proposal for VM reset hcall
> 
> 
> 
> Am 01.07.2013 um 19:44 schrieb Yoder Stuart-B08248 <B08248@freescale.com>:
> 
> >
> >
> >> -----Original Message-----
> >> From: Wood Scott-B07421
> >> Sent: Monday, July 01, 2013 12:32 PM
> >> To: Yoder Stuart-B08248
> >> Cc: Wood Scott-B07421; Alexander Graf; Bhushan Bharat-R65777; kvm@vger.kernel.org
> >> Subject: Re: RFC: proposal for VM reset hcall
> >>
> >> On 07/01/2013 12:28:34 PM, Yoder Stuart-B08248 wrote:
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Wood Scott-B07421
> >>>> Sent: Monday, July 01, 2013 11:49 AM
> >>>> To: Yoder Stuart-B08248
> >>>> Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777;
> >>> kvm@vger.kernel.org
> >>>> Subject: Re: RFC: proposal for VM reset hcall
> >>>>
> >>>> On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
> >>>>> For the e500 PV platform we need a VM reset mechanisms.
> >>>>>
> >>>>> Hypercall: KVM_HC_VM_RESET
> >>>>> Description:  Requests that the virtual machine be reset.  The
> >>>>>              hcall takes no arguments. If successful the hcall
> >>> does
> >>>>> not
> >>>>>              return.
> >>>>>
> >>>>> Arguments:
> >>>>>     r11    hcall-token   KVM_HC_VM_RESET
> >>>>>
> >>>>> Return values
> >>>>>     r3     status        Status of the hcall.  If the hcall
> >>> succeeds
> >>>>>                          it does not return.  If an error occurs
> >>>>>                          EV_INTERNAL is returned.
> >>>>>
> >>>>>
> >>>>> Implementation notes:
> >>>>>
> >>>>>   -expect hcall token to be defined with
> >>>>> KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
> >>>>>
> >>>>>   -the KVM_HC_FEATURES hcall should be expanded with a new
> >>> feature
> >>>>> bit
> >>>>>    to advertise the reset hcall to the VM:  #define
> >>>>> KVM_FEATURE_VM_RESET
> >>>>
> >>>> What about shutdown rather than reset?
> >>>
> >>> 'Shutdown' means something completely to me than 'reset',
> >>> and doesn't imply a reboot or reset.   I think the name
> >>> should be reset/restart/reboot.
> >>
> >> My point is that Alex talked about wanting both reboot and shutdown
> >> support.  I wasn't suggesting a name change.
> >
> > Ok, let's get Alex's input as to what shutdown support would
> > look like.  Not sure what a 'shutdown' hcall would do.
> 
> I don't have a strong opinion on whether shutdown is a sub-op of reboot or an individual hcall, but it
> should be there as well :). It certainly makes autotest a lot happier.

If a guest requests a 'shutdown', what is KVM supposed to do?
I'm assuming this means halt the machine / power-down.  Is there
a QEMU exit for this?

Stuart


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: RFC: proposal for VM reset hcall
  2013-07-01 19:58           ` Yoder Stuart-B08248
@ 2013-07-01 20:01             ` Alexander Graf
  2013-07-01 20:02             ` Alexander Graf
  1 sibling, 0 replies; 9+ messages in thread
From: Alexander Graf @ 2013-07-01 20:01 UTC (permalink / raw)
  To: Yoder Stuart-B08248; +Cc: Wood Scott-B07421, Bhushan Bharat-R65777, kvm


On 01.07.2013, at 21:58, Yoder Stuart-B08248 wrote:

> 
> 
>> -----Original Message-----
>> From: Alexander Graf [mailto:agraf@suse.de]
>> Sent: Monday, July 01, 2013 2:46 PM
>> To: Yoder Stuart-B08248
>> Cc: Wood Scott-B07421; Bhushan Bharat-R65777; kvm@vger.kernel.org
>> Subject: Re: RFC: proposal for VM reset hcall
>> 
>> 
>> 
>> Am 01.07.2013 um 19:44 schrieb Yoder Stuart-B08248 <B08248@freescale.com>:
>> 
>>> 
>>> 
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Monday, July 01, 2013 12:32 PM
>>>> To: Yoder Stuart-B08248
>>>> Cc: Wood Scott-B07421; Alexander Graf; Bhushan Bharat-R65777; kvm@vger.kernel.org
>>>> Subject: Re: RFC: proposal for VM reset hcall
>>>> 
>>>> On 07/01/2013 12:28:34 PM, Yoder Stuart-B08248 wrote:
>>>>> 
>>>>> 
>>>>>> -----Original Message-----
>>>>>> From: Wood Scott-B07421
>>>>>> Sent: Monday, July 01, 2013 11:49 AM
>>>>>> To: Yoder Stuart-B08248
>>>>>> Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777;
>>>>> kvm@vger.kernel.org
>>>>>> Subject: Re: RFC: proposal for VM reset hcall
>>>>>> 
>>>>>> On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
>>>>>>> For the e500 PV platform we need a VM reset mechanisms.
>>>>>>> 
>>>>>>> Hypercall: KVM_HC_VM_RESET
>>>>>>> Description:  Requests that the virtual machine be reset.  The
>>>>>>>             hcall takes no arguments. If successful the hcall
>>>>> does
>>>>>>> not
>>>>>>>             return.
>>>>>>> 
>>>>>>> Arguments:
>>>>>>>    r11    hcall-token   KVM_HC_VM_RESET
>>>>>>> 
>>>>>>> Return values
>>>>>>>    r3     status        Status of the hcall.  If the hcall
>>>>> succeeds
>>>>>>>                         it does not return.  If an error occurs
>>>>>>>                         EV_INTERNAL is returned.
>>>>>>> 
>>>>>>> 
>>>>>>> Implementation notes:
>>>>>>> 
>>>>>>>  -expect hcall token to be defined with
>>>>>>> KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
>>>>>>> 
>>>>>>>  -the KVM_HC_FEATURES hcall should be expanded with a new
>>>>> feature
>>>>>>> bit
>>>>>>>   to advertise the reset hcall to the VM:  #define
>>>>>>> KVM_FEATURE_VM_RESET
>>>>>> 
>>>>>> What about shutdown rather than reset?
>>>>> 
>>>>> 'Shutdown' means something completely to me than 'reset',
>>>>> and doesn't imply a reboot or reset.   I think the name
>>>>> should be reset/restart/reboot.
>>>> 
>>>> My point is that Alex talked about wanting both reboot and shutdown
>>>> support.  I wasn't suggesting a name change.
>>> 
>>> Ok, let's get Alex's input as to what shutdown support would
>>> look like.  Not sure what a 'shutdown' hcall would do.
>> 
>> I don't have a strong opinion on whether shutdown is a sub-op of reboot or an individual hcall, but it
>> should be there as well :). It certainly makes autotest a lot happier.
> 
> If a guest requests a 'shutdown', what is KVM supposed to do?
> I'm assuming this means halt the machine / power-down.  Is there
> a QEMU exit for this?

Yes :).


Alex


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: RFC: proposal for VM reset hcall
  2013-07-01 19:58           ` Yoder Stuart-B08248
  2013-07-01 20:01             ` Alexander Graf
@ 2013-07-01 20:02             ` Alexander Graf
  1 sibling, 0 replies; 9+ messages in thread
From: Alexander Graf @ 2013-07-01 20:02 UTC (permalink / raw)
  To: Yoder Stuart-B08248; +Cc: Wood Scott-B07421, Bhushan Bharat-R65777, kvm


On 01.07.2013, at 21:58, Yoder Stuart-B08248 wrote:

> 
> 
>> -----Original Message-----
>> From: Alexander Graf [mailto:agraf@suse.de]
>> Sent: Monday, July 01, 2013 2:46 PM
>> To: Yoder Stuart-B08248
>> Cc: Wood Scott-B07421; Bhushan Bharat-R65777; kvm@vger.kernel.org
>> Subject: Re: RFC: proposal for VM reset hcall
>> 
>> 
>> 
>> Am 01.07.2013 um 19:44 schrieb Yoder Stuart-B08248 <B08248@freescale.com>:
>> 
>>> 
>>> 
>>>> -----Original Message-----
>>>> From: Wood Scott-B07421
>>>> Sent: Monday, July 01, 2013 12:32 PM
>>>> To: Yoder Stuart-B08248
>>>> Cc: Wood Scott-B07421; Alexander Graf; Bhushan Bharat-R65777; kvm@vger.kernel.org
>>>> Subject: Re: RFC: proposal for VM reset hcall
>>>> 
>>>> On 07/01/2013 12:28:34 PM, Yoder Stuart-B08248 wrote:
>>>>> 
>>>>> 
>>>>>> -----Original Message-----
>>>>>> From: Wood Scott-B07421
>>>>>> Sent: Monday, July 01, 2013 11:49 AM
>>>>>> To: Yoder Stuart-B08248
>>>>>> Cc: Alexander Graf; Wood Scott-B07421; Bhushan Bharat-R65777;
>>>>> kvm@vger.kernel.org
>>>>>> Subject: Re: RFC: proposal for VM reset hcall
>>>>>> 
>>>>>> On 07/01/2013 10:56:54 AM, Yoder Stuart-B08248 wrote:
>>>>>>> For the e500 PV platform we need a VM reset mechanisms.
>>>>>>> 
>>>>>>> Hypercall: KVM_HC_VM_RESET
>>>>>>> Description:  Requests that the virtual machine be reset.  The
>>>>>>>             hcall takes no arguments. If successful the hcall
>>>>> does
>>>>>>> not
>>>>>>>             return.
>>>>>>> 
>>>>>>> Arguments:
>>>>>>>    r11    hcall-token   KVM_HC_VM_RESET
>>>>>>> 
>>>>>>> Return values
>>>>>>>    r3     status        Status of the hcall.  If the hcall
>>>>> succeeds
>>>>>>>                         it does not return.  If an error occurs
>>>>>>>                         EV_INTERNAL is returned.
>>>>>>> 
>>>>>>> 
>>>>>>> Implementation notes:
>>>>>>> 
>>>>>>>  -expect hcall token to be defined with
>>>>>>> KVM_HCALL_TOKEN(KVM_HC_VM_RESET)
>>>>>>> 
>>>>>>>  -the KVM_HC_FEATURES hcall should be expanded with a new
>>>>> feature
>>>>>>> bit
>>>>>>>   to advertise the reset hcall to the VM:  #define
>>>>>>> KVM_FEATURE_VM_RESET
>>>>>> 
>>>>>> What about shutdown rather than reset?
>>>>> 
>>>>> 'Shutdown' means something completely to me than 'reset',
>>>>> and doesn't imply a reboot or reset.   I think the name
>>>>> should be reset/restart/reboot.
>>>> 
>>>> My point is that Alex talked about wanting both reboot and shutdown
>>>> support.  I wasn't suggesting a name change.
>>> 
>>> Ok, let's get Alex's input as to what shutdown support would
>>> look like.  Not sure what a 'shutdown' hcall would do.
>> 
>> I don't have a strong opinion on whether shutdown is a sub-op of reboot or an individual hcall, but it
>> should be there as well :). It certainly makes autotest a lot happier.
> 
> If a guest requests a 'shutdown', what is KVM supposed to do?
> I'm assuming this means halt the machine / power-down.  Is there
> a QEMU exit for this?

Or let me put it differently: Both of these hcalls need to be processed in QEMU.


Alex


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-07-01 20:02 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-01 15:56 RFC: proposal for VM reset hcall Yoder Stuart-B08248
2013-07-01 16:48 ` Scott Wood
2013-07-01 17:28   ` Yoder Stuart-B08248
2013-07-01 17:32     ` Scott Wood
2013-07-01 17:44       ` Yoder Stuart-B08248
2013-07-01 19:45         ` Alexander Graf
2013-07-01 19:58           ` Yoder Stuart-B08248
2013-07-01 20:01             ` Alexander Graf
2013-07-01 20:02             ` Alexander Graf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.