All of lore.kernel.org
 help / color / mirror / Atom feed
From: "elaine.zhang" <zhangqing@rock-chips.com>
To: Douglas Anderson <dianders@chromium.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: dbasehore@chromium.org, amstan@chromium.org,
	linux-rockchip@lists.infradead.org, briannorris@chromium.org,
	mka@chromium.org, ryandcase@chromium.org,
	Chris Zhong <zyw@rock-chips.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: dts: rockchip: vdd_gpu off in suspend for rk3288-veyron
Date: Fri, 12 Apr 2019 09:55:18 +0800	[thread overview]
Message-ID: <70a7fea1-3818-b386-d951-013f94110f73@rock-chips.com> (raw)
In-Reply-To: <20190411232157.55125-5-dianders@chromium.org>

hi,

在 2019/4/12 上午7:21, Douglas Anderson 写道:
> At some point long long ago the downstream GPU driver would crash if
> we turned the GPU off during suspend.  For some context you can see:
>
> https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts
>
> At some point in time not too long after that got fixed.
>
> It's unclear why the GPU is left enabled during suspend on the
> mainline kernel.  Everything seems fine if I turn this off, so let's
> do it.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>   arch/arm/boot/dts/rk3288-veyron.dtsi | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 279d7f4ecce0..1252522392c7 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -217,8 +217,7 @@
>   				regulator-max-microvolt = <1250000>;
>   				regulator-ramp-delay = <6001>;
>   				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1000000>;
> +					regulator-off-in-suspend;
>   				};
>   			};
>   

Reviewed-by: Elaine Zhang<zhangqing@rock-chips.com>




WARNING: multiple messages have this Message-ID (diff)
From: "elaine.zhang" <zhangqing@rock-chips.com>
To: Douglas Anderson <dianders@chromium.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, briannorris@chromium.org,
	amstan@chromium.org, dbasehore@chromium.org,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-rockchip@lists.infradead.org, mka@chromium.org,
	ryandcase@chromium.org, Chris Zhong <zyw@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] ARM: dts: rockchip: vdd_gpu off in suspend for rk3288-veyron
Date: Fri, 12 Apr 2019 09:55:18 +0800	[thread overview]
Message-ID: <70a7fea1-3818-b386-d951-013f94110f73@rock-chips.com> (raw)
In-Reply-To: <20190411232157.55125-5-dianders@chromium.org>

hi,

在 2019/4/12 上午7:21, Douglas Anderson 写道:
> At some point long long ago the downstream GPU driver would crash if
> we turned the GPU off during suspend.  For some context you can see:
>
> https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts
>
> At some point in time not too long after that got fixed.
>
> It's unclear why the GPU is left enabled during suspend on the
> mainline kernel.  Everything seems fine if I turn this off, so let's
> do it.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
>   arch/arm/boot/dts/rk3288-veyron.dtsi | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> index 279d7f4ecce0..1252522392c7 100644
> --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> @@ -217,8 +217,7 @@
>   				regulator-max-microvolt = <1250000>;
>   				regulator-ramp-delay = <6001>;
>   				regulator-state-mem {
> -					regulator-on-in-suspend;
> -					regulator-suspend-microvolt = <1000000>;
> +					regulator-off-in-suspend;
>   				};
>   			};
>   

Reviewed-by: Elaine Zhang<zhangqing@rock-chips.com>




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-12  1:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 23:21 [PATCH 1/5] clk: rockchip: Turn on "aclk_dmac1" for suspend Douglas Anderson
2019-04-11 23:21 ` Douglas Anderson
2019-04-11 23:21 ` [PATCH 2/5] ARM: rockchip: pm: Mark init functions __init Douglas Anderson
2019-04-11 23:21   ` Douglas Anderson
2019-04-12 11:16   ` Heiko Stübner
2019-04-12 11:16     ` Heiko Stübner
2019-04-12 11:16     ` Heiko Stübner
2019-04-11 23:21 ` [PATCH 3/5] ARM: dts: rockchip: Add DDR retention/poweroff to rk3288-veyron hogs Douglas Anderson
2019-04-11 23:21   ` Douglas Anderson
2019-04-12 11:16   ` Heiko Stübner
2019-04-12 11:16     ` Heiko Stübner
2019-04-11 23:21 ` [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook Douglas Anderson
2019-04-11 23:21   ` Douglas Anderson
2019-04-12  1:53   ` elaine.zhang
2019-04-12  1:53     ` elaine.zhang
2019-04-12 11:16   ` Heiko Stübner
2019-04-12 11:16     ` Heiko Stübner
2019-04-11 23:21 ` [PATCH 5/5] ARM: dts: rockchip: vdd_gpu off in suspend for rk3288-veyron Douglas Anderson
2019-04-11 23:21   ` Douglas Anderson
2019-04-12  1:55   ` elaine.zhang [this message]
2019-04-12  1:55     ` elaine.zhang
2019-04-12 11:17   ` Heiko Stübner
2019-04-12 11:17     ` Heiko Stübner
2019-04-12  1:56 ` [PATCH 1/5] clk: rockchip: Turn on "aclk_dmac1" for suspend elaine.zhang
2019-04-12  1:56   ` elaine.zhang
2019-04-12 10:06 ` Heiko Stübner
2019-04-12 10:06   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70a7fea1-3818-b386-d951-013f94110f73@rock-chips.com \
    --to=zhangqing@rock-chips.com \
    --cc=amstan@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=dbasehore@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mka@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=ryandcase@chromium.org \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.