* [PATCH] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
@ 2021-08-27 8:55 ` zhaoxiao
0 siblings, 0 replies; 5+ messages in thread
From: zhaoxiao @ 2021-08-27 8:55 UTC (permalink / raw)
To: davem, kuba, mcoquelin.stm32
Cc: peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, zhaoxiao
- Change the pr_info/dev_info to dev_err.
- Add the dev_err to improve readability.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
.../net/ethernet/stmicro/stmmac/dwmac-loongson.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..495c94e7929f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -54,20 +54,21 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
bool mdio = false;
np = dev_of_node(&pdev->dev);
-
if (!np) {
- pr_info("dwmac_loongson_pci: No OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
return -ENODEV;
}
if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
- pr_info("dwmac_loongson_pci: Incompatible OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
return -ENODEV;
}
plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
- if (!plat)
+ if (!plat) {
+ dev_err(&pdev->dev, "memory allocation failed\n");
return -ENOMEM;
+ }
if (plat->mdio_node) {
dev_err(&pdev->dev, "Found MDIO subnode\n");
@@ -109,8 +110,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
plat->bus_id = pci_dev_id(pdev);
phy_mode = device_get_phy_mode(&pdev->dev);
- if (phy_mode < 0)
+ if (phy_mode < 0) {
dev_err(&pdev->dev, "phy_mode not found\n");
+ return phy_mode;
+ }
plat->phy_interface = phy_mode;
plat->interface = PHY_INTERFACE_MODE_GMII;
@@ -130,7 +133,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
res.wol_irq = of_irq_get_byname(np, "eth_wake_irq");
if (res.wol_irq < 0) {
- dev_info(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
+ dev_err(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
res.wol_irq = res.irq;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
@ 2021-08-27 8:55 ` zhaoxiao
0 siblings, 0 replies; 5+ messages in thread
From: zhaoxiao @ 2021-08-27 8:55 UTC (permalink / raw)
To: davem, kuba, mcoquelin.stm32
Cc: peppe.cavallaro, alexandre.torgue, joabreu, netdev, linux-stm32,
linux-arm-kernel, linux-kernel, zhaoxiao
- Change the pr_info/dev_info to dev_err.
- Add the dev_err to improve readability.
Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
---
.../net/ethernet/stmicro/stmmac/dwmac-loongson.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..495c94e7929f 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -54,20 +54,21 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
bool mdio = false;
np = dev_of_node(&pdev->dev);
-
if (!np) {
- pr_info("dwmac_loongson_pci: No OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
return -ENODEV;
}
if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
- pr_info("dwmac_loongson_pci: Incompatible OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
return -ENODEV;
}
plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
- if (!plat)
+ if (!plat) {
+ dev_err(&pdev->dev, "memory allocation failed\n");
return -ENOMEM;
+ }
if (plat->mdio_node) {
dev_err(&pdev->dev, "Found MDIO subnode\n");
@@ -109,8 +110,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
plat->bus_id = pci_dev_id(pdev);
phy_mode = device_get_phy_mode(&pdev->dev);
- if (phy_mode < 0)
+ if (phy_mode < 0) {
dev_err(&pdev->dev, "phy_mode not found\n");
+ return phy_mode;
+ }
plat->phy_interface = phy_mode;
plat->interface = PHY_INTERFACE_MODE_GMII;
@@ -130,7 +133,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
res.wol_irq = of_irq_get_byname(np, "eth_wake_irq");
if (res.wol_irq < 0) {
- dev_info(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
+ dev_err(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
res.wol_irq = res.irq;
}
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
2021-08-27 8:55 ` zhaoxiao
@ 2021-08-27 14:02 ` Jakub Kicinski
-1 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2021-08-27 14:02 UTC (permalink / raw)
To: zhaoxiao
Cc: davem, mcoquelin.stm32, peppe.cavallaro, alexandre.torgue,
joabreu, netdev, linux-stm32, linux-arm-kernel, linux-kernel
On Fri, 27 Aug 2021 16:55:50 +0800 zhaoxiao wrote:
> - Change the pr_info/dev_info to dev_err.
> - Add the dev_err to improve readability.
>
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
> .../net/ethernet/stmicro/stmmac/dwmac-loongson.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> index 4c9a37dd0d3f..495c94e7929f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> @@ -54,20 +54,21 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> bool mdio = false;
>
> np = dev_of_node(&pdev->dev);
> -
> if (!np) {
> - pr_info("dwmac_loongson_pci: No OF node\n");
> + dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
> return -ENODEV;
> }
>
> if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
> - pr_info("dwmac_loongson_pci: Incompatible OF node\n");
> + dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
> return -ENODEV;
> }
>
> plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
> - if (!plat)
> + if (!plat) {
> + dev_err(&pdev->dev, "memory allocation failed\n");
Please don't add error messages after allocation failures. OOM will
produce a lot of kernel messages and a stack trace already.
> return -ENOMEM;
> + }
>
> if (plat->mdio_node) {
> dev_err(&pdev->dev, "Found MDIO subnode\n");
> @@ -109,8 +110,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> plat->bus_id = pci_dev_id(pdev);
>
> phy_mode = device_get_phy_mode(&pdev->dev);
> - if (phy_mode < 0)
> + if (phy_mode < 0) {
> dev_err(&pdev->dev, "phy_mode not found\n");
> + return phy_mode;
You're adding a return here, it should be a separate patch with its own
justification.
> + }
>
> plat->phy_interface = phy_mode;
> plat->interface = PHY_INTERFACE_MODE_GMII;
> @@ -130,7 +133,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>
> res.wol_irq = of_irq_get_byname(np, "eth_wake_irq");
> if (res.wol_irq < 0) {
> - dev_info(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
> + dev_err(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
Why upgrade to an error, isn't wol_irq optional?
> res.wol_irq = res.irq;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
@ 2021-08-27 14:02 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2021-08-27 14:02 UTC (permalink / raw)
To: zhaoxiao
Cc: davem, mcoquelin.stm32, peppe.cavallaro, alexandre.torgue,
joabreu, netdev, linux-stm32, linux-arm-kernel, linux-kernel
On Fri, 27 Aug 2021 16:55:50 +0800 zhaoxiao wrote:
> - Change the pr_info/dev_info to dev_err.
> - Add the dev_err to improve readability.
>
> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
> ---
> .../net/ethernet/stmicro/stmmac/dwmac-loongson.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> index 4c9a37dd0d3f..495c94e7929f 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
> @@ -54,20 +54,21 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> bool mdio = false;
>
> np = dev_of_node(&pdev->dev);
> -
> if (!np) {
> - pr_info("dwmac_loongson_pci: No OF node\n");
> + dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
> return -ENODEV;
> }
>
> if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
> - pr_info("dwmac_loongson_pci: Incompatible OF node\n");
> + dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
> return -ENODEV;
> }
>
> plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
> - if (!plat)
> + if (!plat) {
> + dev_err(&pdev->dev, "memory allocation failed\n");
Please don't add error messages after allocation failures. OOM will
produce a lot of kernel messages and a stack trace already.
> return -ENOMEM;
> + }
>
> if (plat->mdio_node) {
> dev_err(&pdev->dev, "Found MDIO subnode\n");
> @@ -109,8 +110,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
> plat->bus_id = pci_dev_id(pdev);
>
> phy_mode = device_get_phy_mode(&pdev->dev);
> - if (phy_mode < 0)
> + if (phy_mode < 0) {
> dev_err(&pdev->dev, "phy_mode not found\n");
> + return phy_mode;
You're adding a return here, it should be a separate patch with its own
justification.
> + }
>
> plat->phy_interface = phy_mode;
> plat->interface = PHY_INTERFACE_MODE_GMII;
> @@ -130,7 +133,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>
> res.wol_irq = of_irq_get_byname(np, "eth_wake_irq");
> if (res.wol_irq < 0) {
> - dev_info(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
> + dev_err(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
Why upgrade to an error, isn't wol_irq optional?
> res.wol_irq = res.irq;
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()
2021-08-27 14:02 ` Jakub Kicinski
(?)
@ 2021-08-30 1:39 ` zhaoxiao
-1 siblings, 0 replies; 5+ messages in thread
From: zhaoxiao @ 2021-08-30 1:39 UTC (permalink / raw)
To: Jakub Kicinski
Cc: davem, mcoquelin.stm32, peppe.cavallaro, alexandre.torgue,
joabreu, netdev, linux-stm32, linux-arm-kernel, linux-kernel
Thanks for your advices, and I change the patch and commit again.
在 2021/8/27 下午10:02, Jakub Kicinski 写道:
> On Fri, 27 Aug 2021 16:55:50 +0800 zhaoxiao wrote:
>> - Change the pr_info/dev_info to dev_err.
>> - Add the dev_err to improve readability.
>>
>> Signed-off-by: zhaoxiao <zhaoxiao@uniontech.com>
>> ---
>> .../net/ethernet/stmicro/stmmac/dwmac-loongson.c | 15 +++++++++------
>> 1 file changed, 9 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> index 4c9a37dd0d3f..495c94e7929f 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
>> @@ -54,20 +54,21 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>> bool mdio = false;
>>
>> np = dev_of_node(&pdev->dev);
>> -
>> if (!np) {
>> - pr_info("dwmac_loongson_pci: No OF node\n");
>> + dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
>> return -ENODEV;
>> }
>>
>> if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
>> - pr_info("dwmac_loongson_pci: Incompatible OF node\n");
>> + dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
>> return -ENODEV;
>> }
>>
>> plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL);
>> - if (!plat)
>> + if (!plat) {
>> + dev_err(&pdev->dev, "memory allocation failed\n");
> Please don't add error messages after allocation failures. OOM will
> produce a lot of kernel messages and a stack trace already.
>
>> return -ENOMEM;
>> + }
>>
>> if (plat->mdio_node) {
>> dev_err(&pdev->dev, "Found MDIO subnode\n");
>> @@ -109,8 +110,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>> plat->bus_id = pci_dev_id(pdev);
>>
>> phy_mode = device_get_phy_mode(&pdev->dev);
>> - if (phy_mode < 0)
>> + if (phy_mode < 0) {
>> dev_err(&pdev->dev, "phy_mode not found\n");
>> + return phy_mode;
> You're adding a return here, it should be a separate patch with its own
> justification.
>
>> + }
>>
>> plat->phy_interface = phy_mode;
>> plat->interface = PHY_INTERFACE_MODE_GMII;
>> @@ -130,7 +133,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
>>
>> res.wol_irq = of_irq_get_byname(np, "eth_wake_irq");
>> if (res.wol_irq < 0) {
>> - dev_info(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
>> + dev_err(&pdev->dev, "IRQ eth_wake_irq not found, using macirq\n");
> Why upgrade to an error, isn't wol_irq optional?
>
>> res.wol_irq = res.irq;
>> }
>>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-30 1:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 8:55 [PATCH] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe() zhaoxiao
2021-08-27 8:55 ` zhaoxiao
2021-08-27 14:02 ` Jakub Kicinski
2021-08-27 14:02 ` Jakub Kicinski
2021-08-30 1:39 ` zhaoxiao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.