All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Kevin Hilman <khilman@baylibre.com>
Cc: linux-kernel@lists.codethink.co.uk, rtc-linux@googlegroups.com,
	a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
	devicetree@vger.kernel.org, robh+dt@kernel.org,
	frowand.list@gmail.com, linux-amlogic@lists.infradead.org
Subject: [rtc-linux] Re: RTC support for AMlogic devies
Date: Mon, 27 Jun 2016 20:49:28 +0100	[thread overview]
Message-ID: <70b8eaf9-b07c-8a56-8205-58bf6475a3f4@codethink.co.uk> (raw)
In-Reply-To: <m2bn2mtut1.fsf@baylibre.com>

On 27/06/16 18:18, Kevin Hilman wrote:
> Ben Dooks <ben.dooks@codethink.co.uk> writes:
> 
>> This series is support for the RTC block on some of the AMLogic
>> Meson ARM SoCs.
>>
>> The first patch is the driver, followed by device-tree patches
>> and enablement for the ODRoid-C1 (where it has been tested)
> 
> In the cover letter, please be explicit about any dependencies that are
> not upstream.  This series applies to mainline (v4.7-rc*) but does not
> build.  I tested it with my v4.7/integ branch and it seems to work.

I think this is just the DT bindings for the reset controller which
are currently in -next.

> The series also has a handful of checkpatch warnings that should be
> addressed (see: http://hastebin.com/tacurokasu.pas)

The msleep() ones I think are not a big isuse. The line length could
be solved, but at the moment is one of the few issues that are in the
rtc-meson.c driver.

The documentation one is solved by the patch adding the device-tree
binding information.

> Other than that, I gave it a quick spin on meson8b-odroidc1 using
> tools/testing/selftests/timers/rtctest.c, and the basic time stuff seems
> to be working:

Thank you.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
To: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
Cc: linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
	alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: RTC support for AMlogic devies
Date: Mon, 27 Jun 2016 20:49:28 +0100	[thread overview]
Message-ID: <70b8eaf9-b07c-8a56-8205-58bf6475a3f4@codethink.co.uk> (raw)
In-Reply-To: <m2bn2mtut1.fsf-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>

On 27/06/16 18:18, Kevin Hilman wrote:
> Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org> writes:
> 
>> This series is support for the RTC block on some of the AMLogic
>> Meson ARM SoCs.
>>
>> The first patch is the driver, followed by device-tree patches
>> and enablement for the ODRoid-C1 (where it has been tested)
> 
> In the cover letter, please be explicit about any dependencies that are
> not upstream.  This series applies to mainline (v4.7-rc*) but does not
> build.  I tested it with my v4.7/integ branch and it seems to work.

I think this is just the DT bindings for the reset controller which
are currently in -next.

> The series also has a handful of checkpatch warnings that should be
> addressed (see: http://hastebin.com/tacurokasu.pas)

The msleep() ones I think are not a big isuse. The line length could
be solved, but at the moment is one of the few issues that are in the
rtc-meson.c driver.

The documentation one is solved by the patch adding the device-tree
binding information.

> Other than that, I gave it a quick spin on meson8b-odroidc1 using
> tools/testing/selftests/timers/rtctest.c, and the basic time stuff seems
> to be working:

Thank you.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linus-amlogic@lists.infradead.org
Subject: RTC support for AMlogic devies
Date: Mon, 27 Jun 2016 20:49:28 +0100	[thread overview]
Message-ID: <70b8eaf9-b07c-8a56-8205-58bf6475a3f4@codethink.co.uk> (raw)
In-Reply-To: <m2bn2mtut1.fsf@baylibre.com>

On 27/06/16 18:18, Kevin Hilman wrote:
> Ben Dooks <ben.dooks@codethink.co.uk> writes:
> 
>> This series is support for the RTC block on some of the AMLogic
>> Meson ARM SoCs.
>>
>> The first patch is the driver, followed by device-tree patches
>> and enablement for the ODRoid-C1 (where it has been tested)
> 
> In the cover letter, please be explicit about any dependencies that are
> not upstream.  This series applies to mainline (v4.7-rc*) but does not
> build.  I tested it with my v4.7/integ branch and it seems to work.

I think this is just the DT bindings for the reset controller which
are currently in -next.

> The series also has a handful of checkpatch warnings that should be
> addressed (see: http://hastebin.com/tacurokasu.pas)

The msleep() ones I think are not a big isuse. The line length could
be solved, but at the moment is one of the few issues that are in the
rtc-meson.c driver.

The documentation one is solved by the patch adding the device-tree
binding information.

> Other than that, I gave it a quick spin on meson8b-odroidc1 using
> tools/testing/selftests/timers/rtctest.c, and the basic time stuff seems
> to be working:

Thank you.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

  parent reply	other threads:[~2016-06-27 19:49 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-27 14:52 [rtc-linux] RTC support for AMlogic devies Ben Dooks
2016-06-27 14:52 ` Ben Dooks
2016-06-27 14:52 ` Ben Dooks
2016-06-27 14:52 ` [rtc-linux] [PATCH 1/4] rtc: support for amlogic meson rtc Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52 ` [rtc-linux] [PATCH 2/4] meson-rtc: add device-tree binding Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52 ` [rtc-linux] [PATCH 3/4] ARM: dts: amlogic: add rtc node for meson8b Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52 ` [rtc-linux] [PATCH 4/4] ARM: meson: enable RTC for ODRoid-C1 Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 14:52   ` Ben Dooks
2016-06-27 17:18 ` [rtc-linux] Re: RTC support for AMlogic devies Kevin Hilman
2016-06-27 17:18   ` Kevin Hilman
2016-06-27 17:18   ` Kevin Hilman
2016-06-27 17:32   ` [rtc-linux] " 'Ben Dooks' via rtc-linux
2016-06-27 17:32     ` 'Ben Dooks' via rtc-linux
2016-06-27 19:49   ` Ben Dooks [this message]
2016-06-27 19:49     ` Ben Dooks
2016-06-27 19:49     ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70b8eaf9-b07c-8a56-8205-58bf6475a3f4@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.