[PATCH] runqemu: Allow the user to specity DTB

[PATCH] runqemu: Allow the user to specity DTB

[Ben Levinsky]

In some cirsumstances the user doesn't want to supply a kernel, rootFS
to QEMU, but only a DTB.

Allow users to specify dtb for supply via the QB_DTB option
to QEMU.

Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
---
 scripts/runqemu | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/runqemu b/scripts/runqemu
index 0b6daf2..075b3b9 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -604,7 +604,9 @@ class BaseConfig(object):
         if not os.path.exists(self.kernel):
             raise RunQemuError("KERNEL %s not found" % self.kernel)
 
+    def check_dtb(self):
         dtb = self.get('QB_DTB')
+        deploy_dir_image = self.get('DEPLOY_DIR_IMAGE')
         if dtb:
             cmd_match = "%s/%s" % (deploy_dir_image, dtb)
             cmd_startswith = "%s/%s*" % (deploy_dir_image, dtb)
@@ -674,6 +676,7 @@ class BaseConfig(object):
         self.check_rootfs()
         self.check_ovmf()
         self.check_kernel()
+        self.check_dtb()
         self.check_biosdir()
         self.check_mem()
         self.check_tcpserial()
-- 
2.7.4

Re: [PATCH] runqemu: Allow the user to specity DTB

[Richard Purdie]

On Thu, 2018-06-14 at 15:13 -0700, Ben Levinsky wrote:
> In some cirsumstances the user doesn't want to supply a kernel,
> rootFS
> to QEMU, but only a DTB.
> 
> Allow users to specify dtb for supply via the QB_DTB option
> to QEMU.
> 
> Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
> ---
>  scripts/runqemu | 3 +++
>  1 file changed, 3 insertions(+)

The patch looks good but this needs to go to the openembedded-core
mailing list as this script is part of the oe-core repo, not bitbake.

Cheers,

Richard

Re: [PATCH] runqemu: Allow the user to specity DTB

[Richard Purdie]

On Fri, 2018-06-15 at 09:58 -0700, Ben Levinsky wrote:
> In some cirsumstances the user doesn't want to supply a kernel,
> rootFS
> to QEMU, but only a DTB.
> 
> Allow users to specify dtb for supply via the QB_DTB option
> to QEMU.
> 
> Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
> ---
>  scripts/runqemu | 3 +++
>  1 file changed, 3 insertions(+)
> 
This patch doesn't seem to apply against the master branch. I went
looking in history and see:

http://git.yoctoproject.org/cgit.cgi/poky/commit/scripts/runqemu?id=fae2e2f42de8212e90f75ac0035ffb65db10bb6c

which looks to do something similar. Perhaps you really need that patch
backporting to some other branch? Could you check out the situation
with master please.

Cheers,

Richard

[PATCH] runqemu: Allow the user to specity DTB

[Ben Levinsky]

In some cirsumstances the user doesn't want to supply a kernel, rootFS
to QEMU, but only a DTB.

Allow users to specify dtb for supply via the QB_DTB option
to QEMU.

Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
---
 scripts/runqemu | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/scripts/runqemu b/scripts/runqemu
index 0b6daf2..075b3b9 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -604,7 +604,9 @@ class BaseConfig(object):
         if not os.path.exists(self.kernel):
             raise RunQemuError("KERNEL %s not found" % self.kernel)
 
+    def check_dtb(self):
         dtb = self.get('QB_DTB')
+        deploy_dir_image = self.get('DEPLOY_DIR_IMAGE')
         if dtb:
             cmd_match = "%s/%s" % (deploy_dir_image, dtb)
             cmd_startswith = "%s/%s*" % (deploy_dir_image, dtb)
@@ -674,6 +676,7 @@ class BaseConfig(object):
         self.check_rootfs()
         self.check_ovmf()
         self.check_kernel()
+        self.check_dtb()
         self.check_biosdir()
         self.check_mem()
         self.check_tcpserial()
-- 
2.7.4