[PATCH] nfs-utils: start-statd script using incompatible file descriptor

[PATCH] nfs-utils: start-statd script using incompatible file descriptor

[Daniel Pocock]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]



The current script uses fd 200, doesn't work for every possible shell as
reported[1] in Debian bug #848277

We are including a patch for it in the 1.3.4-2 package, it would be good
to incorporate this patch upstream too.

Regards,

Daniel


1. https://bugs.debian.org/848277

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 29-start-statd-fd-9.patch --]
[-- Type: text/x-patch; name="29-start-statd-fd-9.patch", Size: 461 bytes --]

diff --git a/utils/statd/start-statd b/utils/statd/start-statd
index 2fd6039..82715b4 100755
--- a/utils/statd/start-statd
+++ b/utils/statd/start-statd
@@ -7,8 +7,8 @@
 PATH="/sbin:/usr/sbin:/bin:/usr/bin"
 
 # Use flock to serialize the running of this script
-exec 200> /var/run/rpc.statd.lock
-flock -e 200
+exec 9> /var/run/rpc.statd.lock
+flock -e 9
 
 if [ -s /var/run/rpc.statd.pid ] &&
        [ 1`cat /var/run/rpc.statd.pid` -gt 1 ] &&

Re: [PATCH] nfs-utils: start-statd script using incompatible file descriptor

[Steve Dickson]

Hello, 

Could up please resubmit this patch with the
proper patch description (basically what 
problem you are fixing) and a proper 
 Signed-off-by: line.

steved.

On 12/17/2016 06:00 AM, Daniel Pocock wrote:
> 
> 
> The current script uses fd 200, doesn't work for every possible shell as
> reported[1] in Debian bug #848277
> 
> We are including a patch for it in the 1.3.4-2 package, it would be good
> to incorporate this patch upstream too.
> 
> Regards,
> 
> Daniel
> 
> 
> 1. https://bugs.debian.org/848277
> 

Re: [PATCH] nfs-utils: start-statd script using incompatible file descriptor

[Steve Dickson]

On 12/17/2016 06:00 AM, Daniel Pocock wrote:
> 
> 
> The current script uses fd 200, doesn't work for every possible shell as
> reported[1] in Debian bug #848277
> 
> We are including a patch for it in the 1.3.4-2 package, it would be good
> to incorporate this patch upstream too.
> 
> Regards,
> 
> Daniel
> 
> 
> 1. https://bugs.debian.org/848277
> 
Committed... Next time please in line the patch
instead of attaching it. 

steved.