All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	Wenrui Li <wenrui.li@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>
Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: rockchip: Remove unused platform data
Date: Sat, 8 Oct 2016 10:54:11 +0800	[thread overview]
Message-ID: <70f86886-8ba8-1240-f6f0-4800486a9845@rock-chips.com> (raw)
In-Reply-To: <20161007162726.23835.51154.stgit@bhelgaas-glaptop2.roam.corp.google.com>

在 2016/10/8 0:27, Bjorn Helgaas 写道:
> The rockchip driver never uses the platform drvdata pointer, so don't
> bother setting it.  No functional change intended.
>

Currently it's a build-in driver, so it seems okay to remove
this now.

Acked-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/pci/host/pcie-rockchip.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index 0a89d02..b3548d0 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -1019,8 +1019,8 @@ static int rockchip_pcie_prog_ib_atu(struct rockchip_pcie *rockchip,
>
>  static int rockchip_pcie_probe(struct platform_device *pdev)
>  {
> -	struct rockchip_pcie *rockchip;
>  	struct device *dev = &pdev->dev;
> +	struct rockchip_pcie *rockchip;
>  	struct pci_bus *bus, *child;
>  	struct resource_entry *win;
>  	resource_size_t io_base;
> @@ -1083,8 +1083,6 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
>  	if (err)
>  		goto err_vpcie;
>
> -	platform_set_drvdata(pdev, rockchip);
> -
>  	rockchip_pcie_enable_interrupts(rockchip);
>
>  	err = rockchip_pcie_init_irq_domain(rockchip);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Best Regards
Shawn Lin


WARNING: multiple messages have this Message-ID (diff)
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Bjorn Helgaas <bhelgaas@google.com>,
	Wenrui Li <wenrui.li@rock-chips.com>,
	Heiko Stuebner <heiko@sntech.de>
Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/3] PCI: rockchip: Remove unused platform data
Date: Sat, 8 Oct 2016 10:54:11 +0800	[thread overview]
Message-ID: <70f86886-8ba8-1240-f6f0-4800486a9845@rock-chips.com> (raw)
In-Reply-To: <20161007162726.23835.51154.stgit@bhelgaas-glaptop2.roam.corp.google.com>

在 2016/10/8 0:27, Bjorn Helgaas 写道:
> The rockchip driver never uses the platform drvdata pointer, so don't
> bother setting it.  No functional change intended.
>

Currently it's a build-in driver, so it seems okay to remove
this now.

Acked-by: Shawn Lin <shawn.lin@rock-chips.com>

> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/pci/host/pcie-rockchip.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c
> index 0a89d02..b3548d0 100644
> --- a/drivers/pci/host/pcie-rockchip.c
> +++ b/drivers/pci/host/pcie-rockchip.c
> @@ -1019,8 +1019,8 @@ static int rockchip_pcie_prog_ib_atu(struct rockchip_pcie *rockchip,
>
>  static int rockchip_pcie_probe(struct platform_device *pdev)
>  {
> -	struct rockchip_pcie *rockchip;
>  	struct device *dev = &pdev->dev;
> +	struct rockchip_pcie *rockchip;
>  	struct pci_bus *bus, *child;
>  	struct resource_entry *win;
>  	resource_size_t io_base;
> @@ -1083,8 +1083,6 @@ static int rockchip_pcie_probe(struct platform_device *pdev)
>  	if (err)
>  		goto err_vpcie;
>
> -	platform_set_drvdata(pdev, rockchip);
> -
>  	rockchip_pcie_enable_interrupts(rockchip);
>
>  	err = rockchip_pcie_init_irq_domain(rockchip);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


-- 
Best Regards
Shawn Lin

  reply	other threads:[~2016-10-08  2:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 16:27 [PATCH 1/3] PCI: rockchip: Rename accessors Bjorn Helgaas
2016-10-07 16:27 ` [PATCH 2/3] PCI: rockchip: Swap order of rockchip_writel() reg/val arguments Bjorn Helgaas
2016-10-08  2:52   ` Shawn Lin
2016-10-08  2:52     ` Shawn Lin
2016-10-07 16:27 ` [PATCH 3/3] PCI: rockchip: Remove unused platform data Bjorn Helgaas
2016-10-08  2:54   ` Shawn Lin [this message]
2016-10-08  2:54     ` Shawn Lin
2016-10-08  2:51 ` [PATCH 1/3] PCI: rockchip: Rename accessors Shawn Lin
2016-10-08  2:51   ` Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=70f86886-8ba8-1240-f6f0-4800486a9845@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=bhelgaas@google.com \
    --cc=heiko@sntech.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=wenrui.li@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.