* What's cooking in git.git (May 2016, #09; Tue, 31)
@ 2016-05-31 22:15 Junio C Hamano
2016-06-02 14:01 ` What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken Torsten Bögershausen
0 siblings, 1 reply; 14+ messages in thread
From: Junio C Hamano @ 2016-05-31 22:15 UTC (permalink / raw)
To: git
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
2.9-rc1 has been tagged. There still are a few topics yet to be
merged to 'master' for the upcoming release, but otherwise this is
pretty much "feature complete". One known brown-paper-bag breakage
exists in t/perf/, whose fix is still in 'next'.
You can find the changes described here in the integration branches
of the repositories listed at
http://git-blame.blogspot.com/p/git-public-repositories.html
--------------------------------------------------
[Graduated to "master"]
* ak/t0008-ksh88-workaround (2016-05-20) 1 commit
(merged to 'next' on 2016-05-26 at 9a34a2a)
+ t0008: 4 tests fail with ksh88
Test portability workaround.
* ak/t4204-shell-portability (2016-05-24) 1 commit
(merged to 'next' on 2016-05-27 at fd16e6d)
+ t4204: do not let $name variable clobbered
Update a test to run also under ksh88.
* es/t1500-modernize (2016-05-18) 5 commits
(merged to 'next' on 2016-05-26 at 274e39c)
+ t1500: avoid setting environment variables outside of tests
+ t1500: avoid setting configuration options outside of tests
+ t1500: avoid changing working directory outside of tests
+ t1500: test_rev_parse: facilitate future test enhancements
+ t1500: be considerate to future potential tests
test updates to make it more readable and maintainable.
* fc/fast-import-broken-marks-file (2016-05-17) 1 commit
(merged to 'next' on 2016-05-26 at 9962fcf)
+ fast-import: do not truncate exported marks file
"git fast-import --export-marks" would overwrite the existing marks
file even when it makes a dump from its custom die routine.
Prevent it from doing so when we have an import-marks file but
haven't finished reading it.
* jk/cat-file-buffered-batch-all (2016-05-18) 2 commits
(merged to 'next' on 2016-05-26 at 4da062d)
+ cat-file: default to --buffer when --batch-all-objects is used
+ cat-file: avoid noop calls to sha1_object_info_extended
"git cat-file --batch-all" has been sped up, by taking advantage
of the fact that it does not have to read a list of objects, in two
ways.
* js/t6044-use-test-seq (2016-05-18) 1 commit
(merged to 'next' on 2016-05-27 at d052a29)
+ t6044: replace seq by test_seq
Test portability fix.
* kb/msys2-tty (2016-05-26) 1 commit
(merged to 'next' on 2016-05-27 at 588f76c)
+ mingw: make isatty() recognize MSYS2's pseudo terminals (/dev/pty*)
The "are we talking with TTY, doing an interactive session?"
detection has been updated to work better for "Git for Windows".
* mr/send-email-doc-gmail-2fa (2016-05-27) 1 commit
(merged to 'next' on 2016-05-27 at 19d6ba4)
+ Documentation: add instructions to help setup gmail 2FA
Give hints to GMail users with two-factor auth enabled that
they need app-specific-password when using send-email.
* rj/log-decorate-auto (2016-05-27) 1 commit
(merged to 'next' on 2016-05-27 at 813112b)
+ log: document the --decorate=auto option
We forgot to add "git log --decorate=auto" to documentation when we
added the feature back in v2.1.0 timeframe.
--------------------------------------------------
[New Topics]
* js/rebase-i-dedup-call-to-rerere (2016-05-31) 1 commit
(merged to 'next' on 2016-05-31 at db1f9e3)
+ rebase -i: remove an unnecessary 'rerere' invocation
"git rebase -i", after it fails to auto-resolve the conflict, had
an unnecessary call to "git rerere" from its very early days, which
was spotted recently; the call has been removed.
Will merge to 'master'.
* sb/submodule-recommend-shallowness (2016-05-27) 2 commits
(merged to 'next' on 2016-05-31 at 1ee161c)
+ submodule update: learn `--[no-]recommend-shallow` option
+ submodule-config: keep shallow recommendation around
An upstream project can make a recommendation to make only a
shallow clone for some submodules in the .gitmodules file it ship.
Will merge to 'master' after 2.9 final.
* tb/convert-peek-in-index (2016-05-24) 2 commits
- convert: ce_compare_data() checks for a sha1 of a path
- read-cache: factor out get_sha1_from_index() helper
The motivation is rather iffy.
* va/i18n-even-more (2016-05-26) 22 commits
- t5523: use test_i18ngrep for negation
- t4153: fix negated test_i18ngrep call
- t9003: become resilient to GETTEXT_POISON
- tests: unpack-trees: update to use test_i18n* functions
- tests: use test_i18n* functions to suppress false positives
- i18n: setup: mark strings for translation
- i18n: rebase-interactive: mark comments of squash for translation
- i18n: rebase-interactive: mark here-doc strings for translation
- i18n: rebase-interactive: mark strings for translation
- i18n: git-sh-setup.sh: mark strings for translation
- t6030: update to use test_i18ncmp
- i18n: bisect: simplify error message for i18n
- i18n: rebase: mark placeholder for translation
- i18n: rebase: fix marked string to use eval_gettext variant
- merge-octupus: use die shell function from git-sh-setup.sh
- i18n: merge-octopus: mark messages for translation
- i18n: sequencer: mark string for translation
- i18n: sequencer: mark entire sentences for translation
- i18n: transport: mark strings for translation
- i18n: advice: internationalize message for conflicts
- i18n: advice: mark string about detached head for translation
- i18n: builtin/remote.c: fix mark for translation
More markings of messages for i18n, with updates to various tests
to pass GETTEXT_POISON tests.
Is everybody happy with this version?
* bd/readme.markdown-more (2016-05-31) 1 commit
- README.md: format CLI commands with code syntax
Will merge to 'next'.
* em/man-bold-literal (2016-05-31) 1 commit
- Documentation: bold literals in man
The manpage output of our documentation did not render well in
terminal; typeset literals in bold by default to make them stand
out more.
Will merge to 'next'.
* jg/dash-is-last-branch-in-worktree-add (2016-05-31) 1 commit
- worktree: allow "-" short-hand for @{-1} in add command
"git worktree add" learned that '-' can be used as a short-hand for
"@{-1}", the previous branch.
Will merge to 'next'.
* js/perf-rebase-i (2016-05-31) 1 commit
(merged to 'next' on 2016-05-31 at 39d8dc8)
+ perf: make the tests work without a worktree
The one in 'master' has a brown-paper-bag bug that breaks the perf
test when used inside a usual Git repository with a working tree.
Will merge to 'master'.
* dk/blame-move-no-reason-for-1-line-context (2016-05-29) 1 commit
- blame: require 0 context lines while finding moved lines with -M
"git blame -M" missed a single line that was moved within the file.
We may want to squash a test or two to this commit. Volunteers?
* mm/makefile-developer-can-be-in-config-mak (2016-05-31) 1 commit
- Makefile: move 'ifdef DEVELOPER' after config.mak* inclusion
"make DEVELOPER=1" worked as expected; setting DEVELOPER=1 in
config.mak didn't.
Will merge to 'next'.
* nd/worktree-lock (2016-05-31) 6 commits
- worktree: add "unlock" command
- worktree: add "lock" command
- worktree.c: retrieve lock status (and optionally reason) in get_worktrees()
- worktree.c: add is_main_worktree()
- worktree.c: find_worktree() learns to identify worktrees by basename
- worktree.c: add find_worktree()
(this branch uses nd/worktree-cleanup-post-head-protection.)
"git worktree prune" protected worktrees that are marked as
"locked" by creating a file in a known location. "git worktree"
command learned a dedicated command pair to create and remoev such
a file, so that the users do not have to do this with editor.
The implementation was wasteful; expecting a reroll.
* pa/cherry-pick-doc-typo (2016-05-29) 1 commit
- git-cherry-pick.txt: correct a small typo
"git cherry-pick --help" had three instances of word "behavior",
one of which was spelled "behaviour", which is updated to match the
other two.
Will merge to 'next'.
* rs/apply-name-terminate (2016-05-29) 1 commit
- apply: remove unused parameters from name_terminate()
Code clean-up.
Will merge to 'next'.
* rs/patch-id-use-skip-prefix (2016-05-29) 1 commit
- patch-id: use starts_with() and skip_prefix()
Code clean-up.
Will merge to 'next'.
--------------------------------------------------
[Stalled]
* sb/bisect (2016-04-15) 22 commits
- SQUASH???
- bisect: get back halfway shortcut
- bisect: compute best bisection in compute_relevant_weights()
- bisect: use a bottom-up traversal to find relevant weights
- bisect: prepare for different algorithms based on find_all
- bisect: rename count_distance() to compute_weight()
- bisect: make total number of commits global
- bisect: introduce distance_direction()
- bisect: extract get_distance() function from code duplication
- bisect: use commit instead of commit list as arguments when appropriate
- bisect: replace clear_distance() by unique markers
- bisect: use struct node_data array instead of int array
- bisect: get rid of recursion in count_distance()
- bisect: make algorithm behavior independent of DEBUG_BISECT
- bisect: make bisect compile if DEBUG_BISECT is set
- bisect: plug the biggest memory leak
- bisect: add test for the bisect algorithm
- t6030: generalize test to not rely on current implementation
- t: use test_cmp_rev() where appropriate
- t/test-lib-functions.sh: generalize test_cmp_rev
- bisect: allow 'bisect run' if no good commit is known
- bisect: write about `bisect next` in documentation
The internal algorithm used in "git bisect" to find the next commit
to check has been optimized greatly.
Expecting a reroll.
($gmane/291163)
* nd/shallow-deepen (2016-04-13) 26 commits
- fetch, upload-pack: --deepen=N extends shallow boundary by N commits
- upload-pack: add get_reachable_list()
- upload-pack: split check_unreachable() in two, prep for get_reachable_list()
- t5500, t5539: tests for shallow depth excluding a ref
- clone: define shallow clone boundary with --shallow-exclude
- fetch: define shallow boundary with --shallow-exclude
- upload-pack: support define shallow boundary by excluding revisions
- refs: add expand_ref()
- t5500, t5539: tests for shallow depth since a specific date
- clone: define shallow clone boundary based on time with --shallow-since
- fetch: define shallow boundary with --shallow-since
- upload-pack: add deepen-since to cut shallow repos based on time
- shallow.c: implement a generic shallow boundary finder based on rev-list
- fetch-pack: use a separate flag for fetch in deepening mode
- fetch-pack.c: mark strings for translating
- fetch-pack: use a common function for verbose printing
- fetch-pack: use skip_prefix() instead of starts_with()
- upload-pack: move rev-list code out of check_non_tip()
- upload-pack: tighten number parsing at "deepen" lines
- upload-pack: use skip_prefix() instead of starts_with()
- upload-pack: move "unshallow" sending code out of deepen()
- upload-pack: remove unused variable "backup"
- upload-pack: move "shallow" sending code out of deepen()
- upload-pack: move shallow deepen code out of receive_needs()
- transport-helper.c: refactor set_helper_option()
- remote-curl.c: convert fetch_git() to use argv_array
The existing "git fetch --depth=<n>" option was hard to use
correctly when making the history of an existing shallow clone
deeper. A new option, "--deepen=<n>", has been added to make this
easier to use. "git clone" also learned "--shallow-since=<date>"
and "--shallow-exclude=<tag>" options to make it easier to specify
"I am interested only in the recent N months worth of history" and
"Give me only the history since that version".
Needs review.
* sg/completion-updates (2016-02-28) 21 commits
. completion: cache the path to the repository
. completion: extract repository discovery from __gitdir()
. completion: don't guard git executions with __gitdir()
. completion: consolidate silencing errors from git commands
. completion: don't use __gitdir() for git commands
. completion: respect 'git -C <path>'
. completion: fix completion after 'git -C <path>'
. completion: don't offer commands when 'git --opt' needs an argument
. rev-parse: add '--absolute-git-dir' option
. completion: list short refs from a remote given as a URL
. completion: don't list 'HEAD' when trying refs completion outside of a repo
. completion: list refs from remote when remote's name matches a directory
. completion: respect 'git --git-dir=<path>' when listing remote refs
. completion: fix most spots not respecting 'git --git-dir=<path>'
. completion: ensure that the repository path given on the command line exists
. completion tests: add tests for the __git_refs() helper function
. completion tests: check __gitdir()'s output in the error cases
. completion tests: consolidate getting path of current working directory
. completion tests: make the $cur variable local to the test helper functions
. completion tests: don't add test cruft to the test repository
. completion: improve __git_refs()'s in-code documentation
Will be rerolled.
($gmane/287839)
* az/p4-bare-no-rebase (2016-02-19) 1 commit
- git-p4.py: Don't try to rebase on submit from bare repository
"git p4 submit" attempts to do a rebase, which would fail if done
in a bare repository. Not doing this rebase would paper over the
failure, which is what this patch does, but it is unclear what the
side effect of not rebasing is.
Needs a better explanation.
* nd/icase (2016-02-15) 12 commits
- grep.c: reuse "icase" variable
- diffcore-pickaxe: support case insensitive match on non-ascii
- diffcore-pickaxe: "share" regex error handling code
- grep/pcre: support utf-8
- gettext: add is_utf8_locale()
- grep/pcre: prepare locale-dependent tables for icase matching
- grep/icase: avoid kwsset when -F is specified
- grep/icase: avoid kwsset on literal non-ascii strings
- test-regex: expose full regcomp() to the command line
- test-regex: isolate the bug test code
- grep: break down an "if" stmt in preparation for next changes
- grep: allow -F -i combination
"git grep -i" has been taught to fold case in non-ascii locales.
Needs review.
($gmane/286137)
* ec/annotate-deleted (2015-11-20) 1 commit
- annotate: skip checking working tree if a revision is provided
Usability fix for annotate-specific "<file> <rev>" syntax with deleted
files.
Waiting for review.
* dg/subtree-rebase-test (2016-01-19) 1 commit
- contrib/subtree: Add a test for subtree rebase that loses commits
Reviewed up to v5.
Will be rerolled.
($gmane/284426)
* js/am-3-merge-recursive-direct (2015-10-12) 2 commits
- am: make a direct call to merge_recursive
- merge_recursive_options: introduce the "gently" flag
The merge_recursive_generic() function has been made a bit safer to
call from inside a process. "git am -3" was taught to make a direct
call to the function when falling back to three-way merge.
Being able to make a direct call would be good in general, but as a
performance thing, the change needs to be backed up by numbers.
I haven't gone through the "gently" change with fine toothed comb;
I can see that the change avoids calling die(), but I haven't made
sure that the program states (e.g. what's in the in-core index) are
adjusted sensibly when it returns to the caller instead of dying,
or the codepaths that used to die() are free of resource leaks.
The original code certainly did not care the program states at the
point of dying exactly because it knew it is going to exit, but now
they have to care, and they need to be audited.
Will be rerolled.
($gmane/292205)
* dk/gc-more-wo-pack (2016-01-13) 4 commits
- gc: clean garbage .bitmap files from pack dir
- t5304: ensure non-garbage files are not deleted
- t5304: test .bitmap garbage files
- prepare_packed_git(): find more garbage
Follow-on to dk/gc-idx-wo-pack topic, to clean up stale
.bitmap and .keep files.
Waiting for a reroll.
($gmane/284368).
* jc/diff-b-m (2015-02-23) 5 commits
. WIPWIP
. WIP: diff-b-m
- diffcore-rename: allow easier debugging
- diffcore-rename.c: add locate_rename_src()
- diffcore-break: allow debugging
"git diff -B -M" produced incorrect patch when the postimage of a
completely rewritten file is similar to the preimage of a removed
file; such a resulting file must not be expressed as a rename from
other place.
The fix in this patch is broken, unfortunately.
Will discard.
* jc/merge-impossible-no-commit (2016-04-26) 2 commits
- merge: warn --no-commit merge when no new commit is created
- merge: do not contaminate option_commit with --squash
"git merge --no-commit" silently succeeded when there is no need to
create any commit, either when you are more recent than the commit
you tried to merge, or you can fast-forward to the commit you tried
to merge. The command gives a warning message in such cases.
Just tying loose ends in a discussion. Unless somebody else
champions this topic, I'll drop it.
Will discard.
--------------------------------------------------
[Cooking]
* et/pretty-format-c-auto (2016-05-27) 1 commit
(merged to 'next' on 2016-05-31 at 1e9c920)
+ format_commit_message: honor `color=auto` for `%C(auto)`
%C(auto) in a custom format string that commands in `git log`
family takes unconditionally turned the color on, ignoring
--no-color or --color=auto with output not connected to a tty;
this was corrected to make the format truly behave as "auto".
Will merge to 'master' after 2.9 final.
* ew/daemon-socket-keepalive (2016-05-25) 1 commit
(merged to 'next' on 2016-05-31 at c32acf1)
+ daemon: enable SO_KEEPALIVE for all sockets
When "git daemon" is run without --[init-]timeout specified, a
connection from a client that silently goes offline can hang around
for a long time, wasting resources. The socket-level KEEPALIVE has
been enabled to allow the OS to notice such failed connections.
Will merge to 'master' after 2.9 final.
* jk/upload-pack-hook (2016-05-27) 6 commits
- upload-pack: provide a hook for running pack-objects
- config: add a notion of "scope"
- config: return configset value for current_config_ functions
- config: set up config_source for command-line config
- git_config_parse_parameter: refactor cleanup code
- git_config_with_options: drop "found" counting
Allow a custom "git upload-pack" replacement to respond to
"fetch/clone" request.
Still under discussion.
($gmane/295705).
* rs/xdiff-hunk-with-func-line (2016-05-31) 8 commits
- grep: -W: don't extend context to trailing empty lines
- t7810: add test for grep -W and trailing empty context lines
- xdiff: don't trim common tail with -W
- xdiff: -W: don't include common trailing empty lines in context
- xdiff: ignore empty lines before added functions with -W
- xdiff: handle appended chunks better with -W
- xdiff: factor out match_func_rec()
- t4051: rewrite, add more tests
"git show -W" (extend hunks to cover the entire function, delimited
by lines that match the "funcname" pattern) used to show the entire
file when a change added an entire function at the end of the file,
which has been fixed.
Will merge to 'next'.
* sb/submodule-misc-cleanups (2016-05-25) 1 commit
(merged to 'next' on 2016-05-31 at 0d07b9c)
+ submodule update: make use of the existing fetch_in_submodule function
Minor simplification.
Will merge to 'master' after 2.9 final.
* sb/submodule-default-paths (2016-05-26) 7 commits
- clone: add --init-submodule=<pathspec> switch
- submodule update: add `--init-default-path` switch
- Merge branch 'sb/pathspec-label' into sb/submodule-default-paths
- Merge branch 'jc/attr' into sb/submodule-default-paths
- Merge branch 'sb/clone-shallow-passthru' into sb/submodule-default-paths
- Merge branch 'sb/submodule-deinit-all' into sb/submodule-default-paths
- Merge branch 'sb/submodule-parallel-update' into sb/submodule-default-paths
(this branch uses jc/attr and sb/pathspec-label.)
Will merge to 'next'.
* ah/no-verify-signature-with-pull-rebase (2016-05-20) 1 commit
(merged to 'next' on 2016-05-31 at 30add83)
+ pull: warn on --verify-signatures with --rebase
"git pull --rebase --verify-signature" learned to warn the user
that "--verify-signature" is a no-op.
Will merge to 'master' after 2.9 final.
* ep/http-curl-trace (2016-05-24) 2 commits
- imap-send.c: introduce the GIT_TRACE_CURL enviroment variable
- http.c: implement the GIT_TRACE_CURL environment variable
HTTP transport gained an option to produce more detailed debugging
trace.
Rerolled. Is everybody happy with this version?
* jc/attr (2016-05-25) 18 commits
(merged to 'next' on 2016-05-31 at 5b2f08b)
+ attr: support quoting pathname patterns in C style
+ attr: expose validity check for attribute names
+ attr: add counted string version of git_attr()
+ attr: add counted string version of git_check_attr()
+ attr: retire git_check_attrs() API
+ attr: convert git_check_attrs() callers to use the new API
+ attr: convert git_all_attrs() to use "struct git_attr_check"
+ attr: (re)introduce git_check_attr() and struct git_attr_check
+ attr: rename function and struct related to checking attributes
+ attr.c: plug small leak in parse_attr_line()
+ attr.c: tighten constness around "git_attr" structure
+ attr.c: simplify macroexpand_one()
+ attr.c: mark where #if DEBUG ends more clearly
+ attr.c: complete a sentence in a comment
+ attr.c: explain the lack of attr-name syntax check in parse_attr()
+ attr.c: update a stale comment on "struct match_attr"
+ attr.c: use strchrnul() to scan for one line
+ commit.c: use strchrnul() to scan for one line
(this branch is used by sb/pathspec-label and sb/submodule-default-paths.)
The attributes API has been updated so that it can later be
optimized using the knowledge of which attributes are queried.
* cc/apply-introduce-state (2016-05-12) 48 commits
- builtin/apply: rename 'prefix_' parameter to 'prefix'
- builtin/apply: move applying patches into apply_all_patches()
- builtin/apply: move 'state' check into check_apply_state()
- builtin/apply: move 'symlink_changes' global into 'struct apply_state'
- builtin/apply: move 'fn_table' global into 'struct apply_state'
- builtin/apply: move 'state_linenr' global into 'struct apply_state'
- builtin/apply: move 'max_change' and 'max_len' into 'struct apply_state'
- builtin/apply: move 'ws_ignore_action' into 'struct apply_state'
- builtin/apply: move 'ws_error_action' into 'struct apply_state'
- builtin/apply: move 'applied_after_fixing_ws' into 'struct apply_state'
- builtin/apply: move 'squelch_whitespace_errors' into 'struct apply_state'
- builtin/apply: remove whitespace_option arg from set_default_whitespace_mode()
- builtin/apply: move 'whitespace_option' into 'struct apply_state'
- builtin/apply: move 'whitespace_error' global into 'struct apply_state'
- builtin/apply: move 'root' global into 'struct apply_state'
- builtin/apply: move 'p_value_known' global into 'struct apply_state'
- builtin/apply: move 'p_value' global into 'struct apply_state'
- builtin/apply: move 'has_include' global into 'struct apply_state'
- builtin/apply: move 'limit_by_name' global into 'struct apply_state'
- builtin/apply: move 'patch_input_file' global into 'struct apply_state'
- builtin/apply: move 'apply' global into 'struct apply_state'
- builtin/apply: move 'p_context' global into 'struct apply_state'
- builtin/apply: move 'fake_ancestor' global into 'struct apply_state'
- builtin/apply: move 'line_termination' global into 'struct apply_state'
- builtin/apply: move 'unsafe_paths' global into 'struct apply_state'
- builtin/apply: move 'no_add' global into 'struct apply_state'
- builtin/apply: move 'threeway' global into 'struct apply_state'
- builtin/apply: move 'summary' global into 'struct apply_state'
- builtin/apply: move 'numstat' global into 'struct apply_state'
- builtin/apply: move 'diffstat' global into 'struct apply_state'
- builtin/apply: move 'cached' global into 'struct apply_state'
- builtin/apply: move 'allow_overlap' global into 'struct apply_state'
- builtin/apply: move 'update_index' global into 'struct apply_state'
- builtin/apply: move 'apply_verbosely' global into 'struct apply_state'
- builtin/apply: move 'apply_with_reject' global into 'struct apply_state'
- builtin/apply: move 'apply_in_reverse' global into 'struct apply_state'
- builtin/apply: move 'check_index' global into 'struct apply_state'
- builtin/apply: move 'check' global into 'struct apply_state'
- builtin/apply: move 'unidiff_zero' global into 'struct apply_state'
- builtin/apply: move 'state' init into init_apply_state()
- builtin/apply: introduce 'struct apply_state' to start libifying
- builtin/apply: move 'read_stdin' global into cmd_apply()
- builtin/apply: move 'options' variable into cmd_apply()
- builtin/apply: extract line_by_line_fuzzy_match() from match_fragment()
- builtin/apply: avoid local variable shadowing 'len' parameter
- builtin/apply: avoid parameter shadowing 'linenr' global
- builtin/apply: avoid parameter shadowing 'p_value' global
- builtin/apply: make gitdiff_verify_name() return void
The "git apply" standalone program is being libified; this is the
first step to move many state variables into a structure that can
be explicitly (re)initialized to make the machinery callable more
than once.
The next step that moves some remaining state variables into the
structure and turns die()s into an error return that propagates up
to the caller is not queued yet but in flight. It would be good to
review the above first and give the remainder of the series a solid
base to build on.
Reroll exists, but hasn't seen any review yet ($gmane/295429).
* pb/bisect (2016-05-24) 3 commits
- bisect--helper: `write_terms` shell function in C
- bisect: rewrite `check_term_format` shell function in C
- bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
Beginning of GSoC "git bisect" project.
* sb/pathspec-label (2016-05-25) 4 commits
(merged to 'next' on 2016-05-31 at e72b604)
+ pathspec: allow querying for attributes
+ pathspec: move prefix check out of the inner loop
+ pathspec: move long magic parsing out of prefix_pathspec
+ Documentation: fix a typo
(this branch is used by sb/submodule-default-paths; uses jc/attr.)
The pathspec mechanism learned ":(attr:X)$pattern" pathspec magic
to limit paths that match $pattern further by attribute settings.
Will merge to 'master' after 2.9 final.
* nd/worktree-cleanup-post-head-protection (2016-05-24) 6 commits
- worktree: simplify prefixing paths
- worktree: avoid 0{40}, too many zeroes, hard to read
- worktree.c: use is_dot_or_dotdot()
- git-worktree.txt: keep subcommand listing in alphabetical order
- worktree.c: rewrite mark_current_worktree() to avoid strbuf
- completion: support git-worktree
(this branch is used by nd/worktree-lock.)
Further preparatory clean-up for "worktree" feature.
Expecting a reroll.
($gmane/294136, etc.)
* mh/split-under-lock (2016-05-13) 33 commits
- lock_ref_sha1_basic(): only handle REF_NODEREF mode
- commit_ref_update(): remove the flags parameter
- lock_ref_for_update(): don't resolve symrefs
- lock_ref_for_update(): don't re-read non-symbolic references
- refs: resolve symbolic refs first
- ref_transaction_update(): check refname_is_safe() at a minimum
- unlock_ref(): move definition higher in the file
- lock_ref_for_update(): new function
- add_update(): initialize the whole ref_update
- verify_refname_available(): adjust constness in declaration
- refs: don't dereference on rename
- refs: allow log-only updates
- delete_branches(): use resolve_refdup()
- ref_transaction_commit(): correctly report close_ref() failure
- ref_transaction_create(): disallow recursive pruning
- refs: make error messages more consistent
- lock_ref_sha1_basic(): remove unneeded local variable
- read_raw_ref(): move docstring to header file
- read_raw_ref(): improve docstring
- read_raw_ref(): rename symref argument to referent
- read_raw_ref(): clear *type at start of function
- read_raw_ref(): rename flags argument to type
- ref_transaction_commit(): remove local variable n
- rename_ref(): remove unneeded local variable
- commit_ref_update(): write error message to *err, not stderr
- refname_is_safe(): insist that the refname already be normalized
- refname_is_safe(): don't allow the empty string
- refname_is_safe(): use skip_prefix()
- remove_dir_recursively(): add docstring
- safe_create_leading_directories(): improve docstring
- read_raw_ref(): don't get confused by an empty directory
- commit_ref(): if there is an empty dir in the way, delete it
- t1404: demonstrate a bug resolving references
Further preparatory work on the refs API before the pluggable
backend series can land.
Updated (again). Will wait for comments for the last time, and
then merge to 'next'.
* mh/connect-leak (2016-04-28) 1 commit
- git_connect(): fix memory leak with CONNECT_DIAG_URL
Is already made obsolete with a patch in flight under discussion.
($gmane/292962)
Will discard.
* ew/fast-import-unpack-limit (2016-05-29) 2 commits
(merged to 'next' on 2016-05-29 at af32aba)
+ fast-import: invalidate pack_id references after loosening
(merged to 'next' on 2016-05-11 at ffd4efb)
+ fast-import: implement unpack limit
"git fast-import" learned the same performance trick to avoid
creating too small a packfile as "git fetch" and "git push" have,
using *.unpackLimit configuration.
Will hold.
* jc/send-email-skip-backup (2016-04-12) 1 commit
- send-email: detect and offer to skip backup files
A careless invocation of "git send-email directory/" after editing
0001-change.patch with an editor often ends up sending both
0001-change.patch and its backup file, 0001-change.patch~, causing
embarrassment and a minor confusion. Detect such an input and
offer to skip the backup files when sending the patches out.
Needs review.
* kn/ref-filter-branch-list (2016-05-17) 17 commits
- branch: implement '--format' option
- branch: use ref-filter printing APIs
- branch, tag: use porcelain output
- ref-filter: allow porcelain to translate messages in the output
- ref-filter: add `:dir` and `:base` options for ref printing atoms
- ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal()
- ref-filter: introduce symref_atom_parser() and refname_atom_parser()
- ref-filter: introduce refname_atom_parser_internal()
- ref-filter: make "%(symref)" atom work with the ':short' modifier
- ref-filter: add support for %(upstream:track,nobracket)
- ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreams
- ref-filter: introduce format_ref_array_item()
- ref-filter: move get_head_description() from branch.c
- ref-filter: modify "%(objectname:short)" to take length
- ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>)
- ref-filter: include reference to 'used_atom' within 'atom_value'
- ref-filter: implement %(if), %(then), and %(else) atoms
The code to list branches in "git branch" has been consolidated
with the more generic ref-filter API.
Rerolled.
Needs review.
* dt/index-helper (2016-05-20) 20 commits
- index-helper: indexhelper.exitafter config
- trace: measure where the time is spent in the index-heavy operations
- index-helper: optionally automatically run
- index-helper: autorun mode
- index-helper: don't run if already running
- index-helper: kill mode
- watchman: add a config option to enable the extension
- unpack-trees: preserve index extensions
- update-index: enable/disable watchman support
- index-helper: use watchman to avoid refreshing index with lstat()
- watchman: support watchman to reduce index refresh cost
- read-cache: add watchman 'WAMA' extension
- index-helper: log warnings
- index-helper: add --detach
- daemonize(): set a flag before exiting the main process
- index-helper: add --strict
- index-helper: new daemon for caching index and related stuff
- pkt-line: add gentle version of packet_write
- read-cache: allow to keep mmap'd memory after reading
- read-cache.c: fix constness of verify_hdr()
A new "index-helper" daemon has been introduced to give newly
spawned Git process a quicker access to the data in the index, and
optionally interface with the watchman daemon to further reduce the
refresh cost.
Rerolled.
($gmane/295106).
* jc/bundle (2016-03-03) 6 commits
- index-pack: --clone-bundle option
- Merge branch 'jc/index-pack' into jc/bundle
- bundle v3: the beginning
- bundle: keep a copy of bundle file name in the in-core bundle header
- bundle: plug resource leak
- bundle doc: 'verify' is not about verifying the bundle
The beginning of "split bundle", which could be one of the
ingredients to allow "git clone" traffic off of the core server
network to CDN.
* jc/merge-drop-old-syntax (2015-04-29) 1 commit
- merge: drop 'git merge <message> HEAD <commit>' syntax
Stop supporting "git merge <message> HEAD <commit>" syntax that has
been deprecated since October 2007, and issues a deprecation
warning message since v2.5.0.
It has been reported that git-gui still uses the deprecated syntax,
which needs to be fixed before this final step can proceed.
($gmane/282594)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken
2016-05-31 22:15 What's cooking in git.git (May 2016, #09; Tue, 31) Junio C Hamano
@ 2016-06-02 14:01 ` Torsten Bögershausen
2016-06-02 21:22 ` Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Torsten Bögershausen @ 2016-06-02 14:01 UTC (permalink / raw)
To: Junio C Hamano, git
It seams as ./t1308-config-set.sh is broken,
when the the directory is a soft link:
-name=/home/tb/NoBackup/projects/git/git.pu/t/trash
directory.t1308-config-set/.gitconfig
+name=/home/tb/projects/git/git.pu/t/trash directory.t1308-config-set/.gitconfig
scope=global
key=foo.bar
not ok 28 - iteration shows correct origins
I havent't digged further, too many conflicts in the config code, may be
somebody knows it directly ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken
2016-06-02 14:01 ` What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken Torsten Bögershausen
@ 2016-06-02 21:22 ` Junio C Hamano
2016-06-02 21:31 ` Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Junio C Hamano @ 2016-06-02 21:22 UTC (permalink / raw)
To: Torsten Bögershausen; +Cc: git
Torsten Bögershausen <tboegi@web.de> writes:
> It seams as ./t1308-config-set.sh is broken,
> when the the directory is a soft link:
>
> -name=/home/tb/NoBackup/projects/git/git.pu/t/trash
> directory.t1308-config-set/.gitconfig
> +name=/home/tb/projects/git/git.pu/t/trash directory.t1308-config-set/.gitconfig
> scope=global
It does seem that way. Somebody is affected by $PWD when we should
be consistently using the physical / real path.
>
> key=foo.bar
> not ok 28 - iteration shows correct origins
>
> I havent't digged further, too many conflicts in the config code, may be
> somebody knows it directly ?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken
2016-06-02 21:22 ` Junio C Hamano
@ 2016-06-02 21:31 ` Junio C Hamano
2016-06-02 21:39 ` Jeff King
0 siblings, 1 reply; 14+ messages in thread
From: Junio C Hamano @ 2016-06-02 21:31 UTC (permalink / raw)
To: Torsten Bögershausen; +Cc: git, Jeff King
Junio C Hamano <gitster@pobox.com> writes:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> It seams as ./t1308-config-set.sh is broken,
>> when the the directory is a soft link:
>>
>> -name=/home/tb/NoBackup/projects/git/git.pu/t/trash
>> directory.t1308-config-set/.gitconfig
>> +name=/home/tb/projects/git/git.pu/t/trash directory.t1308-config-set/.gitconfig
>> scope=global
>
> It does seem that way. Somebody is affected by $PWD when we should
> be consistently using the physical / real path.
>
>>
>> key=foo.bar
>> not ok 28 - iteration shows correct origins
>>
>> I havent't digged further, too many conflicts in the config code, may be
>> somebody knows it directly ?
Perhaps like this, taking hint from the log message of 6eafa6d0
(submodules: don't stumble over symbolic links when cloning
recursively, 2012-07-12)?
t/t1308-config-set.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index 065d5eb..1ba9ecb 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
key=foo.bar
value=from-home
origin=file
- name=$(pwd)/.gitconfig
+ name=$TRASH_DIRECTORY/.gitconfig
scope=global
key=foo.bar
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken
2016-06-02 21:31 ` Junio C Hamano
@ 2016-06-02 21:39 ` Jeff King
2016-06-02 22:15 ` [PATCH] t1308: do not get fooled by symbolic links to the source tree Junio C Hamano
0 siblings, 1 reply; 14+ messages in thread
From: Jeff King @ 2016-06-02 21:39 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Torsten Bögershausen, git
On Thu, Jun 02, 2016 at 02:31:50PM -0700, Junio C Hamano wrote:
> Perhaps like this, taking hint from the log message of 6eafa6d0
> (submodules: don't stumble over symbolic links when cloning
> recursively, 2012-07-12)?
>
> t/t1308-config-set.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
> index 065d5eb..1ba9ecb 100755
> --- a/t/t1308-config-set.sh
> +++ b/t/t1308-config-set.sh
> @@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
> key=foo.bar
> value=from-home
> origin=file
> - name=$(pwd)/.gitconfig
> + name=$TRASH_DIRECTORY/.gitconfig
> scope=global
>
> key=foo.bar
Yeah, I think it is the same issue. I think the most accurate value
there would probably be $HOME, though.
-Peff
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-02 21:39 ` Jeff King
@ 2016-06-02 22:15 ` Junio C Hamano
2016-06-02 23:16 ` Jeff King
2016-06-03 6:05 ` Johannes Sixt
0 siblings, 2 replies; 14+ messages in thread
From: Junio C Hamano @ 2016-06-02 22:15 UTC (permalink / raw)
To: Jeff King; +Cc: Torsten Bögershausen, git
When your $PWD does not match $(/bin/pwd), e.g. you have your copy
of the git source tree in one place, point it with a symbolic link,
and then "cd" to that symbolic link before running 'make test', one
of the tests in t1308 expects that the per-user configuration was
reported to have been read from the true path (i.e. relative to the
target of such a symbolic link), but the test-config program reports
a path relative to $PWD (i.e. the symbolic link).
Instead, expect a path relative to $HOME (aka $TRASH_DIRECTORY), as
per-user configuration is read from $HOME/.gitconfig and the test
framework sets these shell variables up in such a way to avoid this
problem.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
> Yeah, I think it is the same issue. I think the most accurate value
> there would probably be $HOME, though.
Thanks.
t/t1308-config-set.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index 065d5eb..cf716b4 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
key=foo.bar
value=from-home
origin=file
- name=$(pwd)/.gitconfig
+ name=$HOME/.gitconfig
scope=global
key=foo.bar
--
2.9.0-rc1-228-gd00d833
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-02 22:15 ` [PATCH] t1308: do not get fooled by symbolic links to the source tree Junio C Hamano
@ 2016-06-02 23:16 ` Jeff King
2016-06-02 23:23 ` Stefan Beller
2016-06-03 6:05 ` Johannes Sixt
1 sibling, 1 reply; 14+ messages in thread
From: Jeff King @ 2016-06-02 23:16 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Torsten Bögershausen, git
On Thu, Jun 02, 2016 at 03:15:39PM -0700, Junio C Hamano wrote:
> When your $PWD does not match $(/bin/pwd), e.g. you have your copy
> of the git source tree in one place, point it with a symbolic link,
> and then "cd" to that symbolic link before running 'make test', one
> of the tests in t1308 expects that the per-user configuration was
> reported to have been read from the true path (i.e. relative to the
> target of such a symbolic link), but the test-config program reports
> a path relative to $PWD (i.e. the symbolic link).
>
> Instead, expect a path relative to $HOME (aka $TRASH_DIRECTORY), as
> per-user configuration is read from $HOME/.gitconfig and the test
> framework sets these shell variables up in such a way to avoid this
> problem.
Looks good.
Acked-by: Jeff King <peff@peff.net>
To prevent this in the future, I switched my default --root= to point to
a symlink. I wonder if we could do something in the test suite, though,
as we did long ago by introducing "trash directory" with a space to
catch corner cases.
I guess it would be something like:
if test_have_prereq SYMLINKS
then
mkdir "$TRASH_DIRECTORY.real" &&
ln -s "$TRASH_DIRECTORY.real" "$TRASH_DIRECTORY"
else
mkdir "$TRASH_DIRECTORY"
fi
but there may be some other tweaks required (e.g., for cleanup).
-Peff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-02 23:16 ` Jeff King
@ 2016-06-02 23:23 ` Stefan Beller
2016-06-03 1:07 ` Jeff King
0 siblings, 1 reply; 14+ messages in thread
From: Stefan Beller @ 2016-06-02 23:23 UTC (permalink / raw)
To: Jeff King; +Cc: Junio C Hamano, Torsten Bögershausen, git
On Thu, Jun 2, 2016 at 4:16 PM, Jeff King <peff@peff.net> wrote:
> On Thu, Jun 02, 2016 at 03:15:39PM -0700, Junio C Hamano wrote:
>
>> When your $PWD does not match $(/bin/pwd), e.g. you have your copy
>> of the git source tree in one place, point it with a symbolic link,
>> and then "cd" to that symbolic link before running 'make test', one
>> of the tests in t1308 expects that the per-user configuration was
>> reported to have been read from the true path (i.e. relative to the
>> target of such a symbolic link), but the test-config program reports
>> a path relative to $PWD (i.e. the symbolic link).
>>
>> Instead, expect a path relative to $HOME (aka $TRASH_DIRECTORY), as
>> per-user configuration is read from $HOME/.gitconfig and the test
>> framework sets these shell variables up in such a way to avoid this
>> problem.
>
> Looks good.
>
> Acked-by: Jeff King <peff@peff.net>
>
> To prevent this in the future, I switched my default --root= to point to
> a symlink. I wonder if we could do something in the test suite, though,
> as we did long ago by introducing "trash directory" with a space to
> catch corner cases.
>
> I guess it would be something like:
>
> if test_have_prereq SYMLINKS
IIUC this would need each test to be marked with SYMLINKS
when testing with symlinks is desired. Marking a test with that
is easily forgotten, so I'd rather do it by default as:
if (system supports symlinks):
> then
> mkdir "$TRASH_DIRECTORY.real" &&
> ln -s "$TRASH_DIRECTORY.real" "$TRASH_DIRECTORY"
> else
> mkdir "$TRASH_DIRECTORY"
> fi
>
> but there may be some other tweaks required (e.g., for cleanup).
I like the idea of testing with symlinks. (Does it have performance issues
when everything goes through symlinks?)
On the other hand if we do tests by default in a symlinked path, we could
introduce errors more easily in non-symlinked path, but that is what developers
use for developing (I guess), so it's not as likely?
Thanks,
Stefan
>
> -Peff
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-02 23:23 ` Stefan Beller
@ 2016-06-03 1:07 ` Jeff King
0 siblings, 0 replies; 14+ messages in thread
From: Jeff King @ 2016-06-03 1:07 UTC (permalink / raw)
To: Stefan Beller; +Cc: Junio C Hamano, Torsten Bögershausen, git
On Thu, Jun 02, 2016 at 04:23:00PM -0700, Stefan Beller wrote:
> > To prevent this in the future, I switched my default --root= to point to
> > a symlink. I wonder if we could do something in the test suite, though,
> > as we did long ago by introducing "trash directory" with a space to
> > catch corner cases.
> >
> > I guess it would be something like:
> >
> > if test_have_prereq SYMLINKS
>
> IIUC this would need each test to be marked with SYMLINKS
> when testing with symlinks is desired. Marking a test with that
> is easily forgotten, so I'd rather do it by default as:
>
> if (system supports symlinks):
> > then
> > mkdir "$TRASH_DIRECTORY.real" &&
> > ln -s "$TRASH_DIRECTORY.real" "$TRASH_DIRECTORY"
> > else
> > mkdir "$TRASH_DIRECTORY"
> > fi
I'm not sure I understand. My intent was to say "does the system support
symlinks" in test-lib.sh when setting up the trash directory. The
test_have_prereq function asks that, AFAIK (the "test_" prefix is not
"does _this_ test require it" but just "this function is in the test
namespace").
> I like the idea of testing with symlinks. (Does it have performance issues
> when everything goes through symlinks?)
I didn't notice any on my system (running with --root pointed at a
directory, and at a symlink to that directory). It would be extra work
whenever we determine a canonical absolute path, but I suspect that is
drowned out in the noise of the rest of the test suite. Plus some minor
extra work in the `ln` and `rm` calls during test setup/teardown, but
likewise that should be a small part of the total cost.
> On the other hand if we do tests by default in a symlinked path, we could
> introduce errors more easily in non-symlinked path, but that is what developers
> use for developing (I guess), so it's not as likely?
True, but I'd be surprised if there are bugs that show up in a
non-symlinked path that _do_ show up in a symlinked one.
I'm not sure if we've seen a case where this would find an actual bug in
git, though. The cases I remember were mostly about the test suite being
picky (i.e., git canonicalizes but the expected output doesn't, or vice
versa).
-Peff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-02 22:15 ` [PATCH] t1308: do not get fooled by symbolic links to the source tree Junio C Hamano
2016-06-02 23:16 ` Jeff King
@ 2016-06-03 6:05 ` Johannes Sixt
2016-06-03 6:10 ` Jeff King
1 sibling, 1 reply; 14+ messages in thread
From: Johannes Sixt @ 2016-06-03 6:05 UTC (permalink / raw)
To: Junio C Hamano
Cc: Jeff King, Torsten Bögershausen, git, Johannes Schindelin
Am 03.06.2016 um 00:15 schrieb Junio C Hamano:
> When your $PWD does not match $(/bin/pwd), e.g. you have your copy
> of the git source tree in one place, point it with a symbolic link,
> and then "cd" to that symbolic link before running 'make test', one
> of the tests in t1308 expects that the per-user configuration was
> reported to have been read from the true path (i.e. relative to the
> target of such a symbolic link), but the test-config program reports
> a path relative to $PWD (i.e. the symbolic link).
>
> Instead, expect a path relative to $HOME (aka $TRASH_DIRECTORY), as
> per-user configuration is read from $HOME/.gitconfig and the test
> framework sets these shell variables up in such a way to avoid this
> problem.
> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
> index 065d5eb..cf716b4 100755
> --- a/t/t1308-config-set.sh
> +++ b/t/t1308-config-set.sh
> @@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
> key=foo.bar
> value=from-home
> origin=file
> - name=$(pwd)/.gitconfig
> + name=$HOME/.gitconfig
I haven't tested this, yet, but my guess is that this breaks on Windows:
test-config will produce C:/foo style path, but the updated test would
expect /c/foo style path. Dscho, do you have an idea how to fix this?
> scope=global
>
> key=foo.bar
>
-- Hannes
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-03 6:05 ` Johannes Sixt
@ 2016-06-03 6:10 ` Jeff King
2016-06-03 6:53 ` Johannes Sixt
0 siblings, 1 reply; 14+ messages in thread
From: Jeff King @ 2016-06-03 6:10 UTC (permalink / raw)
To: Johannes Sixt
Cc: Junio C Hamano, Torsten Bögershausen, git, Johannes Schindelin
On Fri, Jun 03, 2016 at 08:05:56AM +0200, Johannes Sixt wrote:
> > - name=$(pwd)/.gitconfig
> > + name=$HOME/.gitconfig
>
> I haven't tested this, yet, but my guess is that this breaks on Windows:
> test-config will produce C:/foo style path, but the updated test would
> expect /c/foo style path. Dscho, do you have an idea how to fix this?
Hmm. This should come directly from expand_user_path("~/.gitconfig")
which prepends the literal contents of the $HOME variable. It does go
through convert_slashes() afterwards, but I don't see any other
massaging (but I won't be surprised when you tell me there is some that
happens behind the scenes).
-Peff
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-03 6:10 ` Jeff King
@ 2016-06-03 6:53 ` Johannes Sixt
2016-06-03 9:19 ` Torsten Bögershausen
0 siblings, 1 reply; 14+ messages in thread
From: Johannes Sixt @ 2016-06-03 6:53 UTC (permalink / raw)
To: Jeff King
Cc: Junio C Hamano, Torsten Bögershausen, git, Johannes Schindelin
Am 03.06.2016 um 08:10 schrieb Jeff King:
> On Fri, Jun 03, 2016 at 08:05:56AM +0200, Johannes Sixt wrote:
>
>>> - name=$(pwd)/.gitconfig
>>> + name=$HOME/.gitconfig
>>
>> I haven't tested this, yet, but my guess is that this breaks on Windows:
>> test-config will produce C:/foo style path, but the updated test would
>> expect /c/foo style path. Dscho, do you have an idea how to fix this?
>
> Hmm. This should come directly from expand_user_path("~/.gitconfig")
> which prepends the literal contents of the $HOME variable. It does go
> through convert_slashes() afterwards, but I don't see any other
> massaging (but I won't be surprised when you tell me there is some that
> happens behind the scenes).
Yes, it happens behind the scenes: /c/foo absolute paths are a
convention used by the POSIX emulation layer (MSYS). When bash (an MSYS
program) runs a non-MSYS program such as git or test-config, it converts
the /c/foo paths in the environment (and argument list) to c:/foo style
because the non-MSYS programs do not understand the MSYS convention.
-- Hannes
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-03 6:53 ` Johannes Sixt
@ 2016-06-03 9:19 ` Torsten Bögershausen
2016-07-14 12:35 ` Johannes Schindelin
0 siblings, 1 reply; 14+ messages in thread
From: Torsten Bögershausen @ 2016-06-03 9:19 UTC (permalink / raw)
To: Johannes Sixt, Jeff King
Cc: Junio C Hamano, Torsten Bögershausen, git, Johannes Schindelin
On 06/03/2016 08:53 AM, Johannes Sixt wrote:
> Am 03.06.2016 um 08:10 schrieb Jeff King:
>> On Fri, Jun 03, 2016 at 08:05:56AM +0200, Johannes Sixt wrote:
>>
>>>> - name=$(pwd)/.gitconfig
>>>> + name=$HOME/.gitconfig
>>>
>>> I haven't tested this, yet, but my guess is that this breaks on
>>> Windows:
>>> test-config will produce C:/foo style path, but the updated test would
>>> expect /c/foo style path. Dscho, do you have an idea how to fix this?
>>
>> Hmm. This should come directly from expand_user_path("~/.gitconfig")
>> which prepends the literal contents of the $HOME variable. It does go
>> through convert_slashes() afterwards, but I don't see any other
>> massaging (but I won't be surprised when you tell me there is some that
>> happens behind the scenes).
>
> Yes, it happens behind the scenes: /c/foo absolute paths are a
> convention used by the POSIX emulation layer (MSYS). When bash (an
> MSYS program) runs a non-MSYS program such as git or test-config, it
> converts the /c/foo paths in the environment (and argument list) to
> c:/foo style because the non-MSYS programs do not understand the MSYS
> convention.
>
> -- Hannes
Compiling pu didn't succed:
unix_stream_connect is missing in read_cache.c
(And many more in index-heloer.c)
(I thought that the index-helper is only compiled on systems,
which are known to have unix-sockets and other stuff ?)
After patching that out, t1308 fails:
-name=/c/
+name=c:/
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree
2016-06-03 9:19 ` Torsten Bögershausen
@ 2016-07-14 12:35 ` Johannes Schindelin
0 siblings, 0 replies; 14+ messages in thread
From: Johannes Schindelin @ 2016-07-14 12:35 UTC (permalink / raw)
To: Torsten Bögershausen; +Cc: Johannes Sixt, Jeff King, Junio C Hamano, git
[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]
Hi,
On Fri, 3 Jun 2016, Torsten Bögershausen wrote:
> On 06/03/2016 08:53 AM, Johannes Sixt wrote:
> > Am 03.06.2016 um 08:10 schrieb Jeff King:
> > > On Fri, Jun 03, 2016 at 08:05:56AM +0200, Johannes Sixt wrote:
> > >
> > > > > - name=$(pwd)/.gitconfig
> > > > > + name=$HOME/.gitconfig
> > > >
> > > > I haven't tested this, yet, but my guess is that this breaks on Windows:
> > > > test-config will produce C:/foo style path, but the updated test would
> > > > expect /c/foo style path. Dscho, do you have an idea how to fix this?
> > >
> > > Hmm. This should come directly from expand_user_path("~/.gitconfig")
> > > which prepends the literal contents of the $HOME variable. It does go
> > > through convert_slashes() afterwards, but I don't see any other
> > > massaging (but I won't be surprised when you tell me there is some that
> > > happens behind the scenes).
> >
> > Yes, it happens behind the scenes: /c/foo absolute paths are a convention
> > used by the POSIX emulation layer (MSYS). When bash (an MSYS program) runs a
> > non-MSYS program such as git or test-config, it converts the /c/foo paths in
> > the environment (and argument list) to c:/foo style because the non-MSYS
> > programs do not understand the MSYS convention.
> >
> > -- Hannes
> Compiling pu didn't succed:
> unix_stream_connect is missing in read_cache.c
>
> (And many more in index-heloer.c)
>
> (I thought that the index-helper is only compiled on systems,
> which are known to have unix-sockets and other stuff ?)
>
> After patching that out, t1308 fails:
> -name=/c/
> +name=c:/
This issue was not resolved, and now this commit is on `master`...
Ciao,
Dscho
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-07-14 12:35 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-31 22:15 What's cooking in git.git (May 2016, #09; Tue, 31) Junio C Hamano
2016-06-02 14:01 ` What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken Torsten Bögershausen
2016-06-02 21:22 ` Junio C Hamano
2016-06-02 21:31 ` Junio C Hamano
2016-06-02 21:39 ` Jeff King
2016-06-02 22:15 ` [PATCH] t1308: do not get fooled by symbolic links to the source tree Junio C Hamano
2016-06-02 23:16 ` Jeff King
2016-06-02 23:23 ` Stefan Beller
2016-06-03 1:07 ` Jeff King
2016-06-03 6:05 ` Johannes Sixt
2016-06-03 6:10 ` Jeff King
2016-06-03 6:53 ` Johannes Sixt
2016-06-03 9:19 ` Torsten Bögershausen
2016-07-14 12:35 ` Johannes Schindelin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.