[PATCH 1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible

[PATCH 1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible

[Luca Weiss]

The NQ310 is another NFC chip from NXP, document the compatible in the
bindings.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
index b2558421268a..6924aff0b2c5 100644
--- a/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml
@@ -14,7 +14,9 @@ properties:
     oneOf:
       - const: nxp,nxp-nci-i2c
       - items:
-          - const: nxp,pn547
+          - enum:
+              - nxp,nq310
+              - nxp,pn547
           - const: nxp,nxp-nci-i2c
 
   enable-gpios:
-- 
2.38.1

[PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC

[Luca Weiss]

Configure the node for the NQ310 chip found on this device, which is
compatible with generic nxp-nci-i2c driver.

Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
 arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
index 2920504461d3..fde93cbcd180 100644
--- a/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
+++ b/arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts
@@ -63,6 +63,21 @@ touchscreen@48 {
 	};
 };
 
+&i2c_5 {
+	status = "okay";
+
+	nfc@28 {
+		compatible = "nxp,nq310", "nxp,nxp-nci-i2c";
+		reg = <0x28>;
+
+		interrupt-parent = <&tlmm>;
+		interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
+
+		enable-gpios = <&tlmm 16 GPIO_ACTIVE_HIGH>;
+		firmware-gpios = <&tlmm 62 GPIO_ACTIVE_HIGH>;
+	};
+};
+
 &pm8953_resin {
 	status = "okay";
 	linux,code = <KEY_VOLUMEDOWN>;
-- 
2.38.1

Re: [PATCH 1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible

[Krzysztof Kozlowski]

On 19/11/2022 16:39, Luca Weiss wrote:
> The NQ310 is another NFC chip from NXP, document the compatible in the
> bindings.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)'

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: dts: qcom: sdm632-fairphone-fp3: Add NFC

[Krzysztof Kozlowski]

On 19/11/2022 16:39, Luca Weiss wrote:
> Configure the node for the NQ310 chip found on this device, which is
> compatible with generic nxp-nci-i2c driver.
> 
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
>  arch/arm64/boot/dts/qcom/sdm632-fairphone-fp3.dts | 15 +++++++++++++++

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: nfc: nxp,nci: Document NQ310 compatible

[Luca Weiss]

Hi Krzysztof,

On Mittwoch, 23. November 2022 17:00:08 CET Krzysztof Kozlowski wrote:
> On 19/11/2022 16:39, Luca Weiss wrote:
> > The NQ310 is another NFC chip from NXP, document the compatible in the
> > bindings.
> > 
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> > 
> >  Documentation/devicetree/bindings/net/nfc/nxp,nci.yaml | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)'
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.

I seemed to have messed up my send-email invocation. Will resend with proper 
CC soon.
Thanks for letting me know!

> 
> Best regards,
> Krzysztof