All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-stable <stable@vger.kernel.org>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
Date: Mon, 28 Jun 2021 15:10:36 +0200	[thread overview]
Message-ID: <7137f147-f127-2884-39e7-7cfabe9e2bfc@denx.de> (raw)
In-Reply-To: <YNnIXjGyvaQgf2wP@kroah.com>

On 6/28/21 3:02 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
>> On 6/28/21 2:29 PM, Greg KH wrote:
>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>>>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>>>> enabled when the nRST is toggled according to datasheet Microchip
>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>>>
>>>> [...]
>>>>
>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>>>
>>>> Adding stable to CC.
>>>>
>>>> Patch is now part of Linux 5.13 as commit
>>>>
>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
>>>
>>> $ git show 1cebcf9932ab
>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
>>> Use '--' to separate paths from revisions, like this:
>>> 'git <command> [<revision>...] -- [<file>...]'
>>>
>>> Are you sure?
>>
>> This would seem to indicate so:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
>>
>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
>> v5.13-rc1-1-g1cebcf9932ab
>>
>> Did the commit get abbreviated too much ?
> 
> Something is really odd, as that commit _is_ in linux-next, but it is
> not in my local copy of Linus's tree.
> 
> So how it is showing up in that link above is beyond me.  Can you see it
> locally on your machine?

Yes, that's where the git describe came from. And I used a different 
repo than the one from which I submitted the patch originally, so the 
commit must've come from fetching origin (i.e. linus tree).

Could it be this "ambiguous argument '1cebcf9932ab'" , which would 
indicate the commit hash got abbreviated too much ?

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-stable <stable@vger.kernel.org>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Patrick Delaunay <patrick.delaunay@st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
Date: Mon, 28 Jun 2021 15:10:36 +0200	[thread overview]
Message-ID: <7137f147-f127-2884-39e7-7cfabe9e2bfc@denx.de> (raw)
In-Reply-To: <YNnIXjGyvaQgf2wP@kroah.com>

On 6/28/21 3:02 PM, Greg KH wrote:
> On Mon, Jun 28, 2021 at 02:32:50PM +0200, Marek Vasut wrote:
>> On 6/28/21 2:29 PM, Greg KH wrote:
>>> On Mon, Jun 28, 2021 at 12:44:37PM +0200, Marek Vasut wrote:
>>>> On 4/9/21 1:00 AM, Marek Vasut wrote:
>>>>> The Microchip LAN8710Ai PHY requires XTAL1/CLKIN external clock to be
>>>>> enabled when the nRST is toggled according to datasheet Microchip
>>>>> LAN8710A/LAN8710Ai DS00002164B page 35 section 3.8.5.1 Hardware Reset:
>>>>
>>>> [...]
>>>>
>>>>> Fixes: 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
>>>>
>>>> Adding stable to CC.
>>>>
>>>> Patch is now part of Linux 5.13 as commit
>>>>
>>>> 1cebcf9932ab ("ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM")
>>>
>>> $ git show 1cebcf9932ab
>>> fatal: ambiguous argument '1cebcf9932ab': unknown revision or path not in the working tree.
>>> Use '--' to separate paths from revisions, like this:
>>> 'git <command> [<revision>...] -- [<file>...]'
>>>
>>> Are you sure?
>>
>> This would seem to indicate so:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1cebcf9932ab76102e8cfc555879574693ba8956
>>
>> linux-2.6$ git describe 1cebcf9932ab76102e8cfc555879574693ba8956
>> v5.13-rc1-1-g1cebcf9932ab
>>
>> Did the commit get abbreviated too much ?
> 
> Something is really odd, as that commit _is_ in linux-next, but it is
> not in my local copy of Linus's tree.
> 
> So how it is showing up in that link above is beyond me.  Can you see it
> locally on your machine?

Yes, that's where the git describe came from. And I used a different 
repo than the one from which I submitted the patch originally, so the 
commit must've come from fetching origin (i.e. linus tree).

Could it be this "ambiguous argument '1cebcf9932ab'" , which would 
indicate the commit hash got abbreviated too much ?

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-28 13:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 23:00 [PATCH] ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM Marek Vasut
2021-06-01  6:50 ` Alexandre TORGUE
2021-06-28 10:44 ` Marek Vasut
2021-06-28 10:44   ` Marek Vasut
2021-06-28 12:29   ` Greg KH
2021-06-28 12:29     ` Greg KH
2021-06-28 12:32     ` Marek Vasut
2021-06-28 12:32       ` Marek Vasut
2021-06-28 13:02       ` Greg KH
2021-06-28 13:02         ` Greg KH
2021-06-28 13:10         ` Marek Vasut [this message]
2021-06-28 13:10           ` Marek Vasut
2021-06-28 13:38           ` Greg KH
2021-06-28 13:38             ` Greg KH
2021-06-28 13:58             ` Marek Vasut
2021-06-28 13:58               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7137f147-f127-2884-39e7-7cfabe9e2bfc@denx.de \
    --to=marex@denx.de \
    --cc=alexandre.torgue@st.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=patrice.chotard@st.com \
    --cc=patrick.delaunay@st.com \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.