From: Robin Murphy <robin.murphy@arm.com> To: Jeffy Chen <jeffy.chen@rock-chips.com>, linux-kernel@vger.kernel.org Cc: jcliang@chromium.org, xxm@rock-chips.com, tfiga@chromium.org, Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org, iommu@lists.linux-foundation.org, Joerg Roedel <joro@8bytes.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 01/14] iommu/rockchip: Prohibit unbind and remove Date: Wed, 7 Mar 2018 12:55:54 +0000 [thread overview] Message-ID: <713e01c9-4850-dd03-841f-060c1eec1cbd@arm.com> (raw) In-Reply-To: <20180306030252.3197-2-jeffy.chen@rock-chips.com> On 06/03/18 03:02, Jeffy Chen wrote: > Removal of IOMMUs cannot be done reliably. > > This is similar to exynos iommu driver. Acked-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > Reviewed-by: Tomasz Figa <tfiga@chromium.org> > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: > Rewrite commit message. > > Changes in v3: > Also remove remove() and module_exit() as Tomasz suggested. > > Changes in v2: None > > drivers/iommu/rockchip-iommu.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c > index 9d991c2d8767..16cd8780c289 100644 > --- a/drivers/iommu/rockchip-iommu.c > +++ b/drivers/iommu/rockchip-iommu.c > @@ -1197,18 +1197,6 @@ static int rk_iommu_probe(struct platform_device *pdev) > return err; > } > > -static int rk_iommu_remove(struct platform_device *pdev) > -{ > - struct rk_iommu *iommu = platform_get_drvdata(pdev); > - > - if (iommu) { > - iommu_device_sysfs_remove(&iommu->iommu); > - iommu_device_unregister(&iommu->iommu); > - } > - > - return 0; > -} > - > static const struct of_device_id rk_iommu_dt_ids[] = { > { .compatible = "rockchip,iommu" }, > { /* sentinel */ } > @@ -1217,10 +1205,10 @@ MODULE_DEVICE_TABLE(of, rk_iommu_dt_ids); > > static struct platform_driver rk_iommu_driver = { > .probe = rk_iommu_probe, > - .remove = rk_iommu_remove, > .driver = { > .name = "rk_iommu", > .of_match_table = rk_iommu_dt_ids, > + .suppress_bind_attrs = true, > }, > }; > > @@ -1248,14 +1236,7 @@ static int __init rk_iommu_init(void) > platform_driver_unregister(&rk_iommu_domain_driver); > return ret; > } > -static void __exit rk_iommu_exit(void) > -{ > - platform_driver_unregister(&rk_iommu_driver); > - platform_driver_unregister(&rk_iommu_domain_driver); > -} > - > subsys_initcall(rk_iommu_init); > -module_exit(rk_iommu_exit); > > MODULE_DESCRIPTION("IOMMU API for Rockchip"); > MODULE_AUTHOR("Simon Xue <xxm@rock-chips.com> and Daniel Kurtz <djkurtz@chromium.org>"); >
WARNING: multiple messages have this Message-ID (diff)
From: robin.murphy@arm.com (Robin Murphy) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 01/14] iommu/rockchip: Prohibit unbind and remove Date: Wed, 7 Mar 2018 12:55:54 +0000 [thread overview] Message-ID: <713e01c9-4850-dd03-841f-060c1eec1cbd@arm.com> (raw) In-Reply-To: <20180306030252.3197-2-jeffy.chen@rock-chips.com> On 06/03/18 03:02, Jeffy Chen wrote: > Removal of IOMMUs cannot be done reliably. > > This is similar to exynos iommu driver. Acked-by: Robin Murphy <robin.murphy@arm.com> > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > Reviewed-by: Tomasz Figa <tfiga@chromium.org> > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: > Rewrite commit message. > > Changes in v3: > Also remove remove() and module_exit() as Tomasz suggested. > > Changes in v2: None > > drivers/iommu/rockchip-iommu.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c > index 9d991c2d8767..16cd8780c289 100644 > --- a/drivers/iommu/rockchip-iommu.c > +++ b/drivers/iommu/rockchip-iommu.c > @@ -1197,18 +1197,6 @@ static int rk_iommu_probe(struct platform_device *pdev) > return err; > } > > -static int rk_iommu_remove(struct platform_device *pdev) > -{ > - struct rk_iommu *iommu = platform_get_drvdata(pdev); > - > - if (iommu) { > - iommu_device_sysfs_remove(&iommu->iommu); > - iommu_device_unregister(&iommu->iommu); > - } > - > - return 0; > -} > - > static const struct of_device_id rk_iommu_dt_ids[] = { > { .compatible = "rockchip,iommu" }, > { /* sentinel */ } > @@ -1217,10 +1205,10 @@ MODULE_DEVICE_TABLE(of, rk_iommu_dt_ids); > > static struct platform_driver rk_iommu_driver = { > .probe = rk_iommu_probe, > - .remove = rk_iommu_remove, > .driver = { > .name = "rk_iommu", > .of_match_table = rk_iommu_dt_ids, > + .suppress_bind_attrs = true, > }, > }; > > @@ -1248,14 +1236,7 @@ static int __init rk_iommu_init(void) > platform_driver_unregister(&rk_iommu_domain_driver); > return ret; > } > -static void __exit rk_iommu_exit(void) > -{ > - platform_driver_unregister(&rk_iommu_driver); > - platform_driver_unregister(&rk_iommu_domain_driver); > -} > - > subsys_initcall(rk_iommu_init); > -module_exit(rk_iommu_exit); > > MODULE_DESCRIPTION("IOMMU API for Rockchip"); > MODULE_AUTHOR("Simon Xue <xxm@rock-chips.com> and Daniel Kurtz <djkurtz@chromium.org>"); >
next prev parent reply other threads:[~2018-03-07 12:55 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-06 3:02 [PATCH v7 00/14] iommu/rockchip: Use OF_IOMMU Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-06 3:02 ` [PATCH v7 01/14] iommu/rockchip: Prohibit unbind and remove Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-07 12:55 ` Robin Murphy [this message] 2018-03-07 12:55 ` Robin Murphy 2018-03-06 3:02 ` [PATCH v7 02/14] iommu/rockchip: Fix error handling in probe Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-07 12:59 ` Robin Murphy 2018-03-07 12:59 ` Robin Murphy 2018-03-07 12:59 ` Robin Murphy 2018-03-06 3:02 ` [PATCH v7 03/14] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-06 3:02 ` Jeffy Chen 2018-03-07 13:00 ` Robin Murphy 2018-03-07 13:00 ` Robin Murphy 2018-03-07 13:00 ` Robin Murphy 2018-03-06 3:21 ` [PATCH v7 04/14] iommu/rockchip: Fix error handling in attach Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` [PATCH v7 05/14] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` [PATCH v7 06/14] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` [PATCH v7 07/14] ARM: dts: rockchip: add clocks in iommu nodes Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` [PATCH v7 08/14] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-06 3:21 ` [PATCH v7 09/14] dt-bindings: iommu/rockchip: Add clock property Jeffy Chen 2018-03-06 3:21 ` Jeffy Chen 2018-03-07 13:01 ` Robin Murphy 2018-03-07 13:01 ` Robin Murphy 2018-03-07 13:01 ` Robin Murphy 2018-03-06 3:27 ` [PATCH v7 10/14] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` [PATCH v7 11/14] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` [PATCH v7 12/14] iommu/rockchip: Fix error handling in init Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` [PATCH v7 13/14] iommu/rockchip: Add runtime PM support Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen 2018-03-06 10:07 ` Tomasz Figa 2018-03-06 10:07 ` Tomasz Figa 2018-03-06 10:07 ` Tomasz Figa [not found] ` <CAAFQd5DPewKda7ThqMGKRvnArZ0X8ChD10E06nLZaNa-SBNdwA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-03-07 3:16 ` JeffyChen 2018-03-07 3:26 ` Tomasz Figa 2018-03-07 3:26 ` Tomasz Figa 2018-03-07 3:24 ` Tomasz Figa 2018-03-07 3:24 ` Tomasz Figa 2018-03-06 3:27 ` [PATCH v7 14/14] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen 2018-03-06 3:27 ` Jeffy Chen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=713e01c9-4850-dd03-841f-060c1eec1cbd@arm.com \ --to=robin.murphy@arm.com \ --cc=heiko@sntech.de \ --cc=iommu@lists.linux-foundation.org \ --cc=jcliang@chromium.org \ --cc=jeffy.chen@rock-chips.com \ --cc=joro@8bytes.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=tfiga@chromium.org \ --cc=xxm@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.