From: Benjamin Berg <benjamin-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [BUG] NULL pointer de-ref when setting io.cost.qos on LUKS devices
Date: Thu, 05 Mar 2020 11:31:29 +0100 [thread overview]
Message-ID: <71515f7a143937ab9ab11625485659bb7288f024.camel@sipsolutions.net> (raw)
In-Reply-To: <20200304164205.GH189690-146+VewaZzwNjtGbbfXrCEEOCMrvLtNR@public.gmane.org> (sfid-20200304_174209_151624_50E7536A)
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On Wed, 2020-03-04 at 11:42 -0500, Tejun Heo wrote:
> [SNIP]
>
> Right now, the situation isn't great with dm. When pagecache
> writebacks go through dm, in some cases including dm-crypt, the cgroup
> ownership information is completely lost and all writes end up being
> issued as the root cgroup, so it breaks down when dm is in use.
Fair enough.
> In the longer term, what we wanna do is controlling at physical
> devices (sda here) and then updating dm so that it can maintain and
> propagate the ownership correctly but we aren't there yet.
Perfect, so what I am seeing is really just a small systemd bug. Thansk
for confirming, I'll submit a patch to fix it.
Benjamin
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-05 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 14:13 [BUG] NULL pointer de-ref when setting io.cost.qos on LUKS devices Benjamin Berg
[not found] ` <1dbdcbb0c8db70a08aac467311a80abcf7779575.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2020-03-03 14:19 ` Tejun Heo
[not found] ` <20200303141902.GB189690-146+VewaZzwNjtGbbfXrCEEOCMrvLtNR@public.gmane.org>
2020-03-03 14:40 ` Benjamin Berg
[not found] ` <24bd31cdaa3ea945908bc11cea05d6aae6929240.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2020-03-04 16:42 ` Tejun Heo
[not found] ` <20200304164205.GH189690-146+VewaZzwNjtGbbfXrCEEOCMrvLtNR@public.gmane.org>
2020-03-05 10:31 ` Benjamin Berg [this message]
[not found] ` <71515f7a143937ab9ab11625485659bb7288f024.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2020-03-05 15:20 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71515f7a143937ab9ab11625485659bb7288f024.camel@sipsolutions.net \
--to=benjamin-cdvu00un1vgdhxzaddlk8q@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.