* [U-Boot] [PATCH] cmd: load: align cache flush
@ 2016-10-25 7:22 Chris Packham
2016-10-25 7:35 ` Stefan Roese
2016-11-02 14:26 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Chris Packham @ 2016-10-25 7:22 UTC (permalink / raw)
To: u-boot
Prevent cache misalignment message by ensuring that a whole cache line
is flushed.
Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
cmd/load.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmd/load.c b/cmd/load.c
index 65557e4f9ec3..77c3359b29b7 100644
--- a/cmd/load.c
+++ b/cmd/load.c
@@ -997,7 +997,7 @@ static ulong load_serial_ymodem(ulong offset, int mode)
xyzModem_stream_terminate(false, &getcxmodem);
- flush_cache(offset, size);
+ flush_cache(offset, ALIGN(size, ARCH_DMA_MINALIGN));
printf("## Total Size = 0x%08x = %d Bytes\n", size, size);
setenv_hex("filesize", size);
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] cmd: load: align cache flush
2016-10-25 7:22 [U-Boot] [PATCH] cmd: load: align cache flush Chris Packham
@ 2016-10-25 7:35 ` Stefan Roese
2016-11-02 14:26 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2016-10-25 7:35 UTC (permalink / raw)
To: u-boot
On 25.10.2016 09:22, Chris Packham wrote:
> Prevent cache misalignment message by ensuring that a whole cache line
> is flushed.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>
> cmd/load.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/load.c b/cmd/load.c
> index 65557e4f9ec3..77c3359b29b7 100644
> --- a/cmd/load.c
> +++ b/cmd/load.c
> @@ -997,7 +997,7 @@ static ulong load_serial_ymodem(ulong offset, int mode)
> xyzModem_stream_terminate(false, &getcxmodem);
>
>
> - flush_cache(offset, size);
> + flush_cache(offset, ALIGN(size, ARCH_DMA_MINALIGN));
>
> printf("## Total Size = 0x%08x = %d Bytes\n", size, size);
> setenv_hex("filesize", size);
>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] cmd: load: align cache flush
2016-10-25 7:22 [U-Boot] [PATCH] cmd: load: align cache flush Chris Packham
2016-10-25 7:35 ` Stefan Roese
@ 2016-11-02 14:26 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2016-11-02 14:26 UTC (permalink / raw)
To: u-boot
On Tue, Oct 25, 2016 at 08:22:48PM +1300, Chris Packham wrote:
> Prevent cache misalignment message by ensuring that a whole cache line
> is flushed.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied to u-boot/master (before v2016.11-rc3), thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161102/9bc1cf69/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-02 14:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 7:22 [U-Boot] [PATCH] cmd: load: align cache flush Chris Packham
2016-10-25 7:35 ` Stefan Roese
2016-11-02 14:26 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.