* [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 14:43 ` trix
0 siblings, 0 replies; 12+ messages in thread
From: trix @ 2020-10-19 14:43 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira,
Tony.Cheng, Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr,
Igor.Kravchenko, colin.king, tao.zhou1, Dennis.Li,
mario.kleiner.de
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return or break
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
7 files changed, 43 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
index 2a32b66959ba..130a0a0c8332 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
REG_SET(OUTPUT_CSC_CONTROL, 0,
OUTPUT_CSC_GRPH_MODE, 0);
break;
- break;
case COLOR_SPACE_SRGB_LIMITED:
/* TV RGB */
REG_SET(OUTPUT_CSC_CONTROL, 0,
diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
index d741787f75dc..42c7d157da32 100644
--- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
index 2bbfa2e176a9..382581c4a674 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
index b622b4b1dac3..7b4b2304bbff 100644
--- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
index 16fe7344702f..3d782b7c86cb 100644
--- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
index 5a5a9cb77acb..e9dd78c484d6 100644
--- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
index 0eae8cd35f9a..9dbf658162cd 100644
--- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
--
2.18.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 14:43 ` trix
0 siblings, 0 replies; 12+ messages in thread
From: trix @ 2020-10-19 14:43 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira,
Tony.Cheng, Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr,
Igor.Kravchenko, colin.king, tao.zhou1, Dennis.Li,
mario.kleiner.de
Cc: Tom Rix, dri-devel, amd-gfx, linux-kernel
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return or break
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
7 files changed, 43 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
index 2a32b66959ba..130a0a0c8332 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
REG_SET(OUTPUT_CSC_CONTROL, 0,
OUTPUT_CSC_GRPH_MODE, 0);
break;
- break;
case COLOR_SPACE_SRGB_LIMITED:
/* TV RGB */
REG_SET(OUTPUT_CSC_CONTROL, 0,
diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
index d741787f75dc..42c7d157da32 100644
--- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
index 2bbfa2e176a9..382581c4a674 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
index b622b4b1dac3..7b4b2304bbff 100644
--- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
index 16fe7344702f..3d782b7c86cb 100644
--- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
index 5a5a9cb77acb..e9dd78c484d6 100644
--- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
index 0eae8cd35f9a..9dbf658162cd 100644
--- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
--
2.18.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 14:43 ` trix
0 siblings, 0 replies; 12+ messages in thread
From: trix @ 2020-10-19 14:43 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira,
Tony.Cheng, Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr,
Igor.Kravchenko, colin.king, tao.zhou1, Dennis.Li,
mario.kleiner.de
Cc: Tom Rix, dri-devel, amd-gfx, linux-kernel
From: Tom Rix <trix@redhat.com>
A break is not needed if it is preceded by a return or break
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
7 files changed, 43 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
index 2a32b66959ba..130a0a0c8332 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
@@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
REG_SET(OUTPUT_CSC_CONTROL, 0,
OUTPUT_CSC_GRPH_MODE, 0);
break;
- break;
case COLOR_SPACE_SRGB_LIMITED:
/* TV RGB */
REG_SET(OUTPUT_CSC_CONTROL, 0,
diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
index d741787f75dc..42c7d157da32 100644
--- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
@@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
index 2bbfa2e176a9..382581c4a674 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
@@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
index b622b4b1dac3..7b4b2304bbff 100644
--- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
@@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
index 16fe7344702f..3d782b7c86cb 100644
--- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
@@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
index 5a5a9cb77acb..e9dd78c484d6 100644
--- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
@@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
index 0eae8cd35f9a..9dbf658162cd 100644
--- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
@@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
switch (transmitter) {
case TRANSMITTER_UNIPHY_A:
return 0;
- break;
case TRANSMITTER_UNIPHY_B:
return 1;
- break;
case TRANSMITTER_UNIPHY_C:
return 2;
- break;
case TRANSMITTER_UNIPHY_D:
return 3;
- break;
case TRANSMITTER_UNIPHY_E:
return 4;
- break;
case TRANSMITTER_UNIPHY_F:
return 5;
- break;
case TRANSMITTER_UNIPHY_G:
return 6;
- break;
default:
ASSERT(0);
return 0;
--
2.18.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
2020-10-19 14:43 ` trix
(?)
@ 2020-10-19 14:55 ` Christian König
-1 siblings, 0 replies; 12+ messages in thread
From: Christian König @ 2020-10-19 14:55 UTC (permalink / raw)
To: trix, harry.wentland, sunpeng.li, alexander.deucher, airlied,
daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira, Tony.Cheng,
Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr, Igor.Kravchenko,
colin.king, tao.zhou1, Dennis.Li, mario.kleiner.de
Cc: amd-gfx, dri-devel, linux-kernel
Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
> 7 files changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> index 2a32b66959ba..130a0a0c8332 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
> REG_SET(OUTPUT_CSC_CONTROL, 0,
> OUTPUT_CSC_GRPH_MODE, 0);
> break;
> - break;
> case COLOR_SPACE_SRGB_LIMITED:
> /* TV RGB */
> REG_SET(OUTPUT_CSC_CONTROL, 0,
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> index d741787f75dc..42c7d157da32 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 2bbfa2e176a9..382581c4a674 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index b622b4b1dac3..7b4b2304bbff 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 16fe7344702f..3d782b7c86cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> index 5a5a9cb77acb..e9dd78c484d6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> index 0eae8cd35f9a..9dbf658162cd 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 14:55 ` Christian König
0 siblings, 0 replies; 12+ messages in thread
From: Christian König @ 2020-10-19 14:55 UTC (permalink / raw)
To: trix, harry.wentland, sunpeng.li, alexander.deucher, airlied,
daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira, Tony.Cheng,
Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr, Igor.Kravchenko,
colin.king, tao.zhou1, Dennis.Li, mario.kleiner.de
Cc: dri-devel, amd-gfx, linux-kernel
Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
> 7 files changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> index 2a32b66959ba..130a0a0c8332 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
> REG_SET(OUTPUT_CSC_CONTROL, 0,
> OUTPUT_CSC_GRPH_MODE, 0);
> break;
> - break;
> case COLOR_SPACE_SRGB_LIMITED:
> /* TV RGB */
> REG_SET(OUTPUT_CSC_CONTROL, 0,
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> index d741787f75dc..42c7d157da32 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 2bbfa2e176a9..382581c4a674 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index b622b4b1dac3..7b4b2304bbff 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 16fe7344702f..3d782b7c86cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> index 5a5a9cb77acb..e9dd78c484d6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> index 0eae8cd35f9a..9dbf658162cd 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 14:55 ` Christian König
0 siblings, 0 replies; 12+ messages in thread
From: Christian König @ 2020-10-19 14:55 UTC (permalink / raw)
To: trix, harry.wentland, sunpeng.li, alexander.deucher, airlied,
daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira, Tony.Cheng,
Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr, Igor.Kravchenko,
colin.king, tao.zhou1, Dennis.Li, mario.kleiner.de
Cc: dri-devel, amd-gfx, linux-kernel
Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or break
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
> 7 files changed, 43 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> index 2a32b66959ba..130a0a0c8332 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
> REG_SET(OUTPUT_CSC_CONTROL, 0,
> OUTPUT_CSC_GRPH_MODE, 0);
> break;
> - break;
> case COLOR_SPACE_SRGB_LIMITED:
> /* TV RGB */
> REG_SET(OUTPUT_CSC_CONTROL, 0,
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> index d741787f75dc..42c7d157da32 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 2bbfa2e176a9..382581c4a674 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index b622b4b1dac3..7b4b2304bbff 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 16fe7344702f..3d782b7c86cb 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> index 5a5a9cb77acb..e9dd78c484d6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> index 0eae8cd35f9a..9dbf658162cd 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
> switch (transmitter) {
> case TRANSMITTER_UNIPHY_A:
> return 0;
> - break;
> case TRANSMITTER_UNIPHY_B:
> return 1;
> - break;
> case TRANSMITTER_UNIPHY_C:
> return 2;
> - break;
> case TRANSMITTER_UNIPHY_D:
> return 3;
> - break;
> case TRANSMITTER_UNIPHY_E:
> return 4;
> - break;
> case TRANSMITTER_UNIPHY_F:
> return 5;
> - break;
> case TRANSMITTER_UNIPHY_G:
> return 6;
> - break;
> default:
> ASSERT(0);
> return 0;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
2020-10-19 14:55 ` Christian König
(?)
@ 2020-10-19 15:08 ` Harry Wentland
-1 siblings, 0 replies; 12+ messages in thread
From: Harry Wentland @ 2020-10-19 15:08 UTC (permalink / raw)
To: Christian König, trix, sunpeng.li, alexander.deucher,
airlied, daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira,
Tony.Cheng, Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr,
Igor.Kravchenko, colin.king, tao.zhou1, Dennis.Li,
mario.kleiner.de
Cc: amd-gfx, dri-devel, linux-kernel
On 2020-10-19 10:55 a.m., Christian König wrote:
> Am 19.10.20 um 16:43 schrieb trix@redhat.com:
>> From: Tom Rix <trix@redhat.com>
>>
>> A break is not needed if it is preceded by a return or break
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
>
>> ---
>> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
>> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
>> 7 files changed, 43 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> index 2a32b66959ba..130a0a0c8332 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
>> REG_SET(OUTPUT_CSC_CONTROL, 0,
>> OUTPUT_CSC_GRPH_MODE, 0);
>> break;
>> - break;
>> case COLOR_SPACE_SRGB_LIMITED:
>> /* TV RGB */
>> REG_SET(OUTPUT_CSC_CONTROL, 0,
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> index d741787f75dc..42c7d157da32 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> index 2bbfa2e176a9..382581c4a674 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> index b622b4b1dac3..7b4b2304bbff 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> index 16fe7344702f..3d782b7c86cb 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> index 5a5a9cb77acb..e9dd78c484d6 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> index 0eae8cd35f9a..9dbf658162cd 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 15:08 ` Harry Wentland
0 siblings, 0 replies; 12+ messages in thread
From: Harry Wentland @ 2020-10-19 15:08 UTC (permalink / raw)
To: Christian König, trix, sunpeng.li, alexander.deucher,
airlied, daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira,
Tony.Cheng, Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr,
Igor.Kravchenko, colin.king, tao.zhou1, Dennis.Li,
mario.kleiner.de
Cc: dri-devel, amd-gfx, linux-kernel
On 2020-10-19 10:55 a.m., Christian König wrote:
> Am 19.10.20 um 16:43 schrieb trix@redhat.com:
>> From: Tom Rix <trix@redhat.com>
>>
>> A break is not needed if it is preceded by a return or break
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
>
>> ---
>> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
>> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
>> 7 files changed, 43 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> index 2a32b66959ba..130a0a0c8332 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
>> REG_SET(OUTPUT_CSC_CONTROL, 0,
>> OUTPUT_CSC_GRPH_MODE, 0);
>> break;
>> - break;
>> case COLOR_SPACE_SRGB_LIMITED:
>> /* TV RGB */
>> REG_SET(OUTPUT_CSC_CONTROL, 0,
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> index d741787f75dc..42c7d157da32 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> index 2bbfa2e176a9..382581c4a674 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> index b622b4b1dac3..7b4b2304bbff 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> index 16fe7344702f..3d782b7c86cb 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> index 5a5a9cb77acb..e9dd78c484d6 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> index 0eae8cd35f9a..9dbf658162cd 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-19 15:08 ` Harry Wentland
0 siblings, 0 replies; 12+ messages in thread
From: Harry Wentland @ 2020-10-19 15:08 UTC (permalink / raw)
To: Christian König, trix, sunpeng.li, alexander.deucher,
airlied, daniel, issor.oruam, Anthony.Koo, Rodrigo.Siqueira,
Tony.Cheng, Charlene.Liu, yogesh.mohanmarimuthu, Aric.Cyr,
Igor.Kravchenko, colin.king, tao.zhou1, Dennis.Li,
mario.kleiner.de
Cc: dri-devel, amd-gfx, linux-kernel
On 2020-10-19 10:55 a.m., Christian König wrote:
> Am 19.10.20 um 16:43 schrieb trix@redhat.com:
>> From: Tom Rix <trix@redhat.com>
>>
>> A break is not needed if it is preceded by a return or break
>>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>
> Acked-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
>
>> ---
>> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
>> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
>> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
>> 7 files changed, 43 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> index 2a32b66959ba..130a0a0c8332 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
>> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
>> REG_SET(OUTPUT_CSC_CONTROL, 0,
>> OUTPUT_CSC_GRPH_MODE, 0);
>> break;
>> - break;
>> case COLOR_SPACE_SRGB_LIMITED:
>> /* TV RGB */
>> REG_SET(OUTPUT_CSC_CONTROL, 0,
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> index d741787f75dc..42c7d157da32 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
>> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> index 2bbfa2e176a9..382581c4a674 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
>> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> index b622b4b1dac3..7b4b2304bbff 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
>> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> index 16fe7344702f..3d782b7c86cb 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
>> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> index 5a5a9cb77acb..e9dd78c484d6 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
>> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> index 0eae8cd35f9a..9dbf658162cd 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
>> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
>> switch (transmitter) {
>> case TRANSMITTER_UNIPHY_A:
>> return 0;
>> - break;
>> case TRANSMITTER_UNIPHY_B:
>> return 1;
>> - break;
>> case TRANSMITTER_UNIPHY_C:
>> return 2;
>> - break;
>> case TRANSMITTER_UNIPHY_D:
>> return 3;
>> - break;
>> case TRANSMITTER_UNIPHY_E:
>> return 4;
>> - break;
>> case TRANSMITTER_UNIPHY_F:
>> return 5;
>> - break;
>> case TRANSMITTER_UNIPHY_G:
>> return 6;
>> - break;
>> default:
>> ASSERT(0);
>> return 0;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
2020-10-19 15:08 ` Harry Wentland
(?)
@ 2020-10-22 4:56 ` Alex Deucher
-1 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2020-10-22 4:56 UTC (permalink / raw)
To: Harry Wentland
Cc: Christian König, trix, Leo (Sunpeng) Li, Deucher, Alexander,
Dave Airlie, Daniel Vetter, Mauro Rossi, Anthony Koo, Siqueira,
Rodrigo, Cheng, Tony, Charlene Liu, yogesh.mohanmarimuthu, Cyr,
Aric, Igor.Kravchenko, Colin Ian King, Tao Zhou, Dennis Li,
Mario Kleiner, Maling list - DRI developers, amd-gfx list, LKML
Applied. Thanks!
Alex
On Mon, Oct 19, 2020 at 11:08 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-10-19 10:55 a.m., Christian König wrote:
> > Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> >> From: Tom Rix <trix@redhat.com>
> >>
> >> A break is not needed if it is preceded by a return or break
> >>
> >> Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > Acked-by: Christian König <christian.koenig@amd.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> >
> >> ---
> >> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
> >> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
> >> 7 files changed, 43 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> index 2a32b66959ba..130a0a0c8332 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
> >> REG_SET(OUTPUT_CSC_CONTROL, 0,
> >> OUTPUT_CSC_GRPH_MODE, 0);
> >> break;
> >> - break;
> >> case COLOR_SPACE_SRGB_LIMITED:
> >> /* TV RGB */
> >> REG_SET(OUTPUT_CSC_CONTROL, 0,
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> index d741787f75dc..42c7d157da32 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> index 2bbfa2e176a9..382581c4a674 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> index b622b4b1dac3..7b4b2304bbff 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> index 16fe7344702f..3d782b7c86cb 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> index 5a5a9cb77acb..e9dd78c484d6 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> index 0eae8cd35f9a..9dbf658162cd 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-22 4:56 ` Alex Deucher
0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2020-10-22 4:56 UTC (permalink / raw)
To: Harry Wentland
Cc: Charlene Liu, LKML, Leo (Sunpeng) Li, trix, Mauro Rossi,
Tao Zhou, Siqueira, Rodrigo, Maling list - DRI developers,
Igor.Kravchenko, yogesh.mohanmarimuthu, Dave Airlie, Cheng, Tony,
amd-gfx list, Deucher, Alexander, Colin Ian King, Anthony Koo,
Christian König, Dennis Li
Applied. Thanks!
Alex
On Mon, Oct 19, 2020 at 11:08 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-10-19 10:55 a.m., Christian König wrote:
> > Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> >> From: Tom Rix <trix@redhat.com>
> >>
> >> A break is not needed if it is preceded by a return or break
> >>
> >> Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > Acked-by: Christian König <christian.koenig@amd.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> >
> >> ---
> >> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
> >> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
> >> 7 files changed, 43 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> index 2a32b66959ba..130a0a0c8332 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
> >> REG_SET(OUTPUT_CSC_CONTROL, 0,
> >> OUTPUT_CSC_GRPH_MODE, 0);
> >> break;
> >> - break;
> >> case COLOR_SPACE_SRGB_LIMITED:
> >> /* TV RGB */
> >> REG_SET(OUTPUT_CSC_CONTROL, 0,
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> index d741787f75dc..42c7d157da32 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> index 2bbfa2e176a9..382581c4a674 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> index b622b4b1dac3..7b4b2304bbff 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> index 16fe7344702f..3d782b7c86cb 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> index 5a5a9cb77acb..e9dd78c484d6 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> index 0eae8cd35f9a..9dbf658162cd 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded break
@ 2020-10-22 4:56 ` Alex Deucher
0 siblings, 0 replies; 12+ messages in thread
From: Alex Deucher @ 2020-10-22 4:56 UTC (permalink / raw)
To: Harry Wentland
Cc: Charlene Liu, Cyr, Aric, LKML, Leo (Sunpeng) Li, trix,
Mauro Rossi, Tao Zhou, Siqueira, Rodrigo, Mario Kleiner,
Maling list - DRI developers, Igor.Kravchenko,
yogesh.mohanmarimuthu, Dave Airlie, Cheng, Tony, amd-gfx list,
Daniel Vetter, Deucher, Alexander, Colin Ian King, Anthony Koo,
Christian König, Dennis Li
Applied. Thanks!
Alex
On Mon, Oct 19, 2020 at 11:08 AM Harry Wentland <harry.wentland@amd.com> wrote:
>
> On 2020-10-19 10:55 a.m., Christian König wrote:
> > Am 19.10.20 um 16:43 schrieb trix@redhat.com:
> >> From: Tom Rix <trix@redhat.com>
> >>
> >> A break is not needed if it is preceded by a return or break
> >>
> >> Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > Acked-by: Christian König <christian.koenig@amd.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
> >
> >> ---
> >> drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 1 -
> >> drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c | 7 -------
> >> drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 7 -------
> >> 7 files changed, 43 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> index 2a32b66959ba..130a0a0c8332 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> >> @@ -1330,7 +1330,6 @@ static bool configure_graphics_mode(
> >> REG_SET(OUTPUT_CSC_CONTROL, 0,
> >> OUTPUT_CSC_GRPH_MODE, 0);
> >> break;
> >> - break;
> >> case COLOR_SPACE_SRGB_LIMITED:
> >> /* TV RGB */
> >> REG_SET(OUTPUT_CSC_CONTROL, 0,
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> index d741787f75dc..42c7d157da32 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
> >> @@ -418,25 +418,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> index 2bbfa2e176a9..382581c4a674 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> >> @@ -471,25 +471,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> index b622b4b1dac3..7b4b2304bbff 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> >> @@ -446,25 +446,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> index 16fe7344702f..3d782b7c86cb 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> >> @@ -383,25 +383,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> index 5a5a9cb77acb..e9dd78c484d6 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce60/dce60_resource.c
> >> @@ -453,25 +453,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >> diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> index 0eae8cd35f9a..9dbf658162cd 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c
> >> @@ -458,25 +458,18 @@ static int map_transmitter_id_to_phy_instance(
> >> switch (transmitter) {
> >> case TRANSMITTER_UNIPHY_A:
> >> return 0;
> >> - break;
> >> case TRANSMITTER_UNIPHY_B:
> >> return 1;
> >> - break;
> >> case TRANSMITTER_UNIPHY_C:
> >> return 2;
> >> - break;
> >> case TRANSMITTER_UNIPHY_D:
> >> return 3;
> >> - break;
> >> case TRANSMITTER_UNIPHY_E:
> >> return 4;
> >> - break;
> >> case TRANSMITTER_UNIPHY_F:
> >> return 5;
> >> - break;
> >> case TRANSMITTER_UNIPHY_G:
> >> return 6;
> >> - break;
> >> default:
> >> ASSERT(0);
> >> return 0;
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-10-22 4:56 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-19 14:43 [PATCH] drm/amdgpu: remove unneeded break trix
2020-10-19 14:43 ` trix
2020-10-19 14:43 ` trix
2020-10-19 14:55 ` Christian König
2020-10-19 14:55 ` Christian König
2020-10-19 14:55 ` Christian König
2020-10-19 15:08 ` Harry Wentland
2020-10-19 15:08 ` Harry Wentland
2020-10-19 15:08 ` Harry Wentland
2020-10-22 4:56 ` Alex Deucher
2020-10-22 4:56 ` Alex Deucher
2020-10-22 4:56 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.