All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuantian Tang <Yuantian.Tang@freescale.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
	Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	Hongbo Zhang <hongbo.zhang@freescale.com>,
	"LeoLi@freescale.com" <LeoLi@freescale.com>
Subject: RE: [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data
Date: Wed, 10 Sep 2014 06:19:31 +0000	[thread overview]
Message-ID: <719d2a46508b4ff0b34d48d10d06c104@BY2PR03MB570.namprd03.prod.outlook.com> (raw)
In-Reply-To: <CAKohpo=nLFxv3gpxZLseVYSqGRdyktRzj8GGv5oC20Lq6=s0wA@mail.gmail.com>

Ok, sure.

Thanks,
Yuantian

> -----Original Message-----
> From: Viresh Kumar [mailto:viresh.kumar@linaro.org]
> Sent: Wednesday, September 10, 2014 1:39 PM
> To: Tang Yuantian-B29983
> Cc: Rafael Wysocki; Lists linaro-kernel; linux-pm@vger.kernel.org; Zhang
> Hongbo-B45939; Li Yang-Leo-R58472
> Subject: Re: [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of
> cpu_data
> 
> On 10 September 2014 11:00, Yuantian Tang <Yuantian.Tang@freescale.com>
> wrote:
> >> On 2 September 2014 09:11, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >> > 'cpu_data' is updated for policy->cpu first and then for all CPUs
> >> > in
> >> > policy->cpus. policy->cpus is guaranteed to contain policy->cpu as
> >> > policy->well and so
> >> > the first write to 'cpu_data' for policy->cpu is redundant. Remove it.
> 
> > Yeah, your patch should be ok, but is it the best solution?
> > I was thinking about a final solution just like ARM did.
> 
> I was talking about an Ack for just 1/2 where we are doing some cleanup, which
> shouldn't break anything.
> 
> Regarding the second patch, yes you should come up with something that can
> give a list of online+offline CPUs like ARM and even some ppc drivers.
> We can handle that separately and this patch can be commited by Rafael..
> 
> Either you can give a replacement patch for 2/2 or you can let me know what to
> do and will help there.

  reply	other threads:[~2014-09-10  6:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02  3:41 [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data Viresh Kumar
2014-09-02  3:41 ` [PATCH 2/2] cpufreq: ppc-corenet: remove per-cpu variable 'cpu_mask' Viresh Kumar
2014-09-02  6:46   ` Yuantian Tang
2014-09-02  6:49     ` Viresh Kumar
2014-09-02  7:02       ` Yuantian Tang
2014-09-02  7:09         ` Viresh Kumar
2014-09-02  8:08           ` Yuantian Tang
2014-09-03  8:02           ` Yuantian Tang
2014-09-03  9:50             ` Viresh Kumar
2014-09-04  2:51               ` Yuantian Tang
2014-09-04  3:38                 ` Viresh Kumar
2014-09-04  4:33                   ` Yuantian Tang
2014-09-04  4:37                     ` Viresh Kumar
2014-09-05  9:35                       ` Yuantian Tang
2014-09-05  9:40                         ` Viresh Kumar
2014-09-02  6:38 ` [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data Yuantian Tang
2014-09-02  6:47   ` Viresh Kumar
2014-09-10  4:32 ` Viresh Kumar
2014-09-10  5:30   ` Yuantian Tang
2014-09-10  5:39     ` Viresh Kumar
2014-09-10  6:19       ` Yuantian Tang [this message]
2014-09-10  6:20 ` Yuantian Tang
2014-09-24 23:45 ` Rafael J. Wysocki
2014-09-29  9:05   ` Viresh Kumar
2014-09-29 23:41     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=719d2a46508b4ff0b34d48d10d06c104@BY2PR03MB570.namprd03.prod.outlook.com \
    --to=yuantian.tang@freescale.com \
    --cc=LeoLi@freescale.com \
    --cc=hongbo.zhang@freescale.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.