From: Viresh Kumar <viresh.kumar@linaro.org>
To: Yuantian Tang <Yuantian.Tang@freescale.com>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"LeoLi@freescale.com" <LeoLi@freescale.com>,
Hongtao Jia <hongtao.jia@freescale.com>
Subject: Re: [PATCH 2/2] cpufreq: ppc-corenet: remove per-cpu variable 'cpu_mask'
Date: Thu, 4 Sep 2014 09:08:18 +0530 [thread overview]
Message-ID: <CAKohpokZ9vGJzD0G8n=rg8qQJEuZZpuz=X7XNn_UarKbyOmQxw@mail.gmail.com> (raw)
In-Reply-To: <21e79b8a95ca443a9844fc2b79ec5379@BY2PR03MB570.namprd03.prod.outlook.com>
On 4 September 2014 08:21, Yuantian Tang <Yuantian.Tang@freescale.com> wrote:
> Can't agree you more.
Its not about upstreaming my patch but doing the right thing.
> As I know, there is no such function to get mask of online and offline cpus in a cluster.
This is a primary requirement of cpufreq-subsystem. The ->init()
callback must initialize
policy->cpus to the mask of all online+offline CPUs that are sharing clock.
Okay, then what I can say is your driver is already broken (without my
patch) when we
use it as a module.
>> - build driver as module and don't load it by default
>> - boot your system
>> - offline CPUs 8 to 15 as you did above.
>> - insert module
>> - try to online cores as you did above.
Above sequence of events would reproduce similar crash for you. So, either
fix this problem or mark your module as 'bool' instead of 'tristate' so that it
can't be compiled as module anymore.
--
viresh
next prev parent reply other threads:[~2014-09-04 3:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 3:41 [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data Viresh Kumar
2014-09-02 3:41 ` [PATCH 2/2] cpufreq: ppc-corenet: remove per-cpu variable 'cpu_mask' Viresh Kumar
2014-09-02 6:46 ` Yuantian Tang
2014-09-02 6:49 ` Viresh Kumar
2014-09-02 7:02 ` Yuantian Tang
2014-09-02 7:09 ` Viresh Kumar
2014-09-02 8:08 ` Yuantian Tang
2014-09-03 8:02 ` Yuantian Tang
2014-09-03 9:50 ` Viresh Kumar
2014-09-04 2:51 ` Yuantian Tang
2014-09-04 3:38 ` Viresh Kumar [this message]
2014-09-04 4:33 ` Yuantian Tang
2014-09-04 4:37 ` Viresh Kumar
2014-09-05 9:35 ` Yuantian Tang
2014-09-05 9:40 ` Viresh Kumar
2014-09-02 6:38 ` [PATCH 1/2] cpufreq: ppc-corenet: remove duplicate update of cpu_data Yuantian Tang
2014-09-02 6:47 ` Viresh Kumar
2014-09-10 4:32 ` Viresh Kumar
2014-09-10 5:30 ` Yuantian Tang
2014-09-10 5:39 ` Viresh Kumar
2014-09-10 6:19 ` Yuantian Tang
2014-09-10 6:20 ` Yuantian Tang
2014-09-24 23:45 ` Rafael J. Wysocki
2014-09-29 9:05 ` Viresh Kumar
2014-09-29 23:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKohpokZ9vGJzD0G8n=rg8qQJEuZZpuz=X7XNn_UarKbyOmQxw@mail.gmail.com' \
--to=viresh.kumar@linaro.org \
--cc=LeoLi@freescale.com \
--cc=Yuantian.Tang@freescale.com \
--cc=hongtao.jia@freescale.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.