All of lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Kooi <koen@dominion.thruhere.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] gdk-pixbuf: Add --with-x11 when building lsb image
Date: Tue, 24 Apr 2012 08:29:37 +0200	[thread overview]
Message-ID: <71A92016-D7C8-4834-8E80-849F267B3B8C@dominion.thruhere.net> (raw)
In-Reply-To: <4F964456.6050106@windriver.com>


Op 24 apr. 2012, om 08:12 heeft Xiaofeng Yan het volgende geschreven:

> On 2012年04月24日 13:53, Koen Kooi wrote:
>> Op 24 apr. 2012, om 07:50 heeft Xiaofeng Yan het volgende geschreven:
>> 
>> 
>>> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
>>> 
>>> 
>>> LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
>>> because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
>>> For passing lsb test I add PACKAGECONFIG support to the recipe and \
>>> have poky-lsb turn on the poky-lsb distro for this recipe.
>>> 
>>> [YOCTO #2284]
>>> 
>> Shouldn't this be an 'x11' DISTRO_FEATURE instead?
>> 
> because "--without-x11" is disabled when x11 exists in core-image-sato. Using 'x11' DISTRO_FEATURE instead will change the default set, which will cause enable "--with-x11" when x11 is in DISTRO_FEATURE. LSB Test Suite need this configuration but other image may not need it even if having x11.

What use-case is there for having 'x11' in DISTRO_FEATURES but not wanting x11 support in pixbuf?

Regardless of that, poky-lsb distro overrides have no place in oe-core, they should go into their own layer as bbappends.

regards,

Koen


  reply	other threads:[~2012-04-24  6:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-24  5:50 [PATCH 0/1]:gdk-pixbuf: Add --with-x11 when building lsb image Xiaofeng Yan
2012-04-24  5:50 ` [PATCH 1/1] gdk-pixbuf: " Xiaofeng Yan
2012-04-24  5:53   ` Koen Kooi
2012-04-24  6:12     ` Xiaofeng Yan
2012-04-24  6:29       ` Koen Kooi [this message]
2012-04-24  7:29         ` Richard Purdie
2012-04-24  8:59           ` Xiaofeng Yan
2012-04-24 21:02   ` Error compiling Boost with Python support on 64-bit host for 32-bit target Tasslehoff Kjappfot
2012-04-24  9:44     ` Richard Purdie
2012-04-24 21:46       ` Tasslehoff Kjappfot
2012-04-24 21:04     ` Tasslehoff Kjappfot
2012-04-24 23:14     ` [PATCH] boost: set python-root correctly Tasslehoff Kjappfot
2012-04-24 11:52       ` Koen Kooi
2012-04-25  0:12     ` Tasslehoff Kjappfot
2012-04-27 21:05       ` Saul Wold
2012-04-27  8:39 [PATCH 0/1] gdk-pixbuf: Add --with-x11 when building lsb image Xiaofeng Yan
2012-04-27  8:39 ` [PATCH 1/1] " Xiaofeng Yan
2012-04-27 10:58   ` Richard Purdie
2012-04-28  3:19     ` Xiaofeng Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71A92016-D7C8-4834-8E80-849F267B3B8C@dominion.thruhere.net \
    --to=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.