From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: andi@etezian.org
Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com,
krzk@kernel.org, linux-spi@vger.kernel.org, broonie@kernel.org,
kgene@kernel.org, linux-arm-kernel@lists.infradead.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH 3/6] spi: spi-s3c64xx: Drop unused enable_datapath() function argument
Date: Tue, 17 Apr 2018 12:02:54 +0200 [thread overview]
Message-ID: <71b98ebb-550e-60af-36cb-0196cf738e54@samsung.com> (raw)
In-Reply-To: <167c0f1a1a9de44574523c7f4a9d137d@etezian.org>
Hi Andi,
On 04/16/2018 09:09 PM, andi@etezian.org wrote:
> On 17.04.2018 00:40, Sylwester Nawrocki wrote:
>> The spi pointer argument is not used now so remove it. While at it
>> s3c64xx_ prefix is added to the function name.
>
> These for me are two different patches, but in any case it's trivial
> so that I don't mind it too much.
I am going to drop renaming from this patch. There are 2 more functions
(wait_for_pio(), wait_for_dma()) without prefix, should we rename them
too or rather leave all 3 as they are now?
--
Regards,
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: s.nawrocki@samsung.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] spi: spi-s3c64xx: Drop unused enable_datapath() function argument
Date: Tue, 17 Apr 2018 12:02:54 +0200 [thread overview]
Message-ID: <71b98ebb-550e-60af-36cb-0196cf738e54@samsung.com> (raw)
In-Reply-To: <167c0f1a1a9de44574523c7f4a9d137d@etezian.org>
Hi Andi,
On 04/16/2018 09:09 PM, andi at etezian.org wrote:
> On 17.04.2018 00:40, Sylwester Nawrocki wrote:
>> The spi pointer argument is not used now so remove it. While at it
>> s3c64xx_ prefix is added to the function name.
>
> These for me are two different patches, but in any case it's trivial
> so that I don't mind it too much.
I am going to drop renaming from this patch. There are 2 more functions
(wait_for_pio(), wait_for_dma()) without prefix, should we rename them
too or rather leave all 3 as they are now?
--
Regards,
Sylwester
next prev parent reply other threads:[~2018-04-17 10:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180416154055epcas2p4c08bb2254e79368a29eb481cddc59855@epcas2p4.samsung.com>
2018-04-16 15:40 ` [PATCH 1/6] spi: spi-s3c64xx: Remove unused driver data structure tgl_spi field Sylwester Nawrocki
2018-04-16 15:40 ` Sylwester Nawrocki
[not found] ` <CGME20180416154109epcas2p1696b9cdc72403fe5abdd0a2117067c8d@epcas2p1.samsung.com>
2018-04-16 15:40 ` [PATCH 2/6] spi: spi-s3c64xx: Remove unused s3c64xx_spi_hwinit() function argument Sylwester Nawrocki
2018-04-16 15:40 ` Sylwester Nawrocki
2018-04-16 19:06 ` andi
2018-04-16 19:06 ` andi at etezian.org
2018-04-17 6:28 ` Krzysztof Kozlowski
2018-04-17 6:28 ` Krzysztof Kozlowski
[not found] ` <CGME20180416154122epcas1p1ae714af12f8da08783c47fcd820c40e7@epcas1p1.samsung.com>
2018-04-16 15:40 ` [PATCH 3/6] spi: spi-s3c64xx: Drop unused enable_datapath() " Sylwester Nawrocki
2018-04-16 15:40 ` Sylwester Nawrocki
2018-04-16 19:09 ` andi
2018-04-16 19:09 ` andi at etezian.org
2018-04-17 10:02 ` Sylwester Nawrocki [this message]
2018-04-17 10:02 ` Sylwester Nawrocki
2018-04-17 10:51 ` Krzysztof Kozlowski
2018-04-17 10:51 ` Krzysztof Kozlowski
2018-04-17 6:28 ` Krzysztof Kozlowski
2018-04-17 6:28 ` Krzysztof Kozlowski
[not found] ` <CGME20180416154130epcas1p492c86e911db645acf32d960281e8b297@epcas1p4.samsung.com>
2018-04-16 15:40 ` [PATCH 4/6] spi: spi-s3c64xx: Do not ignore timeout errors in polling I/O mode Sylwester Nawrocki
2018-04-16 15:40 ` Sylwester Nawrocki
2018-04-16 19:12 ` andi
2018-04-16 19:12 ` andi at etezian.org
2018-04-17 6:30 ` Krzysztof Kozlowski
2018-04-17 6:30 ` Krzysztof Kozlowski
2018-04-17 10:02 ` Mark Brown
2018-04-17 10:02 ` Mark Brown
[not found] ` <CGME20180416154158epcas2p3120ff2617db98504c4e48d5cc4c42036@epcas2p3.samsung.com>
2018-04-16 15:40 ` [PATCH 5/6] spi: spi-s3c64xx: Fix indentation in the register offset definitions Sylwester Nawrocki
2018-04-16 15:40 ` Sylwester Nawrocki
2018-04-16 19:14 ` andi
2018-04-16 19:14 ` andi at etezian.org
2018-04-17 6:30 ` Krzysztof Kozlowski
2018-04-17 6:30 ` Krzysztof Kozlowski
[not found] ` <CGME20180416154208epcas1p1774dd679e3564be916901a180315943b@epcas1p1.samsung.com>
2018-04-16 15:40 ` [PATCH 6/6] spi: spi-s3c64xx: Allow higher transfer lengths in polling IO mode Sylwester Nawrocki
2018-04-16 15:40 ` Sylwester Nawrocki
2018-04-16 19:19 ` andi
2018-04-16 19:19 ` andi at etezian.org
2018-04-17 9:07 ` Sylwester Nawrocki
2018-04-17 9:07 ` Sylwester Nawrocki
2018-04-16 19:04 ` [PATCH 1/6] spi: spi-s3c64xx: Remove unused driver data structure tgl_spi field andi
2018-04-16 19:04 ` andi at etezian.org
2018-04-17 6:27 ` Krzysztof Kozlowski
2018-04-17 6:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b98ebb-550e-60af-36cb-0196cf738e54@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=andi@etezian.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.