All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: <kael_w@yeah.net>, Russell King <linux@armlinux.org.uk>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: at91: pm: Add of_node_put() before goto
Date: Wed, 8 Dec 2021 14:00:03 +0100	[thread overview]
Message-ID: <71c4c30c-3344-54ad-5aba-cb950bfaaa7b@microchip.com> (raw)
In-Reply-To: <20211014084555.21422-1-wanjiabing@vivo.com>

On 14/10/2021 at 10:45, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./arch/arm/mach-at91/pm.c:643:1-33: WARNING: Function
> for_each_matching_node_and_match should have of_node_put() before goto
> 
> Early exits from for_each_matching_node_and_match should decrement the
> node reference counter.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Even if I think it doesn't happen after a new SoC DT is in place 
properly, I'm fine with this:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/mach-at91/pm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 8711d6824c1f..dd6f4ce3f766 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -645,6 +645,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
>                  if (!soc_pm.data.ramc[idx]) {
>                          pr_err("unable to map ramc[%d] cpu registers\n", idx);
>                          ret = -ENOMEM;
> +                       of_node_put(np);
>                          goto unmap_ramc;
>                  }
> 
> @@ -670,6 +671,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
>                  if (!soc_pm.data.ramc_phy) {
>                          pr_err("unable to map ramc phy cpu registers\n");
>                          ret = -ENOMEM;
> +                       of_node_put(np);
>                          goto unmap_ramc;
>                  }
>          }
> --
> 2.20.1
> 


-- 
Nicolas Ferre

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: <kael_w@yeah.net>, Russell King <linux@armlinux.org.uk>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: at91: pm: Add of_node_put() before goto
Date: Wed, 8 Dec 2021 14:00:03 +0100	[thread overview]
Message-ID: <71c4c30c-3344-54ad-5aba-cb950bfaaa7b@microchip.com> (raw)
In-Reply-To: <20211014084555.21422-1-wanjiabing@vivo.com>

On 14/10/2021 at 10:45, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./arch/arm/mach-at91/pm.c:643:1-33: WARNING: Function
> for_each_matching_node_and_match should have of_node_put() before goto
> 
> Early exits from for_each_matching_node_and_match should decrement the
> node reference counter.
> 
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>

Even if I think it doesn't happen after a new SoC DT is in place 
properly, I'm fine with this:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

Thanks, best regards,
   Nicolas

> ---
>   arch/arm/mach-at91/pm.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 8711d6824c1f..dd6f4ce3f766 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -645,6 +645,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
>                  if (!soc_pm.data.ramc[idx]) {
>                          pr_err("unable to map ramc[%d] cpu registers\n", idx);
>                          ret = -ENOMEM;
> +                       of_node_put(np);
>                          goto unmap_ramc;
>                  }
> 
> @@ -670,6 +671,7 @@ static __init int at91_dt_ramc(bool phy_mandatory)
>                  if (!soc_pm.data.ramc_phy) {
>                          pr_err("unable to map ramc phy cpu registers\n");
>                          ret = -ENOMEM;
> +                       of_node_put(np);
>                          goto unmap_ramc;
>                  }
>          }
> --
> 2.20.1
> 


-- 
Nicolas Ferre

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-08 13:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14  8:45 [PATCH] ARM: at91: pm: Add of_node_put() before goto Wan Jiabing
2021-10-14  8:45 ` Wan Jiabing
2021-12-08 13:00 ` Nicolas Ferre [this message]
2021-12-08 13:00   ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71c4c30c-3344-54ad-5aba-cb950bfaaa7b@microchip.com \
    --to=nicolas.ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=kael_w@yeah.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=ludovic.desroches@microchip.com \
    --cc=wanjiabing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.