From: Sekhar Nori <nsekhar@ti.com> To: Axel Haslam <ahaslam@baylibre.com>, <khilman@baylibre.com>, <ptitiano@baylibre.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor for mmc pins Date: Mon, 28 Nov 2016 13:44:38 +0530 [thread overview] Message-ID: <71d110ec-486b-5f26-1566-0fb9de93227e@ti.com> (raw) In-Reply-To: <20161124150454.23899-2-ahaslam@baylibre.com> On Thursday 24 November 2016 08:34 PM, Axel Haslam wrote: > Currently the mmc driver is polling the gpio to know if the > card was removed. > > By using a gpio descriptor instead of the platform callbacks, > the driver will be able to register the gpio using the mmc core > API's designed for this purpose. s/API's/APIs > > This has the advantage that an irq will be registered, and > polling is no longer needed. Also, a dependency on platform > callbacks is removed for this board. > > Signed-off-by: Axel Haslam <ahaslam@baylibre.com> > --- > arch/arm/mach-davinci/board-omapl138-hawk.c | 42 ++++++++--------------------- > 1 file changed, 11 insertions(+), 31 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c > index a4e8726..a2966d3 100644 > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c > @@ -15,6 +15,7 @@ > #include <linux/gpio.h> > #include <linux/platform_data/gpio-davinci.h> > #include <linux/regulator/machine.h> > +#include <linux/gpio/machine.h> Moved this include to below linux/gpio.h Applied to v4.10/soc Thanks, Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor for mmc pins Date: Mon, 28 Nov 2016 13:44:38 +0530 [thread overview] Message-ID: <71d110ec-486b-5f26-1566-0fb9de93227e@ti.com> (raw) In-Reply-To: <20161124150454.23899-2-ahaslam@baylibre.com> On Thursday 24 November 2016 08:34 PM, Axel Haslam wrote: > Currently the mmc driver is polling the gpio to know if the > card was removed. > > By using a gpio descriptor instead of the platform callbacks, > the driver will be able to register the gpio using the mmc core > API's designed for this purpose. s/API's/APIs > > This has the advantage that an irq will be registered, and > polling is no longer needed. Also, a dependency on platform > callbacks is removed for this board. > > Signed-off-by: Axel Haslam <ahaslam@baylibre.com> > --- > arch/arm/mach-davinci/board-omapl138-hawk.c | 42 ++++++++--------------------- > 1 file changed, 11 insertions(+), 31 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c b/arch/arm/mach-davinci/board-omapl138-hawk.c > index a4e8726..a2966d3 100644 > --- a/arch/arm/mach-davinci/board-omapl138-hawk.c > +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c > @@ -15,6 +15,7 @@ > #include <linux/gpio.h> > #include <linux/platform_data/gpio-davinci.h> > #include <linux/regulator/machine.h> > +#include <linux/gpio/machine.h> Moved this include to below linux/gpio.h Applied to v4.10/soc Thanks, Sekhar
next prev parent reply other threads:[~2016-11-28 8:15 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-24 15:04 [PATCH v2 0/3] ARM: davinci: use gpio descriptors for mmc pins Axel Haslam 2016-11-24 15:04 ` Axel Haslam 2016-11-24 15:04 ` [PATCH v2 1/3] ARM: davinci: hawk: use gpio descriptor " Axel Haslam 2016-11-24 15:04 ` Axel Haslam 2016-11-28 8:14 ` Sekhar Nori [this message] 2016-11-28 8:14 ` Sekhar Nori 2016-11-24 15:04 ` [PATCH v2 2/3] ARM: davinci: da850-evm: " Axel Haslam 2016-11-24 15:04 ` Axel Haslam 2016-11-28 8:19 ` Sekhar Nori 2016-11-28 8:19 ` Sekhar Nori 2016-11-24 15:04 ` [PATCH v2 3/3] ARM: davinci: da830-evm: " Axel Haslam 2016-11-24 15:04 ` Axel Haslam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=71d110ec-486b-5f26-1566-0fb9de93227e@ti.com \ --to=nsekhar@ti.com \ --cc=ahaslam@baylibre.com \ --cc=khilman@baylibre.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ptitiano@baylibre.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.