From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
davem@davemloft.net, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 3/8] net: bridge: vlan: add rtm definitions and dump support
Date: Tue, 14 Jan 2020 19:52:27 +0200 [thread overview]
Message-ID: <71fd75c5-3bb2-abf8-4977-50911d49e142@cumulusnetworks.com> (raw)
In-Reply-To: <473cb0a5-f6ad-ccd3-9186-02713f9cb92f@gmail.com>
On 14/01/2020 18:53, David Ahern wrote:
> On 1/14/20 9:50 AM, Nikolay Aleksandrov wrote:
>> Ah fair enough, so nlmsg_parse() would be better even without attrs.
>
> that was the intention. It would be a good verification of the theory if
> you could run a test with a larger ancillary header.
>
Just did, works like expected. Tested all sorts of wrong messages and attributes,
they get properly validated and thrown out.
Sending v2 in a minute. :)
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: David Ahern <dsahern@gmail.com>, Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 3/8] net: bridge: vlan: add rtm definitions and dump support
Date: Tue, 14 Jan 2020 19:52:27 +0200 [thread overview]
Message-ID: <71fd75c5-3bb2-abf8-4977-50911d49e142@cumulusnetworks.com> (raw)
In-Reply-To: <473cb0a5-f6ad-ccd3-9186-02713f9cb92f@gmail.com>
On 14/01/2020 18:53, David Ahern wrote:
> On 1/14/20 9:50 AM, Nikolay Aleksandrov wrote:
>> Ah fair enough, so nlmsg_parse() would be better even without attrs.
>
> that was the intention. It would be a good verification of the theory if
> you could run a test with a larger ancillary header.
>
Just did, works like expected. Tested all sorts of wrong messages and attributes,
they get properly validated and thrown out.
Sending v2 in a minute. :)
Thanks!
next prev parent reply other threads:[~2020-01-14 17:52 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 15:52 [PATCH net-next 0/8] net: bridge: add vlan notifications and rtm support Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 1/8] net: bridge: vlan: add helpers to check for vlan id/range validity Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 2/8] net: bridge: netlink: add extack error messages when processing vlans Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 3/8] net: bridge: vlan: add rtm definitions and dump support Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-14 13:55 ` Jakub Kicinski
2020-01-14 13:55 ` [Bridge] " Jakub Kicinski
2020-01-14 15:34 ` David Ahern
2020-01-14 15:34 ` [Bridge] " David Ahern
2020-01-14 16:36 ` Nikolay Aleksandrov
2020-01-14 16:36 ` [Bridge] " Nikolay Aleksandrov
2020-01-14 16:45 ` Nikolay Aleksandrov
2020-01-14 16:45 ` [Bridge] " Nikolay Aleksandrov
2020-01-14 16:49 ` David Ahern
2020-01-14 16:49 ` [Bridge] " David Ahern
2020-01-14 16:50 ` Nikolay Aleksandrov
2020-01-14 16:50 ` [Bridge] " Nikolay Aleksandrov
2020-01-14 16:53 ` David Ahern
2020-01-14 16:53 ` [Bridge] " David Ahern
2020-01-14 17:52 ` Nikolay Aleksandrov [this message]
2020-01-14 17:52 ` Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 4/8] net: bridge: vlan: add new rtm message support Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 5/8] net: bridge: vlan: add del " Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 6/8] net: bridge: vlan: add rtm range support Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 7/8] net: bridge: vlan: add rtnetlink group and notify support Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
2020-01-13 15:52 ` [PATCH net-next 8/8] net: bridge: vlan: notify on vlan add/delete/change flags Nikolay Aleksandrov
2020-01-13 15:52 ` [Bridge] " Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71fd75c5-3bb2-abf8-4977-50911d49e142@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.