[Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics

* [Xen-devel] [PATCH for-4.13] x86/VT-d: Drop unhelpful information in diagnostics
@ 2019-10-11 15:02 Andrew Cooper
  2019-10-11 15:33 ` Roger Pau Monné
  2019-10-14 13:44 ` Jürgen Groß
  0 siblings, 2 replies; 5+ messages in thread
From: Andrew Cooper @ 2019-10-11 15:02 UTC (permalink / raw)
  To: Xen-devel
  Cc: Juergen Gross, Kevin Tian, Jan Beulich, Wei Liu, Andrew Cooper,
	Jun Nakajima, Roger Pau Monné

The virtual address of the base of the IOMMU's regsters is not useful for
diagnostic purposes, and is quite voluminous.  The PCI coordinates is by far
the most useful piece of identifying information.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
CC: Kevin Tian <kevin.tian@intel.com>
CC: Juergen Gross <jgross@suse.com>

Surrounding printk()s also identify the IOMMU by Xen's internal ID, but that
is also pretty useless information when diagnosing problems.

RFC for-4.13.  This is a nice to have stylistic improvement.
---
 xen/drivers/passthrough/vtd/iommu.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough/vtd/iommu.c
index f08eec070d..0522ecd3bc 100644
--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -842,26 +842,26 @@ static int iommu_page_fault_do_one(struct vtd_iommu *iommu, int type,
     case DMA_REMAP:
         printk(XENLOG_G_WARNING VTDPREFIX
                "DMAR:[%s] Request device [%04x:%02x:%02x.%u] "
-               "fault addr %"PRIx64", iommu reg = %p\n",
+               "fault addr %"PRIx64"\n",
                (type ? "DMA Read" : "DMA Write"),
                seg, PCI_BUS(source_id), PCI_SLOT(source_id),
-               PCI_FUNC(source_id), addr, iommu->reg);
+               PCI_FUNC(source_id), addr);
         kind = "DMAR";
         break;
     case INTR_REMAP:
         printk(XENLOG_G_WARNING VTDPREFIX
                "INTR-REMAP: Request device [%04x:%02x:%02x.%u] "
-               "fault index %"PRIx64", iommu reg = %p\n",
+               "fault index %"PRIx64"\n",
                seg, PCI_BUS(source_id), PCI_SLOT(source_id),
-               PCI_FUNC(source_id), addr >> 48, iommu->reg);
+               PCI_FUNC(source_id), addr >> 48);
         kind = "INTR-REMAP";
         break;
     default:
         printk(XENLOG_G_WARNING VTDPREFIX
                "UNKNOWN: Request device [%04x:%02x:%02x.%u] "
-               "fault addr %"PRIx64", iommu reg = %p\n",
+               "fault addr %"PRIx64"\n",
                seg, PCI_BUS(source_id), PCI_SLOT(source_id),
-               PCI_FUNC(source_id), addr, iommu->reg);
+               PCI_FUNC(source_id), addr);
         kind = "UNKNOWN";
         break;
     }
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread